Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
11:26, 3rd Jun 2011
Maker:
Discharge:
Offest by 1.0 is quite useless:
IcemanBo: Too long as NeedsFix. Rejected.
Reviewed by Maker, Spring Spellpack 2011 v0.4, 26th Jan 2012
Required changes
Also don't create player groups if the floating text booleans are false.
- Point2 is removed in a wrong place in Static Cast
- In Static Lightning Clear, don't do number of units in group checks when any unit dies
- Shatter messes up with the classification of the unit. Store the original classification
- Shatter -> Proper use of Crow Form
- In Shatter Loop, do the turn off check only after you remove a unit from the group
- In BoL Cast, don't use a group enumeration
- There's no point in saving the handle of the caster for the caster
- In BoL Loop you load stuff that you don't necessarily need
- TC Cast seems to leak the effect group. I don't see a point in picking a group only to add the target into it and then instantly removing it from the group
Suggested changes
- You could use tree detection in Static Cast
- Share variables between spells. The spell pack has so many variables. For example you have 20 point variables, you only need about 4 or 5. You could use only one hashtable instead of 7
- Improve tooltips, make them more like standard Blizzard tooltips
Is the spell pack really v0.4? That alone would have been a reason for me not to review this, since going from v0.4 to v1.0 implies major changes, and it is not worth it to revie incomplete resources.
11:26, 3rd Jun 2011
Maker:
Discharge:
Offest by 1.0 is quite useless:
- Set TC_MovePoint = (TC_CasterPoint offset by 1.00 towards TC_Angle degrees)
- Set TC_MovePoint = (TC_MovePoint offset by TC_Speed towards TC_Angle degrees)