[Trigger] Would this Properly work?

[Munich]

• QUESTION?
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • Unit - Move (Attacked unit) instantly to (Position of (Attacking unit))
    • Custom script: call RemoveLocation((GetUnitLoc(GetAttacker())))

Hello, I would like to ask if this is also another way in removing a Location besides using variables
like temp_loc or temp_point, then removing them Manually with:

• Actions
  • Custom script: call RemoveLocation(udg_temp_point) or call RemoveLocation(udg_temp_loc)

 

[edo494]

that wont work, because invoking Position of (...) will always create new location, so the first line creates location, which you leak, and the second line with custom script will create location, which you immediately pass to RemoveLocation, so you remove that one

edit:

I will just note, that 2 locations, that have same x, y, and z are still 2 independant objects

 

[IcemanBo]

Yes like edo said, if you write again GetUnitLoc to remove location, it will create a new location.
--> The one you worked with before will still leak.

 

[Munich]

oh, that clears everything..
Thank you IcemanBo and edo494

 

[Chaosy]

the only thing I think of requires vjass.

hook CreateNUnitsAtLoc

function myfunc takes location loc returns nothing
	local location p = loc
	CreateNUnitsAtLoc(p)
	call RemoveLocation(p)
	call RemoveLocation(loc)
	return
endfunction

this is not working so dont copy it. However I think my idea would leak anyway.

 

[edo494]

with this, you would actually cause permanent recursion

 

[Chaosy]

I dont have the function list so I cant write propper jass atm xD

I think that could work but I think it would crash if you dont send a point variable as a argument. I mean you cant delete a raw point (like center of map etc)

 

[edo494]

afaik, the only raw points are the one, that are initialized in main(Bjs), since everything else is temporary location, including Center of (Playable map area)

And why wont your script work is, because you call CreateNUnitsAtLoc inside hook of that function, and the function will actually be called after your body of hooked function is executed, and if you call it within the hook, you basically execute the trigger, that runs your body, which executes the trigger etc etc, and that is infinte loop

 

[Chaosy]

ah now I get it. I thought hook went before that actuall function too. Oh well that screws my idea twice.

thanks for the info