Wild Energy V1.10

[Moderator]

19th Dec 2011
Bribe: I like it, and the coding skill is above requirements. Approved 4/5 (Recommended).

 

[Magtheridon96]

Comments

• Set WE_TempGroup = (Units within (Load 3 of WE_UHandle from WE_WildEnergyHash) of WE_TempPoint)
• Unit Group - Pick every unit in WE_TempGroup and do (Actions)
  • Loop - Actions
    • Set WE_TempU = (Picked unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (WE_TempU is Magic Immune) Equal to False
        • ((Unit-type of WE_TempU) is A structure) Equal to False
        • (WE_TempU is A ground unit) Equal to True
        • (WE_TempU is alive) Equal to True
        • (WE_TempU belongs to an enemy of (Owner of WE_u)) Equal to True
      • Then - Actions
        • Unit - Cause (Load 4 of WE_UHandle in WE_WildEnergyHash) to damage (Picked unit), dealing (Load 2 of WE_UHandle from WE_WildEnergyHash) damage of attack type Spells and damage type Normal
      • Else - Actions
• Custom script: call DestroyGroup (udg_WE_TempGroup)

You can use that 'set bj_wantDestroyGroup = true' thing instead:

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units within (Load 3 of WE_UHandle from WE_WildEnergyHash) of WE_TempPoint) and do (Actions)
  • Loop - Actions
    • Set WE_TempU = (Picked unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (WE_TempU is Magic Immune) Equal to False
        • ((Unit-type of WE_TempU) is A structure) Equal to False
        • (WE_TempU is A ground unit) Equal to True
        • (WE_TempU is alive) Equal to True
        • (WE_TempU belongs to an enemy of (Owner of WE_u)) Equal to True
      • Then - Actions
        • Unit - Cause (Load 4 of WE_UHandle in WE_WildEnergyHash) to damage (Picked unit), dealing (Load 2 of WE_UHandle from WE_WildEnergyHash) damage of attack type Spells and damage type Normal
      • Else - Actions

edit

In the second trigger:

• Set WE_UHandle = (Key (Last created unit))

->

• Custom script: set udg_WE_UHandle = GetHandleId(udg_WE_TempU)

(Since you already cached the last created unit previously)

Oh and that bj_wantDestroyGroup thing can apply everywhere else too.

edit

• Custom script: call RemoveLocation(udg_WE_TempPoint)

This line should be parallel to this: (meaning that you should put the custom script outside of the For loop.)

• Set WE_TempPoint = (Position of WE_u)

Otherwise, it could leak.

It looks pretty decent overall.

 

[Tank-Commander]

Thanks for the notes, I'll make the appropriate changes momentarily, don't know if I'll bother with the wantdestroygroup thing - I like sticking to the standard format I normally use (even if it's a little less efficient).

Edit: Not sure about the set WE_UHandle change, I'll have to look at it again and get my head around it
Edit2: just got it, give me a second

 

[Almia]

Wow
I never knew this is the most unsubscribed spell of yours