Beserk Plant V1.10

[Moderator]

Reviewed by Maker, Beserk Plant V1.10, 3rd Jan 2012

Nice looking spell. You did well with this. Don't check for each stage during every loop, use if/then/else Learn tooltip should list the stats per each level

Old review

14:31, 22nd Dec 2011
Pharaoh_:

• Hashtable - Save (Distance between BP_TempPoint and BP_TempPoint2) as 7 of BP_UHandle in BP_Hash

Since you have an if/then/else that checks for the minimum range, you could move this on the else statement and save "BP_MinRange" in the "Then" branch, but it's okay as it is.

I'd like some documentation before every hashtable saving call, to let users know what each one does.

I'd rather you used boolean, instead of an integer for the "stages", for readability. Again, nothing serious.

• Set BP_RealCache[4] = (Load 10 of BP_UHandle from BP_Hash)

Use this variable for the calculation purposes of the parabola and use it to refer to, when saving.

Leak

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • BP_RealCache[4] Less than 0.00
  • Then - Actions
    • Set BP_TempPoint = (Position of BP_U)
    • Set BP_TempGroup = (Units within BP_BranchAoe of BP_TempPoint)
    • Unit Group - Pick every unit in BP_TempGroup and do (Actions)
      • Loop - Actions
        • Set BP_TempU = (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (BP_TempU is Magic Immune) Equal to False
            • (BP_TempU is A structure) Equal to False
            • (BP_TempU is alive) Equal to True
            • (BP_TempU belongs to an enemy of (Owner of BP_U)) Equal to True
            • (BP_TempU is A ground unit) Equal to True
            • (BP_TempU is in BP_Plants) Equal to False
          • Then - Actions
            • Custom script: set udg_BP_UHandleC = GetHandleId(udg_BP_TempU)
            • Unit - Cause (Load 1 of BP_UHandle in BP_Hash) to damage BP_TempU, dealing (Load 3 of BP_UHandle from BP_Hash) damage of attack type Spells and damage type Normal
            • Special Effect - Create a special effect at BP_TempPoint using BP_BranchHitSFX
            • Special Effect - Destroy (Last created special effect)
            • Set BP_TempU2 = (Load 2 of BP_UHandle in BP_Hash)
            • Custom script: set udg_BP_TempX = GetUnitX(udg_BP_TempU2)
            • Custom script: set udg_BP_TempY = GetUnitY(udg_BP_TempU2)
            • Hashtable - Save BP_TempX as 17 of BP_UHandleC in BP_Hash
            • Hashtable - Save BP_TempY as 18 of BP_UHandleC in BP_Hash
            • Hashtable - Save (Load 5 of BP_UHandle from BP_Hash) as 16 of BP_UHandleC in BP_Hash
            • Unit Group - Add BP_TempU to BP_Plants
            • Hashtable - Save 4 as 6 of BP_UHandleC in BP_Hash
          • Else - Actions
    • Custom script: call DestroyGroup (udg_BP_TempGroup)
    • Custom script: set udg_BP_UHandleC = GetHandleId(udg_BP_TempU)
    • Unit Group - Remove BP_U from BP_Plants
    • Hashtable - Clear all child hashtables of child BP_UHandle in BP_Hash
    • Unit - Kill BP_U
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (BP_Plants is empty) Equal to True
      • Then - Actions
        • Trigger - Turn off (This trigger)
      • Else - Actions
  • Else - Actions

You forgot to remove the TempPoint.

The spells looks nice.

 

[Tank-Commander]

Subbing, and I thought I'd just mention - all 7 spells on the front page at one time (Victory is mine!)

 

[Magtheridon96]

edit
Nevermind.

By the way, you have to start caching things more often D:
A hashtable lookup is much slower than a variable lookup D:

 

[wickedcool]

wow another Tank-commanders spells damn you so good in making awesome spell effects
btw
how did you make the player enemy cast a spells?

 

[Da Fist]

Wow, looking forward for this to be approved.

 

[Magtheridon96]

Hey, you cached stuff! I LOVE YOU!

 

[Tank-Commander]

how did you make the player enemy cast a spells?

Clicked on the one in the map, set it to level 10 and the ability's level to 3 and pressed "active" it just does it by itself.

Anyway thanks for the support guys =)

 

[Jay the Editor]

Damn! All your spells sure have an epic effect! I damn love it! ><

 

[ALTELMA]

I think is's OK for Effect but I will not expert on analysis system, sorry

 

[wickedcool]

Clicked on the one in the map, set it to level 10 and the ability's level to 3 and pressed "active" it just does it by itself.

ah ok thank you
they cant cast spells when its wave type system right?

 

[RakEnRoL]

Hello there. I would like to rate this spell of yours. I like the spell. The effects were quite okay. The knockback is weird. I first thought that those projectiles might slow the enemies down or anything but knockback. It just doesn't make sense.

Rating: 3.5/5
Nice use of effects
The spell is nice
Coding seems well
I don't get the knockback
Still has room for improvement

 

[Crigges]

This spell is realy nice but I think u shoud reduce the Knockback effects a bit because if used on to much untis by same time it laggs a bit. Still awesome spell!
Idea 4/5
Effects 5/5
Triggering 5/5
The spell is very easy to import and due to the good config. Trigger it is easy to change anything!
All in all 5/5

 

[Toxic 75]

Oh, lovely, I should've checked this earlier. Well, as moderator, I will remove them :/