Why won't this trigger work?

[Scippi]

Hey guys I've just made a trigger to turn off another trigger once the number of a type of unit has reached 30.

This is the trigger i wanna turn off

• Orc militia spawn
  • Events
    • Unit - A unit enters Attack region 2 <gen>
  • Conditions
    • (Owner of (Triggering unit)) Equal to Player 1 (Red)
  • Actions
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees

This is the trigger i'm going to use to turn the one above off

• Orc turn off
  • Events
  • Conditions
    • (Number of units in (Units of type Orc Militia)) Equal to 30
  • Actions
    • Trigger - Turn off Orc militia spawn <gen>

And i know it's not working because when one of my units enter the region 30 militias are created, then i teleport out, then into the region again and another 30 militias are created, i've also tried greater or equal to for the condition

 

[Maker]

Run "Turn off Orcs" checking conditions after creating the units.

You should also read a tutorial about leaks.

 

[Scippi]

Nope, still not working xD

• Orc militia spawn
  • Events
    • Unit - A unit enters Attack region 2 <gen>
  • Conditions
    • (Owner of (Triggering unit)) Equal to Player 1 (Red)
  • Actions
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Trigger - Run Turn off <gen> (checking conditions)

 

[Pharaoh_]

Your trigger is called "Orc turn off", as far as I can see from the first post, and now you run the "Turn off" one. Is this trigger supposed to be the same?

 

[tjordell]

Try to do this. Cuz i think you need an interval event to this other trigger that turns of the other trigger.

• HelpTrigger
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in (Units of type Footman)) Equal to 30
      • Then - Actions
        • Trigger - Turn off (This trigger)
      • Else - Actions

 

[Scippi]

Oops that's a good point i've changed it to orc turn off now and it's still not working

• Orc militia spawn
  • Events
    • Unit - A unit enters Attack region 2 <gen>
  • Conditions
    • (Owner of (Triggering unit)) Equal to Player 1 (Red)
  • Actions
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Unit - Create 5 Orc Militia for Player 2 (Blue) at (Random point in Attack region 2 <gen>) facing Default building facing degrees
    • Trigger - Run Orc turn off <gen> (checking conditions)

 

[Pharaoh_]

Why do you want to make this check anyway? You indeed create 30 Orc Militia units :S Just turn the trigger off in the beginning of the creation trigger (the Orc militia spawn).

 

[Scippi]

I want to make this check so that the game doesn't make 30 Orc militias everytime an enemy unit enters the region.
Basically, what i want to do is, make 30 militias when there are enemy units in the region, then if those 30 die another 30 will spawn

 

[SlayerII]

Do you mean:
a) when there are 0 militas 30 will psawn.
b) when there are 29 ,1 will spawn. If 2 die at samw time and there are 28, 2 will spawn. So there will always spawn militas till there are 30.

 

[tjordell]

Do you mean:
a) when there are 0 militas 30 will psawn.
b) when there are 29 ,1 will spawn. If 2 die at samw time and there are 28, 2 will spawn. So there will always spawn militas till there are 30.

No i think he mean that when there are 0 militas there will spawn 30 more. and when all of them dies there will spawn another 30 militas.

 

[Pharaoh_]

Well, like I said, turn the trigger of before you begin with the Unit - Create actions (use Trigger - Turn off (This trigger)) and another trigger which goes like this:

• Trigger
• Events
  • Unit - A unit dies
• Conditions
  • ((Triggering unit) is in OrcMilitiaGroup) Equal to True
• Actions
  • If (All conditions are true) then do (Actions) else do (Actions)
    • If - Conditions
      • (Number of units in (OrcMilitiaGroup)) Not Equal to 0
    • Then - Actions
      • Unit Group - Remove (Triggering unit) from OrcMilitiaGroup
    • Actions
      • Trigger - Turn on Orc militia spawn <gen>

 

[Scippi]

@Slayer: That was actually my intention but it seemed a bit impractical is it possible to do that though? I'm not sure which idea is better though xD
@Pharaoh: You're awesome

 

[Scippi]

Doesn't seem to be working Pharaoh

• Orc turn on
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is in (Units of type Orc Militia)) Equal to True
  • Actions
    • If ((Number of units in (Units of type Orc Militia)) Not equal to 0) then do (Unit Group - Remove (Triggering unit) from (Units of type Orc Militia)) else do (Trigger - Turn on Orc militia spawn <gen>)

 

[Pharaoh_]

Try "Less than 1" in the comparison, else you need a wait or a timer of 2.0 seconds to detect the units left, after the death time of the unit, which corresponds to the value of "Decay Time - Flesh (sec)" of the Gameplay Constants.

 

[VestriDeus]

• Event
  • Unit - Unit Enters (Region)
• Conditions
  • (Owner of (Entering Unit)) Equal to (Player 1 (Red))
  • (Number of units in (Units in (OrcMilitiaArea) matching ((Unit type of (Matching Unit)) Equal to (Orc Militia))) Equal to 0
• Actions
  • For Each (Integer A) from 1 to 6, do (actions)
    • Loop - Actions
      • Unit - Create 5 (Orc Militia) for Player 2 (Blue) at (Random Point in (Orc Militia Spawn))

I think this should work better.

 

[Scippi]

Guys i've got another problem, when the militias are spawned, sometimes they're confused as to where to go when there are too many enemy units in the region. please help xD