[JASS] WHY?? (UnitAddAbility problem)

[Almia]

So, I tried creating a sight range system which modifies a sight range of unit using the Scope ability(Sight bonus) with binary method.

I tried adding some ability to a unit (via code) and it seems that it can only add one ability of its own at a time(e.g I add a Sight Bonus with 512 bonus for 10 times, 9 next lines fail)


everybody got a suggestion?

 

[Lender]

a unit can't possess more then one of the same ability
instead create more levels to it and adjust the level of the ability in your system
different levels for different sight ranges

 

[Almia]

That is not efficient actually. If you want a sight range of any size, you should use a binary method.

Well thanks anyway. I just don't get how some bonuses(Bonus systems)manage to do something like applying bonus damage, etc.

 

[Maker]

Well thanks anyway. I just don't get how some bonuses(Bonus systems)manage to do something like applying bonus damage, etc.

Many abilities such as bonus damage are additive. Sight radius is not.

 

[Almia]

Oh okay.thanks for the help guys

 

[Arhowk]

Major In Philosophy

well theres your issue.

Only item abilities are stackable

 

[Xonok]

Only item abilities are stackable

It would be more precise to say that abilities on items(not necessarily item abilities) are separate from abilities on units.
Although, GetUnitAbilityLevel also detects abilities on items. What a strange mess.

 

[Arhowk]

What a strange mess.

whats strange?
when an item is equipped, all abilities are added to hero. when unequipped, all are removed. thats why claw of attac kand shit need tobe stackable

 

[Xonok]

Read the whole line. What's messy is that although the abilities are technically on items(and thus, avoid the limit) they are still picked up by GetUnitAbilityLevel. It is useful though, despite the strangeness.

 

[Almia]

Guys the sight bonus is an item ability

 

[WaterKnight]

The sight range ability is like the life bonus and mana bonus ability, meaning it possesses the same bug:

You can set the first level value to 0, level 2 to x. Add the ability to the unit, set to level 2, remove the ability from the unit. The unit will have an additional sight range of -x.

That bug however is not very stable. Morphing the unit will remove the bonuses/mess it up.

Also sight range is capped at 1800, anyway.

edit: And different sight range abilities do stack.

 

[Almia]

Yep i tried it(worked) but i need to get the best results


[Edit]
It seems that 1800 is not the limit. I tried adding 5 +512 and it worked(via object editor)

 

[Dr Super Good]

It seems that 1800 is not the limit. I tried adding 5 +512 and it worked(via object editor)

Did it work in game? Nothing stops you setting the fields to stupidly large values but if they work is another question.

 

[Tal'Rarity]

well theres your issue.

Only item abilities are stackable

Nuh uh, some can't be stacked. Though technically they can be overwritten to be higher/lower so technically they do stack... Still nuh uh.

Also testing this, will post map shortly/answer.

Edit: Nope the limit is still hardcoded as usual sadly... That is 1800. Sure there's workarounds, but it would have been cool if stacking them was a workaround itself. Yeah they can be stacked however not over 1800.