Why there is still an end-game delay despite I had removed the leaked memory?

[maxor_gan]

• Untitled Trigger 001
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set Group_A = (Units in (Playable map area))
    • Unit Group - Pick every unit in Group_A and do (Actions)
      • Loop - Actions
        • Set Point_A = ((Position of (Picked unit)) offset by 15.00 towards (Facing of (Picked unit)) degrees)
        • Unit - Move (Picked unit) instantly to Point_A
        • Custom script: call RemoveLocation(udg_Point_A)
    • Custom script: call DestroyGroup(udg_Group_A)

I used every 0.01 second coz I want to test the map with the fastest result to be seen...

Yea, i forget to mention that there is only 6 units in the map. It still delay when I quit the game. What is the causes? Is there still memory leaks?

 

[ikillforeyou]

• Untitled Trigger 001
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set Group_A = (Units in (Playable map area))
    • Unit Group - Pick every unit in Group_A and do (Actions)
      • Loop - Actions
        • Set Point_A = (Position of (Picked unit))
        • Set Point_B = (Point_A) offset by 15.00 towards (Facing of (Picked unit)) degrees)
        • Unit - Move (Picked unit) instantly to Point_B
        • Custom script: call RemoveLocation(udg_Point_A)
        • Custom script: call RemoveLocation(udg_Point_B)
    • Custom script: call DestroyGroup(udg_Group_A)

 

[maxor_gan]

Gosh i overlooked it. >.<

BTW if I m using hashtable, and I am attaching some integer, real and boolean to some units periodically, would this causes memory leak too when i remove the unit (handler)? Since real, integer n boolean should be the native data to computers.

 

[defskull]

Also, in the "I want to see result as fast as I can", once every 0.03 seconds is enough
0.01 is TOO laggy, it performs a check 100 per second, compared to 0.03s, it performs check a 33 times per second
0.03 is sufficient for our naked eyes, trust me

As far as I know, Integer/Real doesn't leak

 

[maxor_gan]

Hmm...so there would be no problem of leaking if I am to attach a real or integer to a dummy unit (which are created and destroy periodically) rite?

 

[maxor_gan]

Oh yea...abt the my fastest result doesnt meant for the fastest moving speed or smoothest effects. What I want is for the game to pile up a lot of leaked memory as fast as possible for testing purposes. =D

 

[defskull]

It depends, if the unit is not cleaned up, it WILL leak
Like dummy, you must add its Expiration Timer (usually people set it to 0.50 seconds, just for casting purposes)
Example:

• Unit - Add a 0.50 second Generic expiration timer to (Last created unit)

(Last created unit) will always be referred as your Dummy Unit

 

[maxor_gan]

Yeah...not only I kill them, but I removed them from the game. =)
Anyway...I have another question:

• Untitled Trigger 003
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in GrowingPlants and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Custom value of (Picked unit)) Less than or equal to 100
          • Then - Actions
            • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + 1)
            • Set Real_A = (0.00 + ((Real((Custom value of (Picked unit)))) x ((100.00 / GrowTime) x 0.60)))
            • Animation - Change (Picked unit)'s vertex coloring to (Real_A%, 100.00%, 0.00%) with 0.00% transparency
          • Else - Actions
            • Unit Group - Remove (Picked unit) from GrowingPlants

Would this action created many "unit group" objects which causes leaks, or it is just only 1 "unit group" all the time, which is contained in a pointer variable (Growing Fruit)...

 

[defskull]

You must set a variable of Unit Group type once every 0.05 seconds
And every 0.05 seconds, you must clean the leaks too
Real_A does not leak I think because Integer/Real doesn't leaks as I've told you (or maybe I was wrong)
Example trigger:

• Untitled Trigger 003
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set GrowingPlants = SomethingYouKnowAbout (this is your UnitGroup)
    • Unit Group - Pick every unit in GrowingPlants and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Custom value of (Picked unit)) Less than or equal to 100
          • Then - Actions
            • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + 1)
            • Set Real_A = (0.00 + ((Real((Custom value of (Picked unit)))) x ((100.00 / GrowTime) x 0.60)))
            • Animation - Change (Picked unit)'s vertex coloring to (Real_A%, 100.00%, 0.00%) with 0.00% transparency
          • Else - Actions
            • Unit Group - Remove (Picked unit) from GrowingPlants
    • Custom script: call DestroyGroup(udg_GrowingPlants)

 

[maxor_gan]

Oh yeah...I had just figured it out too...but I m not too sure. Haha. Yeah what you said is excalty correct. =D I get your point. So I have done it this way:

• Untitled Trigger 003
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set TempGroup = GrowingPlants
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Custom value of (Picked unit)) Less than or equal to 100
          • Then - Actions
            • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + 1)
            • Set Real_A = (0.00 + ((Real((Custom value of (Picked unit)))) x ((100.00 / GrowTime) x 0.60)))
            • Animation - Change (Picked unit)'s vertex coloring to (Real_A%, 100.00%, 0.00%) with 0.00% transparency
          • Else - Actions
            • Unit Group - Remove (Picked unit) from GrowingPlants
    • Custom script: call DestroyGroup(udg_TempGroup)

Gonna try if it works. Haha. Any probs I would post again. =D

 

[defskull]

I also cannot guarantee for sure my way will work
But that looks like it, you didn't clean your leaks, that's the problem

 

[maxor_gan]

But it deosnt work...the trigger is bugged. My plant wont grow at all. I guest it had also deleted the unit group in the pointer variable all together. Now I really do not know how to solve this...=(

 

[maxor_gan]

The function "DestroyGroup()" not only remove the the TempGroup, but also the GrowingPlants all together...

 

[defskull]

The problem is because the Unit Group serves its time until your plants grows fully
So it must be re-use and re-use and re-use
Destroying it, it will delete its data and all..
Hmm....

 

[maxor_gan]

so there seems to be no way to solve this problem rite...=\

 

[maxor_gan]

• Untitled Trigger 003
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Add all units of GrowingPlants to TempGroup
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Custom value of (Picked unit)) Less than or equal to 100
          • Then - Actions
            • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + 1)
            • Set Real_A = (0.00 + ((Real((Custom value of (Picked unit)))) x ((100.00 / GrowTime) x 0.60)))
            • Animation - Change (Picked unit)'s vertex coloring to (Real_A%, 100.00%, 0.00%) with 0.00% transparency
          • Else - Actions
            • Unit Group - Remove (Picked unit) from GrowingPlants
    • Custom script: call DestroyGroup(udg_TempGroup)

Hmmm...This should work i think? gonna test it again. =/

 

[defskull]

There is, so judging by your trigger...
You want it, to every 0.05 seconds, your plant will change its size, right ?

 

[maxor_gan]

Yeah, I want them to groe in time. But in facts is every 2 seconds. But I wanna test its leaks, so i changed it to 0.05. Haha.

Anyway my new method does not work too. When I destroy the TempGroup, it destroyed the GrowingPlants too...I wonder why. Even I use "Add all units in group to group", but still bugged. =\

 

[GIANT_CRAB]

Nono.... defskull... ur doing it wrong....
Serious.

Edit: brb, making the trigger script 4 u.

 

[defskull]

Okay, bot.
And I noticed too that I'm wrong in this matter, because I didn't read the whole thing properly and didn't quite understand...
It seems his Unit Group must be used on and on until the Conditions met, at that particular time, destroy your unit group

 

[Maker]

To me it seems that GIANT_CRAB is correct. The trigger in post 8 looks ok. I'm guessing you're adding units into the group in some other trigger.

 

[maxor_gan]

Hmm....so the trigger in post 8 doesn't create leaks, you mean?

 

[Maker]

That's correct.

 

[GIANT_CRAB]

I kill for you's trigger (first) is correct, however, if theres the call DestroyGroup there, it will make the group be destroyed, and u have to create the group again.
We should only destroy temporary groups. (used once only)
example: pick every unit in playable map ( it leaks )

• Actions
  • Set Variable - TempGroup1 = Unit in playable map
  • Unit Group - pick every unit in TempGroup1
    • Unit - Kill picked unit.
  • Custom script: call DestroyGroup(udg_TempGroup1)

Note: This is wut u do to a temporary group.
endif.
-That is how u do eeetttttt

Edit: Wait a min.... lol, which one do u want???
You want to make a permanent group or a temp group???

 

[defskull]

So it seems I've learned my lesson lol...
He wants to re-use and use again and again for that Unit Group, therefore it should not be destroyed in the first place