Why does this trigger destroy FPS

[Gumberbunbder]

Hello, is there a way I can make a trigger with the same function as the one below that doesn't take away 15-20 fps? I don't know too much about triggers and really nothing about jass. Should i change it so the floating text moves to a point instead of a unit and make TempPoint variable which I can later remove with a custom script? Thank you for your time

Spoiler

• Tradesman Text Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Set VariableSet tempUnitGroup = (Units in (Playable map area))
    • Unit Group - Pick every unit in tempUnitGroup and do (Actions)
      • Loop - Actions
        • Set VariableSet PickedUnit = (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of PickedUnit) Equal to Tradesman
                • (Unit-type of PickedUnit) Equal to Native Tradesman
          • Then - Actions
            • Floating Text - Change the position of (Load TradesmanFloatingTextNumber of (Key (Picked unit).) in TradesmanHashtable) to PickedUnit with Z offset 0.00.
          • Else - Actions
    • Custom script: call DestroyGroup (udg_tempUnitGroup)

EDIT: OK! so I did away with the tempUnitGroup and instead added the units when they were trained to a preestablished unit group. So now it looks like this and it performs a lot better. Guess checking every units in the playable map area is something that should be avoided lol. If anyone knows any ways I can optimize further, please let me know!

Spoiler

• Tradesman Text Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in TradesmanUnitGroup and do (Actions)
      • Loop - Actions
        • Set VariableSet PickedUnit = (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of PickedUnit) Equal to European Tradesman
                • (Unit-type of PickedUnit) Equal to Native Tradesman
          • Then - Actions
            • Floating Text - Change the position of (Load TradesmanFloatingTextNumber of (Key (Picked unit).) in TradesmanHashtable) to PickedUnit with Z offset 0.00.
          • Else - Actions

 

[Biglover]

What you are doing is putting every unit in the entire map in a group every 0.03 seconds. Then you iterate through every unit in said group, all units on the map for your specific unit.
What you want to do is make your group matching conditions.

• Set VariableSet tempUnitGroup = (Units in (Playable map area) matching (((Unit-type of (Matching unit)) Equal to Footman) or ((Unit-type of (Matching unit)) Equal to Rifleman)))

This way you already have the units you wanna modify in the group. The more you can narrow it down the less its gonna cost you in computing power.

In the end it should maybe look something like this?

• Tradesman Text Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Set VariableSet tempUnitGroup = (Units in (Playable map area) matching (((Unit-type of (Matching unit)) Equal to Footman) or ((Unit-type of (Matching unit)) Equal to Rifleman)))
    • Unit Group - Pick every unit in tempUnitGroup and do (Actions)
      • Loop - Actions
        • Floating Text - Change the position of (Load TradesmanFloatingTextNumber of (Key (Picked unit).) in TradesmanHashtable) to PickedUnit with Z offset 0.00.
    • Custom script: call DestroyGroup (udg_tempUnitGroup)

No need to set a variable to your picked unit, use the picked unit option

 

[Pyrogasm]

You can attach floating text to a unit so it automatically moves with the unit instead of having to do this manually.

uess checking every units in the playable map area is something that should be avoided lol.

It should absolutely never be done with a frequency anywhere close to 0.03; in a large map with lots of units I would recommend not doing it at all.

 

[Pyrogasm]

@Biglover Doing it that way is literally exactly the same. It still filters through all the units on the map to compare their unit type each time the trigger runs.

The more you can narrow it down the less its gonna cost you in computing power

In fact it's the exact opposite because the filter still has to look at every unit. Also it evaluates each condition for each unit until it finds one for that unit that isn't true (then skips it and moves on) so the more conditions you put the more checks it has to make.

 

[Gumberbunbder]

You can attach floating text to a unit so it automatically moves with the unit instead of having to do this manually.

thank you for your help. I can’t find the function to have the text attached. Could you show me which function you are talking about?

BTW! 'm 4 th sve th vwls mvmnt 2!

 

[Pyrogasm]

It's called Floating Text - Create Floating Text Above Unit:

• Floating Text - Create floating text that reads <STRING> above <UNIT> with Z offset 0.00, using font size 10.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency

 

[Gumberbunbder]

I’m using that but it doesn’t follow the unit around unless I add the looping trigger to continually change its position. I’ll check to make 100% sure though

 

[Pyrogasm]

Maybe Blizzard broke it in Reforged. I can't remember a time that function didn't move it with the unit.

 

[Gumberbunbder]

Yeah it doesn’t seem to be working. Could be that they broke it. Either way thanks for the help

 

[Pyrogasm]

Wild. I guess I was completely wrong and that function never did that, so it's not broken. I must just remember some library I used that made it automatic.

 

[Biglover]

@Biglover Doing it that way is literally exactly the same. It still filters through all the units on the map to compare their unit type each time the trigger runs.

In fact it's the exact opposite because the filter still has to look at every unit. Also it evaluates each condition for each unit until it finds one for that unit that isn't true (then skips it and moves on) so the more conditions you put the more checks it has to make.

Yea, youre right when I think abou it