[vJASS] Which indexing method is better?

[Geshishouhu]

Hi guys, please see the following example:

//Are there any practical difference between these two allocation and deallocation methods? 
//Which one is better?

//First:
globals
    integer array a
    integer index = 0
endglobals

static method Loop takes nothing returns nothing
    local thistype this
    local integer i = 0          //<--------------
    loop
        exitwhen i > index
        set this = a[i]
        ......
        if RemainingTime <= 0 then
            set index = index - 1      //<--------------
            set a[i] = a[index]
            set i = i - 1
            ....
        else
            ....
        endif
        ......
        set i = i + 1
    endloop
endmethod

static method Run takes nothing returns nothing
    local thistype this = this.allocate
    ....
    set a[index] = this
    set index = index + 1       //<--------------
    if index == 1 then
        call TimerStart(...., function thistype.Loop)
    endif
    ....
endmethod


//Second:

globals
    integer array a
    integer index = 0
endglobals

static method Loop takes nothing returns nothing
    local thistype this
    local integer i = 1  // <-------------
    loop
        exitwhen i > index
        set this = a[i]
        ......
        if RemainingTime <= 0 then
            set a[i] = a[index]
            set index = index - 1   //<--------------
            set i = i - 1
            ....
        else
            ....
        endif
        ......
        set i = i + 1
    endloop
endmethod

static method Run takes nothing returns nothing
    local thistype this = this.allocate
    ....
    set index = index + 1    //<--------------
    set a[index] = this
    if index == 1 then
        call TimerStart(...., function thistype.Loop)
    endif
    ....
endmethod

Which one is better? Thanks.

 

[edo494]

I am on phone so cant scroll your jass code, but "call a = ..." is not evsn valid, it should have been set

 

[Geshishouhu]

I am on phone so cant scroll your jass code, but "call a = ..." is not evsn valid, it should have been set

Typo, fixed.

 

[Xonok]

I'm having trouble reading this because of the unnecessary struct syntax, but the second way should work better judging by the initialization.
Also, you should never have to decrement the loop counter in JASS, because you can just choose to increase it at the appropriate times.

 

[deathismyfriend]

The one starts at 0 and the other starts at 1. The one that starts at 0 is best since it allows you to use all of the indexes. But it really doesn't matter as any loop will always hit op-limit before it hits the max index for arrays. (unless a wait or multiple threads are run doing the loop)

 

[Geshishouhu]

The one starts at 0 and the other starts at 1. The one that starts at 0 is best since it allows you to use all of the indexes. But it really doesn't matter as any loop will always hit op-limit before it hits the max index for arrays. (unless a wait or multiple threads are run doing the loop)

Thanks. +rep