Water check

[Hell13east]

Is there a way to check if a unit is in water except for terraintype check and terrain levelcheck?

If there is a way in Jass, please post as custom scripts and explain it a bit, because im not using jass...

 

[Anachron]

There is no way to get it 100%, not even in vJass.

 

[Hell13east]

Hmmm... Got any suggestion of what i could do then?
Is it possible to check the height of a point without checking terrain level?

 

[Anachron]

But that doesn't have anything to do with water, has it? Just because its lower as the normal terrain doesn't mean it has to include water.

I'll check if I can get anything to work somehow, however, I really doubt its makeable.

 

[Hell13east]

But that doesn't have anything to do with water, has it? Just because its lower as the normal terrain doesn't mean it has to include water.

I'll check if I can get anything to work somehow, however, I really doubt its makeable.

Since water has a specific level that is lower then ground if im not using wc3 clifs and no water doodads i think it works?

 

[Anachron]

So you have a flat terrain and if terrain is lower then the normal terrain it has to be water?
Then it should work.

However, it wouldn't work for others though.

 

[Hell13east]

So you have a flat terrain and if terrain is lower then the normal terrain it has to be water?
Then it should work.

However, it wouldn't work for others though.

True, or well. It dont have to be flat (But allways higher then the sealevel)

Do you know how to check if a point is lower then a specific value?

 

[Anachron]

    globals
        constant location zLoc      = Location(0, 0)
        constant real     TERRAIN_HEIGHT    = 7 * 64
    endglobals
    
    function GetLocZ takes real x, real y returns real
        call MoveLocation(zLoc, x, y)
        return GetLocationZ(zLoc)
    endfunction

   function IsLocInWater takes location loc returns boolean
       return GetLocZ(GetLocationX(loc), GetLocationY(loc)) < TERRAIN_HEIGHT
   endfunction

Change the TERRAIN_HEIGHT to the value that is your minimum terrain height of non-water.
Please note that this takes into account the cliffheight you have.

 

[Hell13east]

Thx for that, but im quite sucky at Jass so, how to implement it in a good way ? ( + rep for help anyway )

 

[Anachron]

CnP the edited script into the map header (Trigger Editor, the first entry with the map name, double click on it and paste it to the right field)

You can use this

• CustomScript: if IsLocInWater(location!!!!) then
• // Your gui stuff here
• CustomScript: endif

To run actions only if the loc is in water.

 

[Hell13east]

ok, thank you ( gave rep in last message )

 

[Anachron]

I modified my posts, please note.

 

[Hell13east]

Im getting 70 errors from the script, I have to use JNGP for it to work or something?

 

[Anachron]

Hmm you shouldn't, but if it really doesn't work use JNGP.

 

[TriggerHappy]

local real x = GetUnitX(unit)
local real y = GetUnitY(unit)
if IsTerrainPathable(x,y,PATHING_TYPE_WALKABILITY) then
    call BJDebugMsg("unit is in water")
end

This code seems to work for me. Not sure how accurate it is, but it's worked for me (and never conflicted).
You also said no terraintype checks, this is a pathing check (to clarify).

 

[Anachron]

TriggerHappy maybe read his question again.
He does not understand jass.
How can he use a JASS-alone code then?

I posted a little script and explained how to implement, you posted a full JASS2 version of it.

And btw, your code does not work probably when you have buildings/cliffs/destructables on the checked loc.

 

[TriggerHappy]

He does not understand jass.

Yet he requested jass scripts.
I'm fairly sure he can replace (unit) with (udg_unitvar).

I posted a little script and explained how to implement, you posted a full JASS2 version of it.

Good job, I posted an alternative method which he could implement on his own time.
I didn't have the time the thoroughly explain my 5 lines of code.

And... don't say Jass2. I doesn't make you look any more intelligent or sophisticated.

And btw, your code does not work probably when you have buildings/cliffs/destructables on the checked loc.

Did you mean properly, or probably?
Anyways, I never said it was 100% accurate.

I actually stated that it wasn't accurate to my knowledge.

Not sure how accurate it is, but it's worked for me (and never conflicted).