[JASS] /[vJass] Need help on something!

[Dynasti]

Need help on something!

Ok im working on my new spells for my new spellpack, but i got a prob here.

The missile changes height from one unit to another, but it does not change it's height on the way back.

Link to code and to map download: The Hive Workshop - A Warcraft III Modding Site

Please if you find something that could be done to fix this Height problem then please post.

Regards, Dynasti

PS: The spell is not completely done, it needs some flawing and documentation but i think it is readable

Explaination

        unit u // Unit User ( The Caster )
        unit t // Unit Target ( The target that the missile will follow )
        unit m // Unit Missile
        group g=CreateGroup() // Group used for not bouncing on the same unit twice
        player p // Player p
        integer l // Integer Level
        
        real z // Real Z, keeps track of the Height (Does not go lower than the missiles height )
        real s=0 // Real Stolen, the amount of life the missile has stolen
        integer c=0 // Integer Count, used to keep track on how many bounces the missile has done
        integer mc // Integer Max Count used to keep track on the max bounces
        effect e // Effect used to set the look on the missile
        
        boolean ToPlayer=false // If set to true when the ball reaches it's target then the ball's motion will end
            
        static integer array Index // An integer array that is used for the indexing system
        static integer Total=0 // An integer wich keeps track of how many missiles there is in use
        static timer Tim=CreateTimer() // Timer used in the interval
        static real nX=0 // A Temp real used for getting the missile's X
        static real nY=0 // A Temp real used for getting the missile's Y
        static real nX2=0 // A Temp real used for getting the target's X
        static real nY2=0 // A Temp real used for getting the target's Y
        static real nA=0 // A Temp real used for getting the angle
        static real nH=0 // A Temp real used for getting the height

 

[RolePlaynGamer]

I'll look at it. =P

 

[Dynasti]

I'll look at it. =P

yay ^^

 

[RolePlaynGamer]

Oh my, 300 lines.
Damn, this will take some time. D=

 

[Dynasti]

Oh my, 300 lines.
Damn, this will take some time. D=

spell isn't a kindergarden spell xD

 

[RolePlaynGamer]

Yeah, that sucks.

BTW, next time give your variables other names than "u" and "t", that would make things much easier. =]

 

[Dynasti]

Yeah, that sucks.

grow up then.

It is fun

BTW, next time give your variables other names than "u" and "t", that would make things much easier. =]

k

Il explain

Back to top

 

[RolePlaynGamer]

Thanks, that helped. =]

 

[Dynasti]

Thanks, that helped. =]

good

Edit:

Ok i have found out that the

 if tmpR != dat.z

does not work, so i removed it.

Another thing is that it does not work on the way back for some reason -_-

 

[RolePlaynGamer]

good

Edit:

Ok i have found out that the

 if tmpR != dat.z

does not work, so i removed it.

Another thing is that it does not work on the way back for some reason -_-

heh, yeah, I also just discovered that the NewHeight method is called everytime the missile changes target. =P
However, I still don't know exactly why it doesn't work with the caster but with all the other creeps.

Edit:

Bug found! I think... Will check now. ;P

 

[Dynasti]

heh, yeah, I also just discovered that the NewHeight method is called everytime the missile changes target. =P
However, I still don't know exactly why it doesn't work with the caster but with all the other creeps.

Edit:

Bug found! I think... Will check now. ;P

^^ I know the New Height is runned evry time. It changes the height with a calculation between points. Somehow the points arent changed :S

Edit: Updating the map, fixed some minior things

 

[Deaod]

call SetUnitFlyHeight(.m, h + M_HEIGHT, (h-GetUnitFlyHeight(.m)+(2*M_HEIGHT))/((SquareRoot((.nX2-.nX)*(.nX2-.nX)+(.nY2-.nY)*(.nY2-.nY))*M_TICK)/M_SPEED))

that should be mathematically correct.

oh, maybe you should add set tmpI=0 somewhere before you switch structs in your loop. Forget about that.

Do you filter out Dat.m as a valid new target?

 

[Dynasti]

call SetUnitFlyHeight(.m, h + M_HEIGHT, (h-GetUnitFlyHeight(.m)+(2*M_HEIGHT))/((SquareRoot((.nX2-.nX)*(.nX2-.nX)+(.nY2-.nY)*(.nY2-.nY))*M_TICK)/M_SPEED))

that should be mathematically correct.

oh, maybe you should add set tmpI=0 somewhere before you switch structs in your loop.

i do, if tmpI is greater than 0 then
[...]
set tmpI = 0

 

[RolePlaynGamer]

I'ma watch a movie, will return to this spell later on.

(headache -.-")

 

[Dynasti]

I'ma watch a movie, will return to this spell later on.

(headache -.-")

to bad

 

[Deaod]

Do you filter out dat.m as a valid new target?

 

[Dynasti]

Do you filter out dat.m as a valid new target?

dat.m is the missile. The filter filters out enemy non structure enemies

If there is no units in range or it has bounced the max amount of times then the target will be changed to the caster and a boolean called ToPlayer will be set to true. On impact it checks if it is false then it loop if it is true then the spell ends.

 

[RolePlaynGamer]

I think I got it.
When the caster is set as the target, do you update the target coordinates to the values of the caster instead of the previous target?
I don't have the code here, so I can't check. =P

 

[Dynasti]

I think I got it.
When the caster is set as the target, do you update the target coordinates to the values of the caster instead of the previous target?
I don't have the code here, so I can't check. =P

k checking

Edit: Yes i do

        method BackToPlayer takes nothing returns nothing
            set .t = .u
            set .ToPlayer = true
            set .nX2=GetUnitX(.t)
            set .nY2=GetUnitY(.t)
        endmethod

 

[Deaod]

yes he does.
EDIT: okay, dat.m should be a valid target, if i am not mistaken. Just add it to .g when you spawn the missile. Tell me, if that fixed your problem (probably not, but w/e).

 

[RolePlaynGamer]

yes he does.

Oh, damn. >.<

Does handles inside structs have to be nuliffied? =0

 

[Dynasti]

yes he does.
EDIT: okay, dat.m should be a valid target, if i am not mistaken. Just add it to .g when you spawn the missile. Tell me, if that fixed your problem (probably not, but w/e).

k testing, but dont think it will make any difference. Because the filter filters out enemies not in the group

Edit: Not working

Dont think it has something to do with the filter, more in the function.. but what?

 

[RolePlaynGamer]

BTW, you should probably replace the KillUnit call to UnitDamageTarget, because some people might use these spells and wonder why units killed by it doesn't update their player kills on the multiborad.=s

 

[Dynasti]

BTW, you should probably replace the KillUnit call to UnitDamageTarget, because some people might use these spells and wonder why units killed by it doesn't update their player kills on the multiborad.=s

Ah, k will fix

Edit: Done

 

[Eleandor]

Oh, damn. >.<

Does handles inside structs have to be nuliffied? =0

Nope, structs are simulated by global variables, and global variables don't have to be nulled.

 

[RolePlaynGamer]

Nope, structs are simulated by global variables, and global variables don't have to be nulled.

I thought so, I got a little confused when I saw that Dynasti nulled his.

 

[Dynasti]

I thought so, I got a little confused when I saw that Dynasti nulled his.

no i dont null structs

 

[Deaod]

                        set dat.u=null
                        set dat.t=null
                        set dat.m=null
                        set dat.e=null

dont get me wrong, i think its fine and good to null struct members.

 

[Dynasti]

                        set dat.u=null
                        set dat.t=null
                        set dat.m=null
                        set dat.e=null

But lets not concern about this. Lets go to the real prob

 

[Dr Super Good]

It is good to null struct handle components to allow eariler handle index recycling. They technically do not leak however but they may use more memory than usual if you do not so it is still recommendable to null them.

struct integer, string, real and boolean components do not need to be set to anything as they do not leak (stings do but that is a WC3 problem).

 

[Dynasti]

Thx DSG