UTS - Unit on Tower System v1.3 GUI/MUI

[Daffa]

I think these are two separate systems?

 

[Sindobato]

yeah xD ok I edited the description sorry for the confusion

 

[Cheshire]

yeah xD ok I edited the description sorry for the confusion

seems like it would make more sense as two separate submissions

 

[Wrda]

Your Tower Cast trigger isn't acceptable, if a user wants to use way more towers, he will have to touch that trigger despite not being the configurable trigger. Use a loop to figure out which tower type entered the game/finished upgrade, and only then you create a new instance (the Tower_Index = Tower_Index + 1 part). Dummy flying height value should be an array variable configured in Tower INI trigger, where the indexes correspond to the tower type. Tower_Mui variable isn't needed at all, use Tower_Index for it instead. Tower_Dummy_FlyingHeight doesn't need to be an array.
In Tower Loop, once again, remove those "or multiple" conditions and check the unit type with a loop, so essentially you'd have 2 loops. You can use

• Custom script: exitwhen true

to exit the loop early (do it on the outmost loop, not the inner one! Also use another integer variable such as Tower_Loop2).

Same thing for the Tower Death trigger. In addition, the deindexing is failing, the unit with the max index won't be looped over. See Visualize: Dynamic Indexing to understand what I'm talking about.
It would be better if you had a prefix such as UTS_Mui than Tower_Mui (Unit Tower System - can be another name), it's a quite common word and possible to clash with other eventual spells/system the user has. I don't see the usefulness of having a debug part. Seems like only a creator of the system would need.

This system could be expanded further one day, such as removing these "finished upgrade/unit enters the map" and have a trigger to register the units the user want to attach to the tower by having variables acting as parameters. Then users could have units go "inside" towers, and able to go out.
Right now it has some issues, and is somewhat simple.


PS: In the example the warlock tower has rock spires model.

 

[Wrda]

• UTS Attack
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • For each (Integer UTS_Loop) from 1 to UTS_Mui, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • UTS_Index Equal to 0
          • Then - Actions
            • Custom script: exitwhen true
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Attacking unit) Equal to UTS_Caster[UTS_Loop]
          • Then - Actions
            • Set VariableSet UTS_Victim[UTS_Loop] = (Triggering unit)
            • Unit - Make UTS_Dummy[UTS_Loop] face UTS_Victim[UTS_Loop] over 0.10 seconds
            • Animation - Play UTS_Dummy[UTS_Loop]'s attack animation
            • Animation - Queue UTS_Dummy[UTS_Loop]'s stand animation
          • Else - Actions

When UTS_Index is 0, the trigger gets disabled, so you no longer need to check that and "exitwhen true". I said that because before you needed to check the valid tower types and then the unit in question.

edit2: I removed UTS_Mui and used UTS_Index, but reverted back to using UTS_MUI because the deindexing failed when I used UTS_Index. Im sure I did something wrong lol

Yes, because then the max index was decreased by 1, while there's still the unit at max index + 1 that you lost reference to
That's why on the deindexing one has to "swap" the current index with the max index, before lowering it.
Besides, the death trigger is called again when Unit - Kill UTS_Dummy[UTS_Loop2] happens. It stops execution at that point, and then fires the trigger, finishing running it, and then returning to the previous point and continue. So UTS_Loop2 gets overwritten and screws up. Need to turn off the trigger before killing the dummy, and then turn it on.
So it should be like this:

• UTS Death
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • For each (Integer UTS_Loop2) from 1 to UTS_Index, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • UTS_Caster[UTS_Loop2] Equal to (Triggering unit)
          • Then - Actions
            • Animation - Change UTS_Dummy[UTS_Loop2] flying height to 0.00 at 0.00
            • Trigger - Turn off (This trigger)
            • Unit - Kill UTS_Dummy[UTS_Loop2]
            • Trigger - Turn on (This trigger)
            • Set VariableSet UTS_Caster[UTS_Loop2] = UTS_Caster[UTS_Index]
            • Set VariableSet UTS_Dummy[UTS_Loop2] = UTS_Dummy[UTS_Index]
            • Set VariableSet UTS_Index = (UTS_Index - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • UTS_Index Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
                • Trigger - Turn off UTS Attack <gen>
              • Else - Actions
            • Custom script: exitwhen true
          • Else - Actions

Now you can replace UTS_Mui with UTS_Index everywhere
UTS_Caster_Loc doesn't need to be an array at all, since you're not using on multiple triggers, same with UTS_Victim, can just use the triggering unit directly in this last case. Seems to me that you no longer need UTS_Loop2 too, only reason to use that is if there were nested loops (UTS_Loop2 loop inside a UTS_Loop loop).

 

[Sindobato]

thats it thank you and the suggestion that unit should be able to get in the tower is a good idea. I will try implementing that soon

edit: implemented the idea it turned out nicely I think

edit2: I accidentally removed my previous post LOL I just wanted to delete the map file

 

[Wrda]

Your UTS Start trigger after the description is outdated (in the map it's totally fine).
UTS_Caster_Loc doesn't need to be an array, but it doesn't hurt anything so that's fine.

It's a modest system, with potential to be expanded. Can take inspiration from AttachObject v2.05

Approved