• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

Update: How to make this better>?

Status
Not open for further replies.
Level 4
Joined
May 22, 2011
Messages
68
  • Duel End
    • Events
      • Time - Every 5.00 seconds of game time
    • Conditions
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Number of units in HAmode_OnlyInDuelTeam2) Equal to 0
        • Then - Actions
          • Unit - Pause all units
          • Game - Display to (All players) for 4.00 seconds the text: The |cFF3AAB86Outla...
          • Wait 2.00 seconds
          • Unit Group - Pick every unit in HAmode_Duel_UnitTeam1 and do (Actions)
            • Loop - Actions
              • Unit - Move (Picked unit) instantly to HAmode_Duel_Point_Leak[3]
          • Unit Group - Pick every unit in HAmode_Duel_UnitTeam2 and do (Actions)
            • Loop - Actions
              • Unit - Move (Picked unit) instantly to HAmode_Duel_Point_Leak[4]
          • Custom script: call RemoveLocation(udg_HAmode_Duel_Point_Leak[3])
          • Custom script: call RemoveLocation(udg_HAmode_Duel_Point_Leak[4])
          • -------- countdown timer can be changed --------
          • Countdown Timer - Start HAmode_Duel_Timer as a One-shot timer that will expire in 10.00 seconds
          • Unit - Unpause all units
          • Trigger - Turn on CheckScores <gen>
          • Trigger - Turn off (This trigger)
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Number of units in HAmode_OnlyInDuelTeam1) Equal to 0
        • Then - Actions
          • Unit - Pause all units
          • Game - Display to (All players) for 4.00 seconds the text: The |cFF3AAB86Outla...
          • Wait 2.00 seconds
          • Unit Group - Pick every unit in HAmode_Duel_UnitTeam2 and do (Actions)
            • Loop - Actions
              • Unit - Move (Picked unit) instantly to HAmode_Duel_Point_Leak[4]
          • Unit Group - Pick every unit in HAmode_Duel_UnitTeam1 and do (Actions)
            • Loop - Actions
              • Unit - Move (Picked unit) instantly to HAmode_Duel_Point_Leak[3]
          • Custom script: call RemoveLocation(udg_HAmode_Duel_Point_Leak[3])
          • Custom script: call RemoveLocation(udg_HAmode_Duel_Point_Leak[4])
          • -------- countdown timer can be changed --------
          • Countdown Timer - Start HAmode_Duel_Timer as a One-shot timer that will expire in 10.00 seconds
          • Unit - Unpause all units
          • Trigger - Turn on CheckScores <gen>
          • Trigger - Turn off (This trigger)
        • Else - Actions
 
Level 28
Joined
Jan 26, 2007
Messages
4,789
Instead of running a timer, use "Unit - a unit dies" as the event (And perhaps as condition "Unit is a hero equal to true").
Move the entire second ITE (If-Then-Else) inside the else-section of the first ITE

As you probably noticed, you copy the same actions a lot.
This could be solved by putting "Skip remaining actions" in the else-section of the second ITE.
When this is done, you can just move down everything below the "wait" so it is outside the ITEs.

I've edited your trigger (without the WE though, so you may have to fill in anything that isn't completely correct)

  • Duel End
    • Events
      • Unit - a unit dies
    • Conditions
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Number of units in HAmode_OnlyInDuelTeam2) Equal to 0
        • Then - Actions
          • Unit - Pause all units
          • Game - Display to (All players) for 4.00 seconds the text: The |cFF3AAB86Outla...
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • (Number of units in HAmode_OnlyInDuelTeam1) Equal to 0
            • Then - Actions
              • Unit - Pause all units
              • Game - Display to (All players) for 4.00 seconds the text: The |cFF3AAB86Outla...
            • Else - Actions
              • Skip remaining actions
      • Wait 2.00 seconds
      • Unit Group - Pick every unit in HAmode_Duel_UnitTeam1 and do (Actions)
        • Loop - Actions
          • Unit - Move (Picked unit) instantly to HAmode_Duel_Point_Leak[3]
      • Unit Group - Pick every unit in HAmode_Duel_UnitTeam2 and do (Actions)
        • Loop - Actions
          • Unit - Move (Picked unit) instantly to HAmode_Duel_Point_Leak[4]
      • Custom script: call RemoveLocation(udg_HAmode_Duel_Point_Leak[3])
      • Custom script: call RemoveLocation(udg_HAmode_Duel_Point_Leak[4])
      • -------- countdown timer can be changed --------
      • Countdown Timer - Start HAmode_Duel_Timer as a One-shot timer that will expire in 10.00 seconds
      • Unit - Unpause all units
      • Trigger - Turn on CheckScores <gen>
      • Trigger - Turn off (This trigger)
 
Status
Not open for further replies.
Top