[Trigger] Unknown Trigger Problem

[Kanadaj]

Hey! I use this trigger to move the zombies on my map, but they doesn't react Oo

• Zombie Move
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Set TempGroup = (Units in (Playable map area) matching (((Matching player) controller) Equal to User))
    • Unit Group - Pick every unit in (Units owned by Player 11 (Dark Green)) and do (Actions)
      • Loop - Actions
        • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) - 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Custom value of (Picked unit)) Less than or equal to 1
            • Or - Any (Conditions) are true
              • Conditions
                • (Current order of (Picked unit)) Equal to (Order(stop))
                • (Current order of (Picked unit)) Equal to (Order(<Empty String>))
          • Then - Actions
            • Set TempPos = (Position of (Random unit from TempGroup))
            • Unit - Order (Picked unit) to Attack-Move To TempPos
          • Else - Actions
    • Custom script: call DestroyGroup( udg_TempGroup )

 

[Maker]

• Set Temp_Group_1 = (Units in (Playable map area) matching (((Owner of (Matching unit)) controller) Equal to User))

 

[Kanadaj]

But why is that better? Oo

 

[Maker]

Because it works?

 

[Kanadaj]

Not really...

 

[idodik]

Maker is right, you need 2 variables:

• Set tempgroup = (Units in Playable Map Area matching (Owner of (Matching Unit) is a human player) equal to True
• Set tempgroup2 = Units owned by Player 11

Make sure you use those variables wherever you're supposed to, and you'd better clear the point leak (the target point of the order issued to the units).
And what's with the custom value thing? Custom values start from 0 anyway so all zombies with unmodified custom values are going to be ordered to attack!

 

[Pharaoh_]

kanadaj, notice the difference. You pick UNITS, right? So, the "matching" condition should not be "Matching Player", because that would refer to player. You need (Owner of (Matching unit)), because you simply match units, not players. Matching Player would go to Player Group picks.

 

[Kanadaj]

GOD... I fell dumb Oo At all I got my trigger right now (custom value was made because a player suggested to use them to avoid zombies wandering pointlessly between 2 player, it should incrase to 10 when a zombie attacks, but nevermind, it works fine without it

At all I'll need some1 for my project, I'm a bit noob at making everything leakless (and a bit lazy) so I want to ask some1 to check every trigger I try to avoid the most leaks, but you see, I'm not very used to Jass or vJass, so I only use GUI (and I try to make it MUI if I can) but sometimes I miss some functions (and a quick question: specific unit event why can't use unit variables? XD)

 

[Pharaoh_]

It's because Blizzard is so damn sexy
Well, you need to use this instead:

• Trigger - Add to Trigger 2 <gen> the event (Unit - Unit1 dies)

Unit1 is your unit variable and Trigger 2 is the trigger you want the actions for that Unit1 performed.
Tell me though, why would you need a specific unit event, when you have a variable?
You could just do this:

• (Triggering unit) Equal to (Unit1)

which is a Unit Comparison.

 

[Kanadaj]

But you can't use damage source with any other way xD

 

[Pharaoh_]

• Trigger1
• Events
  • Map Initialization
• Conditions
• Actions
  • Custom script: set bj_wantDestroyGroup = true
  • Unit Group - Pick every unit in (Units in (Playable Map Area)) and do (Actions)
    • Loop - Actions
      • Trigger - Add to Trigger 3 <gen> the event (Unit - (Picked unit) takes damage)

• Trigger2
• Events
  • Unit - A unit enters (Playable Map Area)
• Conditions
• Actions
  • Trigger - Add to Trigger3 <gen> the event (Unit - (Triggering unit) takes damage)

• Trigger3
• Events
• Conditions
  • (Triggering unit) Equal to Unit1
• Actions
  • //Actions here

 

[Kanadaj]

Thanks And 1 more question: how can I make a building with mana shield spell (yeah I made it AoE) to apply buff on buildings around it? Oo It didn't even apply buff on itself, so I can't use the condition "Unit has Buff"...

 

[Pharaoh_]

You need to fake-trigger it.
You need a Trueshot Aura-type ability, which you will change Targets allowed to nothing but "Buildings". Then, give it the icon and the model of the Mana Shield effect.

 

[Kanadaj]

Oh... I tryed to make an aura from trueshot aura but didn't work properly xD

 

[Pharaoh_]

Set Data - Ranged Bonus to false.