[vJASS] UnitStripHeroLevel is bugged, anyone know fixes?

[Nestharus]

struct tester extends array
    private static unit u
    private static unit u2
    private static method ts takes nothing returns nothing
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,R2S(GetWidgetLife(u))+"=="+R2S(GetWidgetLife(u2)))
    endmethod
    private static method r takes nothing returns boolean
        call ReviveHero(u,GetWidgetX(u),GetWidgetY(u),false)
        call SetWidgetLife(u,GetUnitState(u,UNIT_STATE_MAX_LIFE))
        return false
    endmethod
    private static method onInit takes nothing returns nothing
        local trigger t = CreateTrigger()
        local integer l=1000
        set u = CreateUnit(Player(0), 'Hpal', GetStartLocationX(0), GetStartLocationY(0), 0)
        set u2 = CreateUnit(Player(0), 'Hpal', GetStartLocationX(0)+128, GetStartLocationY(0), 0)
        call TriggerRegisterUnitEvent(t,u,EVENT_UNIT_DEATH)
        call TriggerAddCondition(t,Condition(function thistype.r))
        call SetHeroLevel(u,l,false)
        call UnitStripHeroLevel(u,l)
        call SetWidgetLife(u2,GetUnitState(u2,UNIT_STATE_MAX_LIFE)/2)
        call SetWidgetLife(u,GetUnitState(u,UNIT_STATE_MAX_LIFE)/2)
        call TimerStart(CreateTimer(),1,true,function thistype.ts)
        set t=null
    endmethod
endstruct

 

[WaterKnight]

How is it bugged? What has it to do with your code? What do you expect?

 

[Nestharus]

unit health regen goes negative

 

[Bannar]

Are you sure that there aren't any health abilities manipulation yes?
Shouldn't you add given value to current unit's state?

 

[Nestharus]

That is the only code in the map....

Shouldn't you add given value to current unit's state?

I stated unit health regen, not unit life ;p. Health regen isn't effected by killing the unit, pausing the unit, or setting its life.

 

[Bannar]

Elaborate in case I have just CnP script into new map and neither values displayed nor heroes health regeneration descreases/has negative values.
Or I just can't get what you mean by 'negative' values >.>

 

[Nestharus]

Oh woops, because I should have do UnitStripHeroLevel


So my script there doesn't currently display bug, lemme update

edit
updated

 

[Magtheridon96]

Well, you just taught me that Jass is actually slow enough for this:

GetWidgetLife(u)==GetWidgetLife(u)

to return false

edit

I was wrong. PHEWW!

 

[Bannar]

First thing noticed: if value isn't high (the value passed to UnitHeroStripLevel function) nothing wrong happens. It seems that it buggs on bigger ints.

 

[Magtheridon96]

It's because of how they round regeneration and stats as you gain/lose levels :/

 

[Bannar]

If you set gameplay constant Life Regeneration gained per Strength point to 0.00 everything woks fine.
So it seems that (by default 0.05 per str point) every time you call that function, engine calculates the -regeneration gained; formula should be somewhat like:

str pts gained * constant LR per str point = regeneration >>>>> since you reduce the amount of levels it will be: regeneration gained * (-1)

 

[Nestharus]

Er, it should just cancel out and have reg regen for level.


The real problem is how xp overflows with high levels.

 

[defskull]

Er, it should just cancel out and have reg regen for level.


The real problem is how xp overflows with high levels.

The 2 147 483 648 ? (2^31)

 

[Tirlititi]

I also noticed this bug. It happens with Mana and RegenMana too.

I made test some time ago (and without a good engine for getting states : I only looked the values on the unit's life-bar) but I thought the drop was independant of game constants, only dependant of str/int per level.

Also the Skill points are not well removed : 1 level drop => 1 point drop (if it was used, it lowers the level of a spell). It doesn't fit when there are more levels than cumulated spell levels.

Good luck fixing this function. I personnaly just avoid using it.