[General] Unit patrol problem

[Inspexor]

I'm trying to let a unit patrol, then it should wait a second at their current position (checkpoint A), then patrol back to the previous point (checkpoint B); and all that in a loop.

Right now the unit either just keeps standing on one checkpoint or it patrols without waiting at the checkpoint everytime it passes it.

Image is attached, i dont understand what i did wrong.

 

[Rigborn]

Why did you use loop in the first place ? You want him to patrol 10 times ? You also dont have to use stop command cause in the end, all patrol does is attack move to a location then get back to first point right ? So you can use attack-move then check if the target unit is at that point if so, wait then order him to attack move to starting point.

 

[Chaosy]

Using waits is a very unhealthy habit, you cannot trust any code with waits.

 

[IcemanBo]

Make 2 triggers with the event for "A Unit Enters Region", one for each of the checkpoint respectively. When unit enters the region, you might check for correct unit within conditions, you wait 1 second, and order it to go further. Waits are fine, when knowing how to use them.

 

[Chaosy]

Which 99% people do not. So it is better to say no without exceptions.

 

[IcemanBo]

Please explain why wait caused the trouble for him in this case.

 

[Chaosy]

Not really relevant to my point, it should not be used.

 

[IcemanBo]

The wait is a very good function in many cases in GUI. Like in this case. There's most of the times a way to explain in cases it's used wrongly, while putting it just on a blacklist seems unreasoned.

 

[Chaosy]

Let me a count the last time I saw a wait in an approved system.. oh wait.

Waits have a place in cinematics, that's about it.
I suppose waits can also be used for very quick and lazy prototyping in order to save time. But that is not the case.

It is generally bad practice, why do I even have to state that to you?

 

[IcemanBo]

Why reduce the range of wait's usage for approved spells?

1) For most spells it makes often more sense to have a periodic tracking anyways, and also the accuracy matters more for spell standards.
Also, often data Structures are used here to bind data to instances, and to achieve MUI. It's less good and harder to handle, putting all data structure stuff into 1 single trigger, and handle it with waits, than "just" looping over all instances -- where timing can be handled in a good and dynamic way, too.

2) We are not even in Jass, or Spells Section, and using best tequiniques doesn't matter most. Simply, a user has a problem with his project. Now do look at submissions in Maps Section, where most hivers submit their projects, and good luck telling Waits are not useful and to be replaced by Jass Timers best.

 

[Inspexor]

Make 2 triggers with the event for "A Unit Enters Region", one for each of the checkpoint respectively. When unit enters the region, you might check for correct unit within conditions, you wait 1 second, and order it to go further. Waits are fine, when knowing how to use them.

It worked.
Thanks.

 

[Inspexor]

Using waits is a very unhealthy habit, you cannot trust any code with waits.

Thank you for pointing that out.
Now if you know that using "Wait" is a bad idea, what is your advice to fix the problem?