[JASS] TriggerSleepAction, not working?

[ikillforeyou]

Like the title says, without triggersleepaction this works:

 function KillBombs takes unit Unit, integer Bombs, real Time, real rate, real damage, real radius returns nothing
      local location L
      local unit Bomb = Unit
      local real X = GetUnitX(Bomb) + 1000. * Cos(GetUnitFacing(Bomb) * bj_DEGTORAD)
      local real Y = GetUnitY(Bomb) + 1000. * Sin(GetUnitFacing(Bomb) * bj_DEGTORAD)
      local real height = GetUnitFlyHeight(Bomb)
      call UnitApplyTimedLife(Bomb, 'BTLF', (height / rate) )
      call SetUnitFlyHeight(Bomb, 0, rate)
      call IssuePointOrder(Bomb, "move", X, Y)
      call BJDebugMsg(R2S(height / rate))
      call TriggerSleepAction(height / rate)
      set L = GetUnitLoc(Bomb)
      call BombDamage(damage, radius, L, Bomb)
      call RemoveLocation(L)
      set L = null
      set Bomb = null
  endfunction

it basically cuts off at the " call BombDamage(damage, radius, L, Bomb)

any idea?

PS: i'm using call KillBombs.execute
PPS: i'll give you rep, unless your dr. super cool, because i've already given your rep in a while.
PPPS: stop reading these offtopic things and post a reply!

 

[Justify]

Could you maybe show us your call off this function?
I can't find a mistake, but it "could" be that you set "rate" to 0, what would be a division by 0 and causes the trigger to stop immediatly.

 

[ikillforeyou]

Nope, the bjdebugmsg shows somthing like 2.55

 

[Justify]

Just another idea, I'll stop guessing after this
I've hear that the parameters are some sort of globals (no need for nulling, so they can't be locals). Globals and co with waits "suck" pretty much, try to use locals. If it's not this, I can't help you anymore :O

 

[Deaod]

I've hear that the parameters are some sort of globals (no need for nulling, so they can't be locals).

Wrong. Parameters are perfectly local. The reason you dont have to null parameters, according to some Blizzard employees is that WC3 can only distinguish between parameters and non-parameters. Globals and locals are treated equally regarding ref-counting.

In what context do you execute this function? Keep in mind that running it from certain functions, such as trigger conditions or timer callbacks can cause various problems in combination with TriggerSleepAction.

 

[Viikuna]

Also TriggerSleepAction doesnt count gametime, and its not really supposed to be used for this kind of stuff.

If it plays OK for you, then its fine, but when it starts to annoy you much enough, I suggest you to learn how to use timers and get some system like TimerUtils for example.

 

[ikillforeyou]

i use it with a called function inside of a library,

function createbomber takes alot of stuff.... returns nothing
call KillBombs.execute(Bomb, Bombs, time, rate, damage, radius)

 

[Deaod]

Have you verified that its the TSA that crashes the thread and not some function of yours?

 

[ikillforeyou]

Yes, yes i have, And btw, how would i use timers to do this? i really dont understand how you would use a timer.

 

[Dr Super Good]

Your using in an enum as a rough guess. You can not use any TSA in enums as it causes a thread crash.

 

[ikillforeyou]

Nope. D=
Any other guesses?

 

[Dr Super Good]

Try putting
set L = GetUnitLoc(Bomb)
before the TSA. My second guess is that the Bomb unit may be removed causing the location to be incorrect or invalid as the bomb unit dies before you get its location. Check if this makes the bombdamage at the place the bomb came from.

If that works but incorrectly, simply change it so that you bombdamage the point at which you ordered the bomb to move to.

 

[ikillforeyou]

k, now i figured out tsa's working, this code isn't.

  private function 1012921231 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_FLYING) == false )
  endfunction
  
  private function damageunit takes nothing returns nothing
      call UnitDamageTarget(DamagedUnit, GetEnumUnit(), DamagingDamage, true, false, ATTACK_TYPE_SIEGE, DAMAGE_TYPE_DEMOLITION, WEAPON_TYPE_WHOKNOWS)
      call BJDebugMsg("Testing")
  endfunction
  
  private function BombDamage takes real damage, real Rad, location loc, unit whichunit returns nothing
     local group ug = CreateGroup()
     call BJDebugMsg("Test")
     set DamagedUnit = whichunit
     set DamagingDamage = damage / 3
     call GroupEnumUnitsInRangeOfLoc(ug, loc, Rad - (Rad / 3), function 1012921231)
     call ForGroup(ug, function damageunit)
     call GroupEnumUnitsInRangeOfLoc(ug, loc, Rad - (Rad / 2), function 1012921231)
     call ForGroup(ug, function damageunit)
     call GroupEnumUnitsInRangeOfLoc(ug, loc, Rad - (Rad), function 1012921231)
     call ForGroup(ug, function damageunit)
     call DestroyGroup(ug)
  endfunction

it only shows the first testing, it never gets to damaging faze.

 

[Deaod]

how the hell does that compile? Try changing the name of your topmost function (to something with no number as the first char).

 

[ikillforeyou]

Um, you can use numbers as your function name? i've done it before, sigh, mightaswell do it.

 

[Dr Super Good]

Try damaging it with false false and not true false, those parameters seemed unfinished and so likly are buggy.

 

[ikillforeyou]

ok, now it fires properly, but it only damages every one in 10 times, any ideas?