Edit: Does this trigger leak?
Nope.
It does not lag because (I think) it does integer comparison which is way easier for the game to handle than counting the units on the map.
No, your triggers were laggy because every 2 seconds it started 50 loops and each loop waited for some condition check so there were actually a FUCKLOAD of slept loops all going at the same time. Picking every unit on the map can be performance-intensive but only if you really do have thousands of units. Counting all the units in a group is perfectly fine and not slow.
Would these triggers work fine or do you find any issues with them?
(From another map)
No, they do far more than you need to do for what you've described in this map. And honestly your method seems to be
way inefficient with all the waiting_to_spawn stuff (also this is a perfect example of an integer array being useful for saving you a lot of time in the editor clicking on and changing stuff). I would use a slight variation on the triggers I posted before, see below.
I also encountered weird behaviour because they would reset the loop count when another instance is executed
Yes, Integer A and Integer B are both global variables and cannot be used simultaneously between 2 triggers without the second one fucking with the first. The "for each integer variable" version is probably the one you want to use if the loops use waits (which, as I said, you should probably not do) or might fire simultaneously. The GUI MUI tutorial you linked shows how to shadow globals to make them work like locals (which don't overwrite each other) so you can shadow the looper variable for a custom integer loop and it will be 100% wait-safe.
Regarding the leaking thank you for pointing it out. I have played the map numerous times but I did not crash a single time. So what exactly does it help to clear the leaks? I have not noticed that the game felt slower than the beginning as more leaks accumulated, so I don't think it reduces performance?
Any individual leak is unnoticeable, but together they can become a
huge problem.
Memory Leaks or
Things That Leak
Would it also make sense to set custom value of units spawned instead of a unit group?
No, often times custom value is needed for Unit Indexer systems to work properly, which help in attaching data to units are are used by a majority of systems you might want to import into your map. It's best not to use CV at all unless you know you will never need a unit indexer or are willing to rewrite your code if you do. A group in this case is perfectly adequate.
Also, at trigger 3, what purpose does SPAWN_TYPECOUNT have? Should it be used instead of SPAWN_MAX for the If - Conditions at trigger 3's loop?
Yes, I made a mistake writing there. It should be SPAWN_TYPECOUNT.
I am totally going to steal your triggers
That's the point of us posting triggers on this forum. They're always examples to be used at will.
I have set the map up linearly so the heroes face a few hundred of the same 3-5 units before better units are spawning instead so I only care about the total count of spawned units alive. I think of it as a queue where you have 1000 easy units, then 1000 medium units, then 1000 hard units etc...
The triggers are nearly the same:
-
Events
-
Time - Elapsed Game-time is 0.10 seconds
-
Conditions
-
Actions
-
Set SPAWN_MAX = 200 //max 200 spawns on the map at once
-
Set SPAWNS_KILLED = 0 //how many spawns have been killed total
-
Set SPAWN_SWITCHCOUNT = 1000 //after 1000 spawns we'll switch
-
Set SPAWN_PHASE = 1 //1 = early, 2 = mid, 3 = late, do as many as you want.
-
Set SPAWN_TYPE[1] = EarlyUnit 1
-
Set SPAWN_TYPE[2] = EarlyUnit 2
-
Set SPAWN_TYPE[3] = EarlyUnit 3
-
Set SPAWN_TYPE[4] = EarlyUnit 4
-
Set SPAWN_TYPECOUNT = 4
-
Set SPAWN_POINT = Center of Spawn Area Early <gen>
-
Events
-
Unit - A unit dies
-
Conditions
-
((Triggering Unit) is in SpawnGroup) equal to true
-
Actions
-
Unit Group - Remove (Triggering Unit) from SpawnGroup
-
Set SPAWNS_KILLED = SPAWNS_KILLED + 1
-
If (All conditions are true) then (Then actions) else (Else actions)
-
If - Conditions
-
SPAWNS_KILLED greater than or equal to SPAWN_SWITCHCOUNT
-
Then - Actions
-
Set SPAWN_PHASE = SPAWN_PHASE + 1
-
Set SPAWNS_KILLED = 0
-
If (All conditions are true) then (Then actions) else (Else actions)
-
If - Conditions
-
Then - Actions
-
Custom script: call RemoveLocation(udg_SPAWN_POINT) //cleaning the point leak
-
Set SPAWN_POINT = Center of Spawn Area Mid <gen>
-
Set SPAWN_TYPECOUNT = 4 //if there aren't 4 types then you'd need to also change Typecount; I put it here for completeness
-
Set SPAWN_SWITCHCOUNT = 500 //in case you want mid to go faster you can change this variable too
-
Set SPAWN_TYPE[1] = MidUnit 1
-
Set SPAWN_TYPE[2] = MidUnit 2
-
Set SPAWN_TYPE[3] = MidUnit 3
-
Set SPAWN_TYPE[4] = MidUnit 4
-
Else - Actions
-
If (All conditions are true) then (Then actions) else (Else actions)
-
If - Conditions
-
Then - Actions
-
Custom script: call RemoveLocation(udg_SPAWN_POINT)
-
Set SPAWN_POINT = Center of Spawn Area Late <gen>
-
Set SPAWN_TYPECOUNT = 5 //say there's a 5th unit lategame
-
Set SPAWN_SWITCHCOUNT = 100000 //there's no easy way built into this method for the spawns to happen indefinitely, but putting a big number here is essentially good enough
-
Set SPAWN_TYPE[1] = LateUnit 1
-
Set SPAWN_TYPE[2] = LateUnit 2
-
Set SPAWN_TYPE[3] = LateUnit 3
-
Set SPAWN_TYPE[4] = LateUnit 4
-
Set SPANW_TYPE[5] = LateUnit 5
-
Else - Actions
-
Else - Actions
-
Events
-
Time - Every 2.00 seconds of game-time
-
Conditions
-
Actions
-
Set COUNT = (Number of Units in SpawnGroup)
-
If (Conditions) then (Actions) else (Actions)
-
If - Conditions
-
COUNT less than SPAWN_MAX
-
Then - Actions
-
For each (Integer A) from 1 to SPAWN_MAX - COUNT do (Actions)
-
Loop - Actions
-
Set WHICH_SPAWN = WHICH_SPAWN + 1
-
If (Conditions) then (Actions) else (Actions)
-
If - Conditions
-
WHICH_SPAWN greater than SPAWN_TYPECOUNT
-
Then - Actions
-
Else - Actions
-
Unit - Create 1 SPAWN_TYPE[WHICH_SPAWN] for (Random player from Legion of Monsters) at SPAWN_POINT facing Default building facing degrees
-
Unit Group - Add (Last created unit) to SpawnGroup
-
Else - Actions
To get the spawns to change, all you have to do is set a different SPAWN_POINT (if you want) and update SPAWN_TYPE[] as well as SPAWN_TYPECOUNT. Since the spawning happens by pulling from those variables all you have to do is change the unit types and they'll automatically start spawning those instead. You can do this at any time, so a timer could do it after 10 minutes instead of kills, or any other criteria. The way I wrote it checks when a spawn unit dies and increases the kill counter but you could use any trigger. The beauty of using the variable is that it's extremely easy to change on-the-fly for any reason!
Wait until ((Number of units in (Units in (Playable map area) matching (((Entire Region that I want to exclude <gen> contains (Matching unit)) Equal to False) and (((Matching unit) belongs to an enemy of Player 1 (Red)) Equal to True)))) Less than or equal to XXX), checking every 2.00 seconds
