[Solved] Trigger lag

[Mota]

Why does this trigger makes my map to lag when the unit enters the map ? :s

• Auto harv
  • Events
    • Unit - A unit enters (Playable map area)
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) has buff Devotion Aura) Equal to True
          • Then - Actions
            • Unit - Order (Entering unit) to Harvest Nearby Lumber
          • Else - Actions

• SB
  • Events
    • Time - Elapsed game time is 1.00 seconds
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Disable Spell Book for (Picked player)

 

[Malhorne]

Because each time a unit is create then you pick EVERY unit...
Btw it leaks because you don't destroy the group.
So I suggest you to put this before :

• Custom script - set bj_wantDestroyGroup = true

 

[Mota]

• Auto harv
  • Events
    • Unit - A unit enters (Playable map area)
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) has buff Devotion Aura) Equal to True
          • Then - Actions
            • Unit - Order (Entering unit) to Harvest Nearby Lumber
          • Else - Actions

still get the lag :s but then another ideea came to me , duno why i didnt saw it

• Auto harv
  • Events
    • Unit - A unit enters (Playable map area)
  • Conditions
  • Actions
    • Unit - Order (Entering unit) to Harvest Nearby Lumber

and it works quite well, no lags, and if unit has no harvest ability, it stops ^^ the effect i wanted is still the same, ty solved

 

[Malhorne]

Yep it was better sorry for didn't saying this >_<
My bad ^^
Anyway glad you find a solution

 

[IcemanBo]

Is it really necessary always to check every unit when a unit enters map? You could do this Pick every unit in Unit group - action once at start of the game.

 

[Malhorne]

He corrected in a nicer way

 

[IcemanBo]

My bad, I thought he wanted to combine these 2 triggers

If pre-placed units should do so as well, it's still needed to do so once at start.

 

[Mota]

it is for a vampirism type of map, so all units will be trained, wont pre-place ^^