Trigger is taking destroying item instead of taking away 2 charges.

[aussj5link]

Trigger is destroying item instead of taking away 2 charges.

As the title states, this trigger is destroying the item instead of reducing its charges. Do I have something wrong?

• Making Wool Bandages
  • Events
    • Dialog - A dialog button is clicked for FirstAidRecipes[1]
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Clicked dialog button) Equal to FirstAidRecipeButton[1]
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Charges remaining in (Item carried by Sorceress of type Tuft of Wool)) Greater than or equal to 2) or ((Charges remaining in (Item carried by Wizard of type Tuft of Wool)) Greater than or equal to 2)
          • Then - Actions
            • Item - Set charges remaining in (Item carried by Sorceress of type Tuft of Wool) to ((Charges remaining in (Item carried by Sorceress of type Tuft of Wool)) - 2)
            • Item - Set charges remaining in (Item carried by Wizard of type Tuft of Wool) to ((Charges remaining in (Item carried by Wizard of type Tuft of Wool)) - 2)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Charges remaining in (Item carried by Sorceress of type Tuft of Wool)) Equal to 0) or ((Charges remaining in (Item carried by Wizard of type Tuft of Wool)) Equal to 0)
              • Then - Actions
                • Item - Remove (Item carried by Sorceress of type Tuft of Wool)
                • Item - Remove (Item carried by Wizard of type Tuft of Wool)
              • Else - Actions
            • Game - Display to (All players) the text: |cff32cd32[---- ...
            • Wait 0.75 seconds
            • Cinematic - Clear the screen of text messages for Player Group - Player 1 (Red)
            • Game - Display to (All players) the text: |cff32cd32[--------...
            • Wait 0.75 seconds
            • Cinematic - Clear the screen of text messages for Player Group - Player 1 (Red)
            • Game - Display to (All players) the text: |cff32cd32[--------...
            • Wait 0.75 seconds
            • Cinematic - Clear the screen of text messages for Player Group - Player 1 (Red)
            • Game - Display to (All players) the text: |cff32cd32[--------...
            • Wait 0.75 seconds
            • Cinematic - Clear the screen of text messages for Player Group - Player 1 (Red)
            • Game - Display to (All players) the text: |cff32cd32[--------...
            • Wait 0.75 seconds
            • Cinematic - Clear the screen of text messages for Player Group - Player 1 (Red)
            • Game - Display to (All players) the text: |cff32cd32[--------...
            • Wait 0.30 seconds
            • Item - Create Wool Bandage at (Position of Sorceress)
            • Item - Create Wool Bandage at (Position of Wizard)
          • Else - Actions
            • Game - Display to Player Group - Player 1 (Red) the text: |cffffcc00You don't...
      • Else - Actions

 

[Wietlol]

It removes the items if either units have 0 charges left.
No matter how much the other one had.

 

[Tickles]

It's the "or" condition which checks a unit that doesn't exist, because your chosen hero is either a sorceress or a wizard. That automatically returns 0 charges and always makes it remove the item regardless of the charges left. So replace your If/Then/Else with something like this (adding a double negative condition which basically checks if the unit variable is in use):

• Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • Or - Any (Conditions) are true
        • Conditions
          • And - All (Conditions) are true
            • Conditions
              • Sorceress Not equal to No unit
              • (Charges remaining in (Item carried by Sorceress of type Tuft of Wool)) Equal to 0
          • And - All (Conditions) are true
            • Conditions
              • Wizard Not equal to No unit
              • (Charges remaining in (Item carried by Wizard of type Tuft of Wool)) Equal to 0
    • Then - Actions
      • Item - Remove (Item carried by Sorceress of type Tuft of Wool)
      • Item - Remove (Item carried by Wizard of type Tuft of Wool)
    • Else - Actions

 

[aussj5link]

Oh ok! Thank you! I thought if the unit couldn't be checked due to it not existing that that condition wouldn't apply.

 

[Dr Super Good]

You should make it more generic (iterate through all units in a unit group). That would make it more maintainable, efficient and use less script.

 

[aussj5link]

You should make it more generic (iterate through all units in a unit group). That would make it more maintainable, efficient and use less script.

You mean like instead of checking the specific unit, check hero owned by Red?

 

[Dr Super Good]

You mean like instead of checking the specific unit, check hero owned by Red?

No I mean check a group of all applicable classes which is constant. Basically using a group as a hero variable (like your hero variables) except for more than 1 unit.