[Trigger] trigger doesnt work :(

[Palaslayer]

why doesnt this trigger work? oO

• revive
  • Events
    • unit - A unit dies
  • Bedingungen
    • (DyingUnit is a Hero) equal to True
  • Aktionen
    • Set DyingUnit = (Dying unit)
    • Set TempLoc00 = (Position of DyingUnit)
    • game - Display to (All allies of (Owner of DyingUnit)) the text: (((Name of DyingUnit) + will be revived in ) + ((String(((Level of DyingUnit) x 3))) + seconds.))
    • Wait (3.00 x (Real((Level of DyingUnit)))) seconds
    • If (((Owner of DyingUnit) is in (All allies of player 6 (Orange))) equal to True) then do (Held - Instantly revive DyingUnit at (Center of HeroSpawnAllianz <gen>), showing revival graphics) else do (Do nothing)
    • If (((Owner of DyingUnit) is in (All allies of player 12 (brown))) equal to True) then do (Held - Instantly revive DyingUnit at (Center of HeroSpawnHorde <gen>), showing revival graphics) else do (Do nothing)
    • camera - Pan camera for (Owner of DyingUnit) to TempLoc00 over 2.00 seconds
    • Custom script: call RemoveLocation(udg_TempLoc00)
    • Custom script: set udg_DyingUnit = null

 

[GhostWolf]

• (DyingUnit is a Hero) equal to True

Who exactly is DyingUnit ? You declared that variable in the actions.
And do not use a variable as it will overwrite it if another unit dies in those 3*level seconds.
Use Triggering Unit instead.

 

[emperor_d3st]

First: always state what your trigger is supposed to do.
Second: always state what's not working in your trigger.
I think I have already told you this in some other thread.

Well, anyways, I suppose the whole trigger does not fire.

(DyingUnit is a Hero) equal to True
This is your problem. You are referencing to a Variable you didn't even set.

It should look like this:
((Dying unit) is a Hero) equal to True)

On a sidenote: DO NOT use Waits. Use PolledWaits. Simply because Wait doesn't wait through lag and I think it might even cause game splits, which I'm not sure about.

 

[Palaslayer]

• revive
• Events
• unit - A unit dies
• Bedingungen
• (DyingUnit is a Hero) equal to True
• Aktionen
• Set DyingUnit = (Triggering unit)
• Set TempLoc00 = (Position of DyingUnit)
• game - Display to (All allies of (Owner of DyingUnit)) the text: (((Name of DyingUnit) + will be revived in ) + ((String(((Level of DyingUnit) x 3))) + seconds.))
• Wait (3.00 x (Real((Level of DyingUnit)))) seconds
• If (((Owner of DyingUnit) is in (All allies of player 6 (Orange))) equal to True) then do (Held - Instantly revive DyingUnit at (Center of HeroSpawnAllianz <gen>), showing revival graphics) else do (Do nothing)
• If (((Owner of DyingUnit) is in (All allies of player 12 (brown))) equal to True) then do (Held - Instantly revive DyingUnit at (Center of HeroSpawnHorde <gen>), showing revival graphics) else do (Do nothing)
• camera - Pan camera for (Owner of DyingUnit) to TempLoc00 over 2.00 seconds
• Custom script: call RemoveLocation(udg_TempLoc00)
• Custom script: set udg_DyingUnit = null

better like this?

what are polled waits? give an example plz

thx

 

[emperor_d3st]

Er no. You missed the point.

• Set DyingUnit = (Triggering unit)

You see, here you set a GLOBAL variable to something and then

• Wait (3.00 x (Real((Level of DyingUnit)))) seconds

You wait here.. Which means:
If someone else would die your DyingUnit variable get owerwritten.
GhostWolf said that you should forget about this whole DyingUnit global variable stuff and use Triggerint Unit instead.


But you still haven't solved your main problem yet:

• Conditions:
• (DyingUnit is a Hero) equal to True

You are yet to swap this with Dying Unit or Triggering Unit. READ MY FIRST POST.

I would like to note that Triggering Unit is always executed faster by your Computer's Processor than any of its equialents (Dying Unit, Entering Unit, etc.).

 

[Palaslayer]

...next try

• revive
  • events
    • unit - A unit dies
  • conditions
    • ((Triggering unit) is a hero) equal to True
  • actions
    • Set TempLoc00 = (Position of (Triggering unit))
    • Set TempLoc01 = (Center of HeroSpawnAllianz <gen>)
    • Set TempLoc02 = (Center of HeroSpawnHorde <gen>)
    • game - Display to (All allies of (Owner of (Triggering unit))) the text: (((Name of (Triggering unit)) + will be revived in ) + ((String(((Level of (Triggering unit)) x 3))) + seconds.))
    • Wait (3.00 x (Real((Level of (Triggering unit))))) seconds
    • If (((Owner of (Triggering unit)) is in (All allies of Spieler 6 (Orange))) equal to True) then do (hero - Instantly revive (Triggering unit) at TempLoc01, showing revival graphics) else do (Do nothing)
    • If (((Owner of (Triggering unit)) is in (All allies of Spieler 12 (Braun))) equal to True) then do (hero - Instantly revive (Triggering unit) at TempLoc02, showing revival graphics) else do (Do nothing)
    • camera - Pan camera for (Owner of (Triggering unit)) to TempLoc00 over 2.00 seconds
    • Custom script: call RemoveLocation(udg_TempLoc00)
    • Custom script: call RemoveLocation(udg_TempLoc01)
    • Custom script: call RemoveLocation(udg_TempLoc02)

hmm hope i got it now

 

[Kwah]

This should work. . .

gj with the leaks

 

[Palaslayer]

hmm i just read the threads about things that leak

i am very happy that u mafe me a compliment
because i am really new with mapping

thx to all guys who tried to help me!!!

 

[Kwah]

No problem. . .

Message me anytime for help. . .

 

[emperor_d3st]

Yes it should work now, but why don't you test it and find it out by yourself?

You should still swap that wait with polledwait.

 

[GhostWolf]

what are polled waits? give an example plz

Polls waits, in contrast to normal waits, respond to lags / other things that make the game stop.
This means that when you use a normal wait and a player lags, for example, the wait will still continue to decrease while a polled wait wouldn't.

I won't get into accuracy as there are at least one million threads about it.

I would also suggest you to never use a global (either a variable you declared or a event response such as Killing Unit, Casting Unit, and every other event response other then Triggering Unit which isn't a global) with waits, as it will be overwritten if the event fires again within the wait time.

 

[Huurka]

I don't know if it's said already, but you can't use a variable condition if the variable is being set in the actions of the trigger.

 

[emperor_d3st]

Yes, GhostWolf and me both said that already.

 

[Palaslayer]

what i meant with: give an example plz.
was not that i wanted to know what a polls wait is but an example in trigger form...

maybe u can do it for me?

 

[emperor_d3st]

Erm?

• Polledwait(10)

I don't know if it's in the default WE. If it's not there then download NewGenPack as I told you one-hundred times before.

 

[spiwn]

It is there
But it GUI it is Wait game time

 

[Huurka]

http://hilton.vs.oiccam.com/showthread.php?t=90999

 

[Palaslayer]

i downloaded the newgenpack but what should i do with this now?

import it?

 

[emperor_d3st]

Install it. And read the documentation beforehand.