Timer in Module

[GIMLI_2]

Hey guys,

i'm struggling with a (probably) very simple problem. I try to create a buff module that calls a method periodically. As long as i don't implement the module, JassHelper will compile, but as soon as i want to use it, it will throw an error: "this" is not a type that allows . syntax. I'm wondering why that is..

Hidden

    module Buff

        string icon
        string name
        string description
        real duration
        real interval
        // ...
        timer periodictimer
   
        static method callPeriodicBuff takes nothing returns nothing
            local thistype this = GetTimerData(GetExpiredTimer())
            call this.periodic()
        endmethod

        method onEnd takes nothing returns nothing
            // ...
        endmethod

        method onInterval takes nothing returns nothing
            // ...
        endmethod

        method onStart takes nothing returns nothing
            // ...
        endmethod

        method periodic takes nothing returns nothing
            // ...
        endmethod

        static method create takes nothing returns thistype
            local thistype this = thistype.allocate()
            set periodictimer = NewTimer()
            call SetTimerData(periodictimer, this)           
            call TimerStart(periodictimer, 0.1, true, function thistype.callPeriodicBuff)
            return this
        endmethod

        method destroy takes nothing returns nothing
            // ...
        endmethod



    endmodule

    /*struct s
        implement Buff
    endstruct*/

 

[IcemanBo]

Which line throws the error? Looks fine..

 

[GIMLI_2]

I think it was this line

call this.periodic()

inside the callPeriodicBuff method, but i have to check again tomorrow. As i said, it only throws an error if i implement Buff inside any struct

 

[Dr Super Good]

"this" might be a key word in vJASS. Try calling the variable something else.

 

[Pyrogasm]

I would expect it’s confused by the usage of “this” in a static method where it doesn’t expect one.

 

[GIMLI_2]

I already tried that. It throws the same error

 

[Pyrogasm]

A function can’t call a function below it. Periodic needs to be above callPeriodic, or you have to use .execute/.evaluate.

 

[GIMLI_2]

yeah you're right. I have to try later, but thats probably the problem. Thanks

 

[GIMLI_2]

first of all.. it worked!

second: is it possible to create those methods as an interface? I want to do

module Buff
        method OnInterval takes nothing returns nothing
endmodule


struct s
    method onInterval takes nothing returns nothing
        // do something
    endmethod

    implement Buff
endstruct

 

[IcemanBo]

But it should allow calling underlying methods with JassHelper just creating an extra method above behind the scenes.

struct TestStruct

static method a takes nothing returns nothing
    local thistype this = 1
    call this.b()
endmethod

method b takes nothing returns nothing
endmethod

endstruct

.. compiled:

//Generated method caller for TestStruct.b
function sc__TestStruct_b takes integer this returns nothing
endfunction

function s__TestStruct_a takes nothing returns nothing
    local integer this= 1
    call sc__TestStruct_b(this)
endfunction

function s__TestStruct_b takes integer this returns nothing
endfunction

.. where the very first function is onlycreated so one can call the underlying "b" function in source code from "a".

is it possible to create those methods as an interface?

Yeh, a struct can extend an interface JassHelper 0.A.0.0.

 

[GIMLI_2]

Yeh, a struct can extend an interface JassHelper 0.A.0.0.

but it seems like a module cannot extend an interface?

 

[IcemanBo]

struct A can extend interface I, and struct B can extend struct A. I guess this is what you want?

 

[GIMLI_2]

yes that is basically what i want. it is a bit weird tho, to create methods in struct A and leave them empty like

method onInterval takes nothing returns nothing
endmethod

it has to be declared due to the interface.. so.. is there a "better" way?

 

[IcemanBo]

Yeh, and probably you want them to be stub methods. You can't seperate declaration and implementation of a function in JASS, that's why yeh, you have to write just the method as empty. :/

 

[GIMLI_2]

alright, it's important that it works, and it does.
thanks