The_Flood's Combat System 1.0b

[Moderator]

12:03, 14th Jun 2010
Hanky:
I found some things that have to be fixed:
- there's a bug, in the combatenter trigger you increase the combat_index variable with 2 but in the combatchecking trigger you just decrease it with 1, so the trigger even if there are no combats
- maybe change the way of attaching the datas to your units, but well it's okay how it is

After you fixed improved those things message me or an other spell moderator.

 

[Noobsmoke]

cannot open it with WORLD EDITOR ... this system can't be approved

 

[D4RK_G4ND4LF]

I can open it but I also had problems with lots of other spells I could not open :/
-however picking al units in playable map area twice every second might be lethal for performance
you may add all units in combat to some unitgroup and pick all these units instead (dunno if it will work like that cause I am to lazy to totally understand how your system works )
-no option to disable floating text (would be easy to change the group stuff but the trigger would still create the texts which is unnecessary in this case)

+it seems like all leaks which can be removed with GUI easily are removed
+documentation
+I like it, might make my own in case I am going to need something like that

 

[The_Witcher]

i liked the system and had no problems to open it...
it may be useful for some people but like D4RK G4ND4LF already said add an option for the floating texts!!
in addition the waiting time of 10(!) seconds after combat is much too long!!
every mapper can customize that easy, but as i tested the system i ordered a fighting soldier to run away while the creeps were still fighting other guys (= he leaves the combat) but there was no signal from your system and i thought you made something wrong^^
set the time in your test map to 4 seconds... that would be much better!!
anyway good system 4/5

 

[lolreported]

cannot open it with WORLD EDITOR ... this system can't be approved

Are you sure that you've updated to patch 1.24?

I can open it but I also had problems with lots of other spells I could not open :/
-however picking al units in playable map area twice every second might be lethal for performance
you may add all units in combat to some unitgroup and pick all these units instead (dunno if it will work like that cause I am to lazy to totally understand how your system works )
-no option to disable floating text (would be easy to change the group stuff but the trigger would still create the texts which is unnecessary in this case)

+it seems like all leaks which can be removed with GUI easily are removed
+documentation
+I like it, might make my own in case I am going to need something like that

Yes, by picking all units in the map may cause alittle lagg. I'll see what I can do about it, maybe add all combat units into an unit group.

I can add a option of the combat texts should appear or not, or else you can simply set the "EnteringCombatText = "" " and "LeavingCombatText = "" "

Thanks for the feedback, I'll try update this soon. +rep

i liked the system and had no problems to open it...
it may be useful for some people but like D4RK G4ND4LF already said add an option for the floating texts!!
in addition the waiting time of 10(!) seconds after combat is much too long!!
every mapper can customize that easy, but as i tested the system i ordered a fighting soldier to run away while the creeps were still fighting other guys (= he leaves the combat) but there was no signal from your system and i thought you made something wrong^^
set the time in your test map to 4 seconds... that would be much better!!
anyway good system 4/5

I'll fix an option for the combat texts And about the 10 seconds to leave the combat can you easily chance by setting

• Set TheTimeBeforeLeavingCombat = 10.00

to another number.

Thanks for the feedback and I'll update the system ASAP, +rep


I've updated this system from version 1.0a to 1.0b. Read the change log to read what I've fixed and added.

Change Log

Version 1.0a
- #Release

Version 1.0b
- #Added an option that allow you to change if the floating combat texts will appear or not.
- #Fixed an issue that units didn't left the combat when they ran away.
- #Reduced the lagg by changing the unit group pick. Now ONLY the units in combat will be picked, not everyone.

 

[i_am_cuul]

Very nice system, altho some things i dont like about it are:
- when attacking 2 units and 1 dies, you go out of combat immediately even tho the other one isnt dead yet.
- spells dont trigger you going into combat

 

[lolreported]

Very nice system, altho some things i dont like about it are:
- when attacking 2 units and 1 dies, you go out of combat immediately even tho the other one isnt dead yet.
- spells dont trigger you going into combat

Thanks for the comment. I knew about the first thing you said, but the seconds thing didn't I know. I'll have to try fix that +rep

 

[ihatehumans]

Well, what I would suggest is adding a second trigger replacing all instances of attacked/attacking with target of cast and the caster of an ability. There's the event for it. Also, add a condition to the trigger to check that the target of the ability being cast is an enemy of the caster of the ability, I believe those are in there somewhere

Hopefully 5 months isn't too long