[System] Item Recipe

[deathismyfriend]

moved

 

[Almia]

Just name the struct recipe bro

Your indention is messed up again

globals
    private Table recipeTable
endglobals

    struct RecipeList extends array

    private static method onInit takes nothing returns nothing
        local trigger t = CreateTrigger()
        set recipeTable = TableArray[0x2000]
        call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_PICKUP_ITEM)
        call TriggerAddCondition( t, function thistype.recipeCheck)
        set t = null
    endmethod
    
    endstruct

see that?


call TriggerAddCondition( t, function thistype.recipeCheck)

Did you not use JNGP? TriggerAddCondition takes boolexpr, not code.This will cause syntax error.

and also this :

        set this.i1 = i1
        set this.i2 = i2
        set this.i3 = i3
        set this.i4 = i4
        set this.i5 = i5
        set this.i6 = i6

JASSHelper doesn't allow that kind of syntax

I also rather use private integer array item to take up some space.

edit

I will like this if this features Disassemble item

 

[deathismyfriend]

i used JNGP even tested and it works fine w the boolexpr lol.

as for the things like this.i1 = i1 thats because of the way i named it.
heres what i mean

static method create takes integer i1, integer i2, integer i3, integer i4, integer i5, integer i6, integer itmToBeMade returns thistype

and this

    struct RecipeList extends array
        implement Alloc
        
        private integer i1
        private integer i2
        private integer i3
        private integer i4
        private integer i5
        private integer i6

i will change the name to recipe. will try to make a dissasemble item shouldn't be hard at all will just make another struct to do it should be very easy that way if i cant think of a better way using what i already have lol.

and wow sry about the indentation lol i keep doing tht. really stupid haha

edit: i updated changed name like suggested changed syntax a little so it does not confuse someone. ex this.i1 = i1 changed to this.i1 = id1
hopefully updated the indentation the right way haha

 

[Almia]

Looks nice now

 

[deathismyfriend]

Looks nice now

thanks lol ill probably forget next time

there almia it can now disAssemble items made through recipes

 

[Almia]

Oh

I found a reason why i want you to make the private integer iX to array,this will make your code shorter.

And in the disassemble method,will it cause any bad effects when adding null items?

 

[deathismyfriend]

from what i was able to test no it did not add any negative effects. and what do u mean change the private integer iX to array ?

 

[Almia]

private integer array i

 

[deathismyfriend]

u mean for the thing in the struct ? my struct extends array so i cant use variables like that and i dont want to make it a global as it could cause some bugs. thts why i take the variables from the struct and change them to a local variable array in the method then use the array. if thts not what u meant could u plz explain more ? ill have to look at it tomorrow tho as im about to fall asleep i will also add an option to pause and resume the the recipes from being made right when u pick up an item that way the user can change that a little easier if they want to

 

[Zwiebelchen]

I really wonder why people still submit recipe systems? Those things are never useful for the common mapmakers, as the event-cross-interactions with other inventory systems are fatal.
For example, removing items from the inventory to create the crafted item fires the item drop event, which might cause bugs when used together with other inventory systems.

People are usually better off using an inventory system that does all-in-one, not using different resources collected from different places.

This or someone finally creates an item event handler that allows to turn off events globally for all inventory systems used when using AddItem and RemoveItem.

Plus, this is so damn simple that any mapmaker can do this on his own. Even with GUI.

 

[looking_for_help]

Did you not use JNGP? TriggerAddCondition takes boolexpr, not code.This will cause syntax error.

Just to mention it, you can use TriggerAddCondition with code as an argument:

scope test initializer Init
    private function testFunction takes nothing returns nothing
    endfunction

    private function Init takes nothing returns nothing
        local code c = function testFunction
    
        call TriggerAddCondition(CreateTrigger(), Filter(c))
    endfunction
endscope

Then you don't have to return false in the condtion function.

Why does this work by the way?
With this techinque you can even pass functions that return anything you want which doesn't really make sense^^

 

[deathismyfriend]

If ur tlking about all in one zwiebelchen then what do u mean ? What other functionality does this system need to be all in one ? And this was a system tht I made to be very simple to use w a nice outcome of allowing a lot of recipes. That r easy to change since creating a recipe only uses one line of code. U can also easily make multiple recipes that use one or more of the same ingredient. I code also make a method that can be used to turn off those other systems tht use drop item to fire if they have a trigger to turn off or if they use a Boolean to make them stop working like how mine is. I am also gonna put a pause and resume method so people can pause this when needed.

 

[deathismyfriend]

added a pause and resume in case anyone needs to turn off the system

added 2 methods that u add things to to turn off other systems that run on the event EVENT_PLAYER_UNIT_DROP_ITEM
this way if u have any adverse effects when running it will temporarily turn off those systems for u at the right time then turn them back on after the items have been created and removed the old item/s

 

[edo494]

what happens if I want the recipe to take 2 items of same type? like 2x claws of attack +15 => claws of attack +35 ?

 

[deathismyfriend]

what happens if I want the recipe to take 2 items of same type? like 2x claws of attack +15 => claws of attack +35 ?

i did not try that but i will test it right now and if it doesnt work i will adjust it accordingly.

edit: it does not work w 2 of the same items. i will work on an update asap.

 

[Elprede]

Would you add to this system the functionality of working with such events as Unit enters rect?

 

[deathismyfriend]

Would you add to this system the functionality of working with such events as Unit enters rect?

i hope to since that is a way of combining ive seen a lot. im fixing the error i had for combining 2 items of same kind. then i will try to find a way to allow for both unit enters region or unit picks up item.

edit: got it to work w 2 or more of the same item just need to fix a small bug now. should be up in under an hr i hope

 

[Almia]

Merge the double-post bro

 

[deathismyfriend]

i got it to work again although with a slight efficiency decrease but it should not matter in game.

 

[Elprede]

How does one use this system with specific rects, deathismyfriend? For me, the documentation does not clearly state this.

 

[deathismyfriend]

oo im sorry i will change the documentation for easier use. ill explain it here as well. first make a preset rect using the region palette in world editor. then were i have

set recipeRect = Rect( 32, 32, 0, 0)

change it like this

set recipeRect = gg_rct_urRegionNameHere

and there u go

 

[Elprede]

Am I correct to assume that your system takes only one rect?

 

[deathismyfriend]

oops i knew it looked funny lol gonna change that immediately. give me about 10 min

edit: now availiable for multiple rects

to add heres example heres what it looks like at first

private static method setRect takes region r returns region
            call RegionAddRect( r, gg_rct_urRectName)
            return r
        endmethod

here it is w multiple rects

private static method setRect takes region r returns region
            call RegionAddRect( r, gg_rct_urRectName)
            call RegionAddRect( r, gg_rct_urRectName1)
            call RegionAddRect( r, gg_rct_urRectName2)
            call RegionAddRect( r, gg_rct_urRectName3)
            return r
        endmethod

 

[Elprede]

I believe with multiple rects, users should be able to set a specific rect for each recipe because the variety of rects now is useless without a "owner". This does NOT mean preventing multiple recipes from requiring the same rect.

 

[deathismyfriend]

I believe with multiple rects, users should be able to set a specific rect for each recipe because the variety of rects now is useless without a "owner".

that makes sense i will update w ownership of regions. not sure if i will get it done in time only have 20 minutes. if i cant it will be done in about 6 hrs or so.

 

[Magtheridon96]

I think you should make it irrelevant to rects.
Make the system only handle the recipes themselves.

The API would be something as simple as:

function CreateRecipe takes Table inputs, integer inputSize, Table outputs, integer outputSize returns Recipe
function CompileRecipe takes Table itemIds, integer tableSize returns Table // returns output table

 

[deathismyfriend]

I think you should make it irrelevant to rects.
Make the system only handle the recipes themselves.

The API would be something as simple as:

function CreateRecipe takes Table inputs, integer inputSize, Table outputs, integer outputSize returns Recipe
function CompileRecipe takes Table itemIds, integer tableSize returns Table // returns output table

so ur suggesting to make something that will forcible create recipes. like when unit enters region. the reason i included the rects is just an option if someone doesnt want to use rects all they do is set rect to null. and just use false for the create item recipe method.

edit: i think i will change it back to what u say that way all they will have to call is forceRecipe to manullay create it w event and condition of there choosing

edit 2: i updated the recipe system to not use rects and added a method called forceRecipe. i kept the rest of the API the same

 

[deathismyfriend]

bump

 

[Magtheridon96]

I'm still not sure if this cuts it :/

You should allow this to take in any number of item ids.
It should take a Table with a size representing an array.

I think this would be good if it used a plugin approach.
Look at Nestharus' DDS system to see a cool plugin design.

Your core would be nothing but a Recipe data storage unit that allows a user to call one function: createRecipe(Table input, integer size, Table output)

I was going to do this at one point, but I don't have Windows for now.

I was envisioning a plugin that takes a list of item ids and returns an item id for the resultant item. You would also provide an example plugin that uses the assembly plugin to assemble items in the unit's inventory upon picking up an item just to show them how to use this for the regular wc3 inventory (people might want to use a custom inventory after all)

The disassemble plugin would require the assemble plugin. It just maps a resultant item back to one of the possible combinations. You can also expand it with a plugin to disassemble specific items. This plugin would return the exact recipe used to compile a certain item because it would store the recipe data instance in a hashtable using the handle id of the item.

THAT would be the perfect recipe system.

 

[deathismyfriend]

i dont like the idea of plugins for a Recipe system. For a damage detection system thats a great idea. It is just meant to make a recipe and create the item when the recipe is present. The disassemble could be a little better but the only problem is how to know which item to disassemble to ? i would have to store all the info whenever a unit creates that item. And still i have no idea what u r referring to w the Table input / output things.

 

[Almia]

you should move the checkingRecipes method on the top of the struct methods. Also,you don't need to type "thistype" when executing functions.

 

[deathismyfriend]

ya probably should.

 

[Adiktuz]

by looking at the code, I take that this does not support item charge requirements right?

like item1 should have 2 charges for the recipe to work etc...

 

[deathismyfriend]

by looking at the code, I take that this does not support item charge requirements right?

like item1 should have 2 charges for the recipe to work etc...

no it doesnt. i might be able to make that tho. ill c what i can do when i have time

 

[Adiktuz]

I'd really suggest that... though Maggy's system already does that...

 

[deathismyfriend]

Maggy's ?

 

[Almia]

Mag's Recipe Engine :
http://www.hiveworkshop.com/forums/spells-569/recipe-engine-v2-0-0-0-a-199204/

 

[deathismyfriend]

never seen it b4 lol

edit: took a look at it. it does have some similar things to mine

 

[Magtheridon96]

My Recipe System sucks though.
See that post I made before about modularity? I've been attempting to modularize it in ways less superior than that before and I've failed because I didn't know how to make it user-friendly. Nes showed me through DDS how to make the recipe system of my dreams.

Too bad I'm probably never going to update it which is why I was counting on you guys to make something of the sort

 

[deathismyfriend]

i might have the time when the summer is over. atm i do not.
i also dont think that this recipe system is a bad one. it is pretty user friendly and pretty fast. as for the disassemble of the recipes, yes it could be better. also the items with requirement of item charge requirements should be added. i just havent had the time. even my own map has been in limbo for the last 2 to 3 months now.

updated. Now allows for item recipes that require items with charges.

 

[Adiktuz]

Cool update... very useful for most maps that need recipe systems...

 

[deathismyfriend]

thanks Adiktuz. and thanks for the rep lol.

 

[TriggerHappy]

moved

So, graveyard anyone?

 

[PurgeandFire]

gy'd