[JASS] Switching Abilities

[kari0003]

Im using this code, to swap abilities (which are passive coded with trigger):

if GetSpellAbilityId() == SPELL1
    UnitRemoveAbility(u, SPELL1)
    UnitAddAbility(u, SPELL2)
    (...)
elseif GetSpellAbilityId() == SPELL2
    UnitRemoveAbility(u, SPELL2)
    UnitAddAbility(u, SPELL1)
    (...)

Apparently it isnt working, Add+Remove blocks each other. Any idea how to make this working?
Note: Alternative (Buff using) abilities would not be good enough, i have to do this with triggers.
Note2: SPELL1 and SPELL2 both created from channel

Help will be appreciated

 

[Lender]

what is the event? if you trigger that when you cast spell1 or spell2 then its ok

did you chacnged the order id for the spells?

 

[Krogoth]

Can you show whole function? Nothing is clear with no even statement brackets.

 

[kari0003]

Here is a fragment of the function, the whole function looks like this, just with more else if-s

Please dont count grammatical errors, because its written in a JASS compiler (Wurst)

The Event of the trigger:
TriggerRegisterUnitEvent( myTrigger, actor, EVENT_UNIT_SPELL_CAST )

function switchMode(int spell_id)
			if spell_id == ICE_ABILITY
				UnitRemoveAbility(actor,ICE_ABILITY)
				UnitAddAbility(actor,REVICE_ABILITY)
	            modification = 0
	            DisplayTextToPlayer( GetOwningPlayer( GetSpellAbilityUnit() ), 0, 0, "Normal")
	        else if spell_id == REVICE_ABILITY
				UnitRemoveAbility(actor,REVICE_ABILITY)
				UnitAddAbility(actor,ICE_ABILITY)
	            modification = 1
	            DisplayTextToPlayer( GetOwningPlayer( GetSpellAbilityUnit() ), 0, 0, "Reverse")

The bug is directly connected to the Removeing&Adding ability, because without it, the (passive)abilities work fine.
Only I want this to work because of the user interface. So instead of 2 icons you'd see 1 changing when you click it.

 

[Krogoth]

So, try to make different order id for spells in Object Editor. If it will not work try to use another spell for second ability, Ice Nova, for example. If it will not work, try to change your code because there is no other way to make it not working.

 

[Tirlititi]

Also, I think the event EVENT_UNIT_SPELL_ENDCAST is fine for that kind of stuff.

 

[kari0003]

Yeah you got it Tirlititi, that solved my problem!

Maybe things screwed up when i removed the ability during casting

[TD] SOLVED [/TD]