Stringed Shuriken v1.2

[Moderator]

01:06, 22nd Jul 2012
Magtheridon96:

Suggestions given here:
http://www.hiveworkshop.com/forums/2186609-post6.html
http://www.hiveworkshop.com/forums/2187283-post9.html

This a pretty nice spell c:

edit
Approved.
There's absolutely no reason for me to just wait for the end of the contest to approve these.
This spell is adequate, but I would still recommend applying the suggested changes.

 

[defskull]

Reserved.

Report any bugs (or leaks) you found, thank you.

Also, as you can see from the data or triggers from the test map, perhaps some of them contains dagger word, where it should be shuriken.

At first, I thought I wanna make it as Dagger model that I used The Warden's missile as dummy unit but then I realize it was making so much noises that I decided to change the dummy unit model to something else, a shuriken-like model.

The spell originally named Stringed Dagger and was turned into Stringed Shuriken.

If there are mistakes in texts/variables of "Dagger" word, please inform me as I will change it.

 

[zv27]

• Unit - Create 1 SS_DummyShuriken for (Triggering player) at TempLoc facing TempReal degrees

should be

• Unit - Create 1 SS_DummyShuriken for (TempPlayer) at TempLoc facing TempReal degrees

 

[APproject]

Great spell for melee heroes. It remind me of Deathknight's spell which pull target towards oneself in WoW. It is also good as enemy may avoid it by running away from missle. Spell itself is not full of special effects that swarm the screen like in most of custom spells, I like it.

 

[Almia]

You also posted the spell ahaha

also you leak a player group..
1st make a variable for it then use this script call DestroyForce(udg_Players)

Also,why didnt you make it in JASS???due to a lot of scripts

 

[Magtheridon96]

Trigger

• Player Group - Pick every player in (All players) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked player) is an ally of TempPlayer) Equal to True
      • Then - Actions
        • Set TempPlayer = (Picked player)
        • Custom script: if GetLocalPlayer() == udg_TempPlayer then
        • Set SS_LightningAlphaValue = SS_LightningAlphaValueSetup
        • Set TempReal = 0.00
        • Custom script: endif
      • Else - Actions

Too much complexity and buggy in games with complex alliance. (The friend of my enemy can be friend)

Can be simplified:

Trigger

• Custom script: if IsPlayerAlly(GetLocalPlayer(), udg_TempPlayer) then
• Set SS_LightningAlphaValue = SS_LightningAlphaValueSetup
• Set TempReal = 0.00
• Custom script: endif

edit
@Radamantus: (All Players) doesn't leak.

 

[Lambdadelta]

So that is why you wanted a white lightning. Looks like a spider web more than a stringed shuriken.

 

[defskull]

• Unit - Create 1 SS_DummyShuriken for (Triggering player) at TempLoc facing TempReal degrees

should be

• Unit - Create 1 SS_DummyShuriken for (TempPlayer) at TempLoc facing TempReal degrees

I'll edit it later, thanks for that

Great spell for melee heroes. It remind me of Deathknight's spell which pull target towards oneself in WoW. It is also good as enemy may avoid it by running away from missle. Spell itself is not full of special effects that swarm the screen like in most of custom spells, I like it.

Thanks

You also posted the spell ahaha

also you leak a player group..
1st make a variable for it then use this script call DestroyForce(udg_Players)

Also,why didnt you make it in JASS???due to a lot of scripts

I just wanted to say about (All players) but mag has said it.

Trigger

• Player Group - Pick every player in (All players) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked player) is an ally of TempPlayer) Equal to True
      • Then - Actions
        • Set TempPlayer = (Picked player)
        • Custom script: if GetLocalPlayer() == udg_TempPlayer then
        • Set SS_LightningAlphaValue = SS_LightningAlphaValueSetup
        • Set TempReal = 0.00
        • Custom script: endif
      • Else - Actions

Too much complexity and buggy in games with complex alliance. (The friend of my enemy can be friend)

Can be simplified:

Trigger

• Custom script: if IsPlayerAlly(GetLocalPlayer(), udg_TempPlayer) then
• Set SS_LightningAlphaValue = SS_LightningAlphaValueSetup
• Set TempReal = 0.00
• Custom script: endif

edit
@Radamantus: (All Players) doesn't leak.

I'll fix it later.
How about the triggers itself ?
What can you say about them ?

So that is why you wanted a white lightning. Looks like a spider web more than a stringed shuriken.

It's better than nothing.

 

[Magtheridon96]

Nothing really major:

Trigger

• Unit - Create 1 SS_DummyShuriken for (Triggering player) at TempLoc facing TempReal degrees

You could've used the variable instead of (Triggering player).

Also, when you're setting that boolean and using it in an if block, well, you could've just loaded the variable directly in the if statement rather than setting it in a boolean and using that.

 

[defskull]

You mean I should load directly in the Condition block using Hashtable load ?

Well if you say so, I should do that method for all types of loading data from hashtable and use it, right ?

Like if in the damage part, I should load directly the damage in the function Unit - Damage Target in damage parameter.

Really ?

 

[Magtheridon96]

If you only need it once, don't store it into a variable because you don't need to
It's only worth storing into a variable if you need it 2+ times.

 

[defskull]

• Custom script: if IsPlayerAlly(GetLocalPlayer(), udg_TempPlayer) then
• Set SS_LightningAlphaValue = SS_LightningAlphaValueSetup
• Set TempReal = 0.00
• Custom script: endif

Fixed

• Unit - Create 1 SS_DummyShuriken for (Triggering player) at TempLoc facing TempReal degrees

Fixed

Also, when you're setting that boolean and using it in an if block, well, you could've just loaded the variable directly in the if statement rather than setting it in a boolean and using that.

If you notice, I'm using the Boolean condition 2 times.
Also, I think loading a data and set it as a variable is not a bad idea, it could improves readability too from certain function,

• SS_BooleanHit Equal to False

Compared to,

• (Load 4 of SS_Key from SS_Hashtable) Equal to False

I don't know, that's just my perspective ;p

Stringed Shuriken v1.1 is up.

 

[Losam]

His Skill is well drafted.
 And it's funny the effect of pulling the target.
 Soon, you won my vote.

English only please ~Magtheridon96

 

[defskull]

His Skill is well drafted.
 And it's funny the effect of pulling the target.
 Soon, you won my vote.

Well, thank you
Why do you said it's funny

Fixed. ~Magtheridon96

 

[Losam]

Response

It's funny because I can throw the Shuriken at more than two heroes.

Your Spell is MUI? (I didn't have time to analyze this).

May GOD Bless All!

 

[defskull]

Yes my spell is indeed MUI
It's the Spells Section rule, I must obey that rule before I upload any spell to this section.

 

[defskull]

Updated to v1.2.

 

[Dr.Killer]

Nice entry. I like the idea.