Spawn the Kraken

[Daffa]

Make special effect configurable
separate config into another trigger run at map init
tentacle needs to be configurable
avoid Integer A/B

 

[millzy]

so add a variable for the speical effect type
so another bunch of variables that are set on map int that are used in the spell cast? (i dont believe this is necessary since all the configs are set up on the spell cast but if thats the standard i can add them)
what do u mean another unit type variable for the spawn?
alright then

 

[Daffa]

yes, attachment points too
it's for efficiency, unless your spell dependant on values like str
the tentacle should be a choice for players. they might use their own custom version

 

[millzy]

the speical effects arnt attached to units
how is adding extra unnecessary config variables that is configed again on spell cast more efficient?
i guess i can add config for the tentacle with another variable (even tho it only requires 1 change to the spell cast and a boolean on the removal trigger)

 

[Elprede]

Everything the user can change would be in one trigger, so that he does not have to look through the entire spell.

Frankly, the spell should have a lot more manipulable fields, especially the unit type created and the effects, which are inconveniently located on the second trigger, than what is provided on the casting trigger, so a separate trigger for config would be necessary.

[Retracted]

 

[millzy]

ill add the config variables for the special effect and the spawned units.

altho i really dont see the point in having

Hidden

• Melee Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
• set Config_k_damage = 30
• set Config_k_duration = 10
• ect......

• raken cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Kraken
  • Actions
    • -------- turn looping trigger on if not already --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • K_NCasters Equal to 0
      • Then - Actions
        • Trigger - Turn on Kraken Loop <gen>
      • Else - Actions
    • Set K_index = (K_index + 1)
    • Set K_NCasters = (K_NCasters + 1)
    • Set K_CastON[K_index] = True
    • Set K_Caster[K_index] = (Triggering unit)
    • Set K_Center[K_index] = (Target point of ability being cast)
    • Set K_Damage[K_index] = (Config_k_damage x (Real((Level of Kraken for K_Caster[K_index]))))
    • -------- Duration of the spell in seconds --------
    • Set K_Duration[K_index] = Config_k_duration
    • ect.....

when u can just config them in the casting trigger like ALOT of people do. there are plenty of spells on here i can link to show you

 

[Elprede]

Like I said, the point is convenience for the users in that all configurables are in one trigger.

I have seen a lot of spells, primarily old ones, also place configurables in the cast trigger. However, these spells use extra variables. Therefore, configurables are set during each cast. This process is computationally more expensive than setting them once on Init. In the case of your spell, users directly change the values of the array, so the above is not an issue for you.

In line with this is that nulling integers, real, and booleans is useless.

[Retracted]

 

[millzy]

Like I said, the point is convenience for the users in that all configurables are in one trigger.

all the configs are in 1 trigger the casting trigger....

I have seen a lot of spells, primarily old ones, also place configurables in the cast trigger. However, these spells use extra variables. Therefore, configurables are set during each cast. This process is computationally more expensive than setting them once on Init. In the case of your spell, users directly change the values of the array, so the above is not an issue for you.

it also allows usersers a easier option for changing values for each level of the spell if they wish.also every thing needs to be set in the arrarys to e.g keep track of that current spells duration

A major issue with your spell is the indexing method. I would look into Visualize: Dynamic Indexing.

im simply using none Dynamic indexing [Trigger] - Why dynamic indexing is flawed and people should use linked list instead

Resetting the variables at deindexing is pointless, except for variables you do not set during cast (though you could set those at cast as well, so you would not have to pointlessly reset them at deindexing).
In line with this is that nulling integers, real, booleans, and unit (not if the unit referenced will eventually be removed) variables is useless. These variable types are not handles, except for unit.

its always good practice to null variables the boolean is for if that instance is still being used since the indexing in none dynamic

[For tracking instances, K_Index is more than enough. The K_NCasters variable is just extra.

no this is required for the indexing method im using

 

[Elprede]

All configs would not be in one trigger, if you add in the unit type and the special effects. I hope you are not planning to add these to the cast trigger.

Users should not have to touch the main code to change your spell according to their needs. This way to config is less error prone on the user side.

 

[millzy]

remove the boolean and watch the spell fail when cast multiple times

you need to understand there are multiple ways of doing things

 

[Chaosy]

Weirdly clean code by GUI standards..

I like how you managed to group the special effects, variable declaration and custom in small groups.

 

[Daffa]

Despite it being point, making the SFX possible to change in a string makes it easier.

The efficiency is seen with more cast is done, where the same value is not set multiple time. It's negligible though, but it reduces user error.

Just a note, standard changes over time.

 

[millzy]

Updated with the extra configs

 

[Krakenn99]

I have been spawned!

 

[Tasyen]

Needs Fixed

• "The PREFIX length should be at least 3-4 characters long, or even more, to ensure some uniqueness."
• Data setup should be inside the config:
  • AoE, Tentakel Amount, Tentakel distance, Spinning Water distance.
• -------- If Duration is up null varibles --------
  • Can only happen after the damage code is executed, it would be better to move it into the "
    K_timer[K_intLoop] greater equal 1.00" if.

Suggestion:

• Duration, AoE, Tentakel Amount & PullPower supporting multiple Levels.
• the spinning water distance could refer directly to the AoE settings (AoE[level] * 0.9) (inside the config).
  
• On Default set "pullpower a second" instead of "pullpower a intervale", Pullspeed a second is alot more easy to understand/balance for the user.
  • ( pull a second * System intervale)
  • -3 => (-100 * 0.03)

 

[Tank-Commander]

Hi thanks for the submission.

I like the concept of the spell but I find the configuration options a bit lacking and there's some efficiency boosts that could be done to make it much better:
- The effects made by the loop should be made less often or have the option to be made often (otherwise you're creating over 100 effects every second which do nothing other than visuals and is really unnecessary)
- Those effects could also be made via a loop and different offsets rather than each angle being manually entered
- Effect Offsets and the like could all be configurable
- AOE/Pull/Tentacle type (think water elemental)/Number of Tenctacles/Duration/etc. could all be configurable and support multi-levelling as mentioned by Taysen
- AttackType and DamageType could also be configurable the ability used as a base could also be configurable
- Instead of having 0.03 hardcoded at various points in the spell it'd be better to have it as a configurable constant and then refer to that constant
- Your spell requires a 3-4 character Prefix to identify its variables uniquely from other spells (something like "SpKr_")

 

[PurgeandFire]

Thanks for following up with the updates via PM's.

I think some of the stuff could still be cleaned up (like the 4 RemoveLocation lines could be put within the loop where you make the effects), but the triggers look a lot better!

Approved!

 

[BlackRangerXIII]

Oh hey, Hydroid's Tentacle Swarm. Nice