Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
23:22, 22nd Aug 2012
Magtheridon96:
Just a quick review:
- All speeds must be MUI and MPI, not just one.
- Instead of repeating function calls like (Owner of blabla), (Picked unit), (Triggering unit), etc..., store them into variables and use those.
- You have a group leak inside the loop trigger when you're getting a random unit. You should set bj_wantDestroyGroup to true right before you get the random unit.
- The "Random unit in (group)" action in GUI is a load of baloney. You can simply just set the unit the variable to FirstOfGroup(udg_yourGroup)
- That 11.11 should be configurable somewhere.
That's all I guess.
IcemanBo: Too long as NeedsFix. Rejected.
23:22, 22nd Aug 2012
Magtheridon96:
Just a quick review:
- All speeds must be MUI and MPI, not just one.
- Instead of repeating function calls like (Owner of blabla), (Picked unit), (Triggering unit), etc..., store them into variables and use those.
- You have a group leak inside the loop trigger when you're getting a random unit. You should set bj_wantDestroyGroup to true right before you get the random unit.
- The "Random unit in (group)" action in GUI is a load of baloney. You can simply just set the unit the variable to FirstOfGroup(udg_yourGroup)
- That 11.11 should be configurable somewhere.
That's all I guess.