[Snippet] SkillBuild

[Almia]

library SkillBuild /* v1.3
*************************************************************************************
*
*    AI System Member
*
*    Allows AIs to automatically learn abilites
*
*************************************************************************************
*
*    */ uses /*
*
*    */ RegisterPlayerUnitEvent /*
*     - hiveworkshop.com/forums/jass-resources-412/snippet-registerplayerunitevent-203338/
*
*************************************************************************************
*
*    API
*
*    static method add takes integer heroId, integer spell, integer level returns nothing
*        - adds a spell to the hero's to-learn list.
*        - spells will be learned at "level"
*
*************************************************************************************
*
*    Credits
*
*        Magtheridon96 - RegisterPlayerUnitEvent
*
*************************************************************************************/
    private module SBInit
        private static method onInit takes nothing returns nothing
            call init()
        endmethod
    endmodule
    
    struct SkillBuild extends array
        private static hashtable ht
        private static unit u
        
        static method add takes integer heroId, integer spell, integer level returns nothing
            call SaveInteger(ht, heroId, level, spell)
        endmethod

        private static method learn takes nothing returns boolean
		    local integer spell
            set u = GetTriggerUnit()
            if GetPlayerController(GetTriggerPlayer()) == MAP_CONTROL_COMPUTER and IsUnitType(u, UNIT_TYPE_HERO)  then
			    set spell = LoadInteger(ht, GetUnitTypeId(u), GetUnitLevel(u)) 
			    if 0 != spell then
                    call SelectHeroSkill(u, spell)
				endif
            endif
            return false
        endmethod
        
        private static method init takes nothing returns nothing
            set ht = InitHashtable()
            call RegisterPlayerUnitEvent(EVENT_PLAYER_HERO_LEVEL, function SkillBuild.learn)
        endmethod
        
        implement SBInit
    endstruct
endlibrary

Demo:

struct Test
    private static method onInit takes nothing returns nothing
        local integer heroId = 'Hmkg'
        call SkillBuild.add(heroId, 'AHtc', 1)
        call SkillBuild.add(heroId, 'AHtc', 4)
        call SkillBuild.add(heroId, 'AHtc', 7)
    endmethod
endstruct

 

[Almia]

I haven't compiled this yet(my pc has no JNGP,but my other one which is damn far away has one)

 

[Magtheridon96]

Usage example/Unit test required.
(Should be pretty easy for this one)

 

[mckill2009]

- GetOwningPlayer(u) >> GetTriggerPlayer()
- IsUnitType(u) == UNIT_TYPE_HERO >>> IsUnitType(u, UNIT_TYPE_HERO)
- level is useless
- The SelectHeroSkill should pick randomly like >>> call SelectHeroSkill(u, LoadInteger(ht, GetUnitTypeId(u), GetRandomInt(1, max_skill)))

 

[Almia]

You kidding me?
How could I roll the skill level

Anyways, thanks mckill , though I won't be changing the level roll. Some maps wants to have a Skill build.

 

[WaterKnight]

I also like my hero builds with noob traps. If there is only one valid build, why giving the choice? Better make different sets for the same hero type and rolling one of it/assign one set to the specific hero. Additional chances can then be implemented from outside.

 

[Magtheridon96]

Learn is not a good struct name.

You'll know you have a good struct name when you can look at the Unit test without looking at the library and understand what it's doing.

Try SkillBuild or something like that.
It has to be expressive of the intent, purpose and function.

 

[_lycan]

Nice

 

[Almia]

Thanks Meg.
Updating for Struct Renaming and Compiling.

 

[Almia]

Updated. Renamed Struct.

 

[Magtheridon96]

Since the creation of an instance here is meaningless, how about simply:

call SkillBuild['Hmkg'].add('AHtc', 1)

(You'd just provide a static method operator [] that returns the argument)

Oh, and you might want to check if there's anything stored in the hashtable before you actually make a hero learn an ability

Also, you might want to update the library to have the same name as the struct, it's a convention :v

 

[Almia]

Ah thanks
How about I ignore that operator? My idea is quite bad well.

Meg,rename AI Learn to SkillBuild

 

[gorillabull]

so this will add an ability to the hero when he she levels up? well thats nice i guess but you should make this work for player heroes too also if say a hero is "loaded" into the game via a save load system then you should add a function that re adds the hero's abilities so i duno make a loop that sets the hero's lvl +1 i could use something like this also i think other people can too since one problem with loading heroes with new save load systems is that usually they wont have standard abilities preplaced on them in the object editor and save load systems dont have a function like that

 

[edo494]

dont use your own hashtable, use Bribe's Table, that's what it is made for, to only have 1 hashtable for entire map in vJass

you could make it work for each unit independantly not for unit type, that is only suggestion tho

 

[mckill2009]

There's really nothing wrong of using HT above Bribe's Table, but I must suggest to remove the RegisterPlayerUnitEvent and still hoping for Random selection of abilities...

 

[Magtheridon96]

Requirements aren't a bad thing

 

[mckill2009]

Yes, but he uses only 1 action for that, so Imo, better to have no requirements at all...

 

[Magtheridon96]

Anyone who uses that resource would use 1 action with it D:
(4 in the extreme case even)

 

[PurgeandFire]

It would be cool to support what WaterKnight said. It would give you a nice opportunity to expand on this system. IMO.

 

[Siegfird]

I dont know

How to use this jass

 

[edo494]

why are you using global unit variable instead of local one?

 

[Almia]

IDK why did I put that. Nvm.