Simple Yet Awesome Spellpack v1.1 by BetaGod

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Required changes

• Set the dummy's deat type to Can't raise, does not decay
• Focused Lightning Loop causes leaks
  • Set FL_StartPoint[FL_Times] = (Position of FL_Target[FL_Times])
• Rendezvous Loop has a location leak
• Quick Slash seems to be leaking Target point of ability being cast
  Quick Slash could be instant cast since it uses unit facing, and not angle or distance between points

Suggested changes

• Vulcanization could spam less special effects
• V_Targer location doesn't need to ne an array
• The caster does not get the credit from all kills done by Vulcanization since
  the dummies deal damage also
  The same applie for other spells
• Remove invul ability from the dummy, it has Locust
• The dummy unit gives lots of vision
• You could share "temp" variables between abilities
• Use dynamic indexing by Hanky
• Exorcism could display the floating text only for players that have vision over the location/unit
• Dark Blast Loop could be shortened by a lot if you used modulo operation when you check the interval time
• [Cluster Shock Loop]: Flying heights can't be negative and unit scales for x,y and z must be the same

 

[BeTaGod-]

v1.1 Changelog:

-Invulnerable ability removed from Dummy unit
-Reduced Dummy unit sight radius to 10 (for both day and night)
-Dummy unit death type changed to Can't raise, does not decay
-Reduced Dummy unit regenration rate to 0
-Fixed a leak in Focused Lightning Loop trigger
-Fixed a leak in Quick Slash Start trigger
-Reworked Rezdenvous triggers to include a Dummy unit in order to avoid possible location leaks
-Fixed Quick Slash ability to be instant
-Fixed Quick Slash tooltip to fit previous change
-V_TargetLocation Variable no longer content arrays (Caster should get the credit from all kills done by Vulcanization now)
-Fixed a typo error on Holy Grenade spell (For both tooltips AND triggers)

v1.0 Changelog:

-Public release


CREDITS:
-HolyNova.mdx by Champara Bros
-ShadeMissile.mdx by judash137
-TheHolyBomb.mdx by JetFangInferno

Also, seems like the format got kinda ugly if someone wants to re-organizate the hidden tags (assuming it is possible for one of you guys to do it) please feel free too! i am WAY TOO TIRED! haha hope you liked it.

 

[Adiktuz]

settings for constant things like the frozen blast's special effect model should be done in a general init trigger rather than every time the spell is run...

 

[Tank-Commander]

I would suggest using co-ordinates rather than moving units using the GUI function - it has a tendency to cause heavy lag when it's being used a lot.

Also, why exactly are the loops every 0.1 seconds as opposed to 0.03? (Just curious)

 

[Bribe]

settings for constant things like the frozen blast's special effect model should be done in a general init trigger rather than every time the spell is run...

In real life it's not going to make one bit of difference where efficiency is concerned. Now doing something like creating handles each time, is a wasteful thing if it's not necessary, but setting simple variables (string, real, integer, boolean) a half dozen redundant times per cast is not going to make anyone lose sleep (as those operations would be performed within 1/2^31 seconds by your average processor).

Especially since when you have those things in your basic-cast trigger, you don't have to have a third trigger per spell that needs to be carried over.

 

[BeTaGod-]

PLEASE give me some spell related comments people. I alredy know my coding sucks, so if you point that out (in any way), at least give me some advice on how to improve it.

I would suggest using co-ordinates rather than moving units using the GUI function - it has a tendency to cause heavy lag when it's being used a lot.

Also, why exactly are the loops every 0.1 seconds as opposed to 0.03? (Just curious)

Dunno about the 0.1 and 0.03 loops. I didn't made them all in the very same day so i created the in very different ways, i think. BTW, most of your resources help me a LOT to improve, so thanks!

 

[Jay the Editor]

You shouldn't use the "Unit - A Unit Begins casting an ability". Maker told me that one can get away without costing any mana by using the spell then hit stop.

It does use cooldown and mana with "Starts the effect". It doesn't use them with "Begins casting..." and ordering stop.

Besides, it isn't necessary to create a point variable for each spell. You can use a un-arrayed point variable over and over again for the other spells, a temp variable.

 

[Ender]

you could convert this

• For each (Integer A) from 1 to 12, do (Actions)
  • Loop - Actions
    • Set V_TargetLocation[V] = (V_Location[V] offset by (V_Aoe[V] / Count) towards ((Real((Integer A))) x 30.00) degrees)
    • Special Effect - Create a special effect at V_TargetLocation[V] using V_IgnitionSFX
    • Set V_Ignition[V] = (Last created special effect)
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 100.00 of V_TargetLocation[V] matching (((((Matching unit) is A structure) Equal to False) and (((Matching unit) is dead) Equal to False)) and (((Matching unit) belongs to an enemy of V_Player[V]) Equal to True))) and do (Actions)
      • Loop - Actions
        • Special Effect - Create a special effect attached to the chest of (Picked unit) using Abilities\Weapons\FireBallMissile\FireBallMissile.mdl
        • Special Effect - Destroy (Last created special effect)
        • Unit - Cause V_Caster[V] to damage (Picked unit), dealing V_IgnitionDamage[V] damage of attack type Spells and damage type Normal
      • Special Effect - Destroy V_Ignition[V]
      • Custom script: call RemoveLocation(udg_V_TargetLocation[udg_V])
      • .....
      • .....
      • ....
      • ....
      • ..

into this

• For each (Integer Count from 1 to 4, do (Actions)
  • Loop - Actions
    • For each (Integer A) from 1 to 12, do (Actions)
      • Loop - Actions
        • Set udg_TempLoc = (V_Location[V] offset by (V_Aoe[V] / 4.00) towards ((Real((Integer A))) x 30.00) degrees)
        • Special Effect - Create a special effect at udg_TempLoc using V_IgnitionSFX
        • Special Effect - Destroy (Last created special effect)
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 100.00 of udg_TempLoc matching (((((Matching unit) is A structure) Equal to False) and (((Matching unit) is dead) Equal to False)) and (((Matching unit) belongs to an enemy of V_Player[V]) Equal to True))) and do (Actions)
          • Loop - Actions
            • Special Effect - Create a special effect attached to the chest of (Picked unit) using Abilities\Weapons\FireBallMissile\FireBallMissile.mdl
            • Special Effect - Destroy (Last created special effect)
            • Unit - Cause V_Caster[V] to damage (Picked unit), dealing V_IgnitionDamage[V] damage of attack type Spells and damage type Normal
      • Custom script: call RemoveLocation(udg_TempLoc)

to make the code shorter and easier to read, doesn't improve effiecency or any thing, but it makes changing things a lot easier, you only have to change it in one place rather then 4.

I advise you follow Tank Commanders advice on co-ordinates, it would improve all of your spells, while it will take a while to implement do to the shear number of spell it would make some of them lagg less on my very ancient and decrepit comp.

also, congrats on the shear number of spells.

p.s.

Holy Granade

.......

Holy Granade Loop

should be spelled Grenade

 

[BeTaGod-]

You shouldn't use the "Unit - A Unit Begins casting an ability". Maker told me that one can get away without costing any mana by using the spell then hit stop.


Besides, it isn't necessary to create a point variable for each spell. You can use a un-arrayed point variable over and over again for the other spells, a temp variable.

You are right, i will get this done next week, maybe Thanks for your help!

Oh and about the variables, i was going to do that, but then i though that if someone exports just one spell of the pack, MAYBE he/she will rather have the spell's own variables for organization issues. Dunno about that, i may keep it as it is for now.

you could convert this

• For each (Integer A) from 1 to 12, do (Actions)
  • Loop - Actions
    • Set V_TargetLocation[V] = (V_Location[V] offset by (V_Aoe[V] / Count) towards ((Real((Integer A))) x 30.00) degrees)
    • Special Effect - Create a special effect at V_TargetLocation[V] using V_IgnitionSFX
    • Set V_Ignition[V] = (Last created special effect)
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 100.00 of V_TargetLocation[V] matching (((((Matching unit) is A structure) Equal to False) and (((Matching unit) is dead) Equal to False)) and (((Matching unit) belongs to an enemy of V_Player[V]) Equal to True))) and do (Actions)
      • Loop - Actions
        • Special Effect - Create a special effect attached to the chest of (Picked unit) using Abilities\Weapons\FireBallMissile\FireBallMissile.mdl
        • Special Effect - Destroy (Last created special effect)
        • Unit - Cause V_Caster[V] to damage (Picked unit), dealing V_IgnitionDamage[V] damage of attack type Spells and damage type Normal
      • Special Effect - Destroy V_Ignition[V]
      • Custom script: call RemoveLocation(udg_V_TargetLocation[udg_V])
      • .....
      • .....
      • ....
      • ....
      • ..

into this

• For each (Integer Count from 1 to 4, do (Actions)
  • Loop - Actions
    • For each (Integer A) from 1 to 12, do (Actions)
      • Loop - Actions
        • Set udg_TempLoc = (V_Location[V] offset by (V_Aoe[V] / 4.00) towards ((Real((Integer A))) x 30.00) degrees)
        • Special Effect - Create a special effect at udg_TempLoc using V_IgnitionSFX
        • Special Effect - Destroy (Last created special effect)
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 100.00 of udg_TempLoc matching (((((Matching unit) is A structure) Equal to False) and (((Matching unit) is dead) Equal to False)) and (((Matching unit) belongs to an enemy of V_Player[V]) Equal to True))) and do (Actions)
          • Loop - Actions
            • Special Effect - Create a special effect attached to the chest of (Picked unit) using Abilities\Weapons\FireBallMissile\FireBallMissile.mdl
            • Special Effect - Destroy (Last created special effect)
            • Unit - Cause V_Caster[V] to damage (Picked unit), dealing V_IgnitionDamage[V] damage of attack type Spells and damage type Normal
      • Custom script: call RemoveLocation(udg_TempLoc)

to make the code shorter and easier to read, doesn't improve effiecency or any thing, but it makes changing things a lot easier, you only have to change it in one place rather then 4.

I advise you follow Tank Commanders advice on co-ordinates, it would improve all of your spells, while it will take a while to implement do to the shear number of spell it would make some of them lagg less on my very ancient and decrepit comp.

also, congrats on the shear number of spells.

p.s. should be spelled Grenade

Yup! I will apply that in next week's patch Thanks for the Grenade (am i doing it right?) correction!

Oh about the co-ordinates, i really on't know how the fuck does that work Still a newbie! But well, i will definetly try to learn about that soon.

 

[Ender]

adding an init trigger for all your spells would be nice to make everything more configurable.

also for a bunch of Gui spells that use coordinates look at TankCommander's resources.

p.s yes you spelled grenade right ; )

 

[BeTaGod-]

adding an init trigger for all your spells would be nice to make everything more configurable.

also for a bunch of Gui spells that use coordinates look at TankCommander's resources.

p.s yes you spelled grenade right ; )

Awesome! Thanks again!

EDIT: BTW, i wonder if this is going to be reviewed anytime soon..