Shockwave/Carrion Swarm System v1.1

[Diegoit]

Pls give us a better explaination. Is this a triggered Shockwave only or it can use other features? Like Pick every unit in a range of the projectile actual location.

 

[xyzier_24]

Pls give us a better explaination. Is this a triggered Shockwave only or it can use other features? Like Pick every unit in a range of the projectile actual location.

I believe that this already says it.

that can do more than what normal Shockwaves can't.

Sorry, I'm bad at explaining. But you can check this instead:

Hidden

• Shockwave
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shockwave (Trigger)
  • Actions
    • Set SW_Max = (SW_Max + 1)
    • Set SW_Caster[SW_Max] = (Triggering unit)
    • Set SW_Point[0] = (Position of (Triggering unit))
    • Set SW_Point[1] = (Target point of ability being cast)
    • Set SW_Lvl[SW_Max] = (Level of (Ability being cast) for (Triggering unit))
    • Set SW_WaveEffect[SW_Max] = Abilities\Spells\Orc\Shockwave\ShockwaveMissile.mdl
    • -------- The effect of the Shockwave that will move. --------
    • Set SW_WaveEffectEnd[SW_Max] = Abilities\Spells\Other\Doom\DoomDeath.mdl
    • -------- The effect of the Shockwave after reaching its max distance. --------
    • Set SW_AllowFXLoop[SW_Max] = False
    • -------- A countinuous sfx. If this is True, you will need to declare SW_WaveEffectL to use this. --------
    • Set SW_AllowExtraEffectLoop[SW_Max] = False
    • -------- An additional effect (ex. Polymorph, Slow, Stun). If this is True, you will need to declare SW_EffectId to use this. --------
    • Set SW_TargetAir[SW_Max] = False
    • -------- Determines if the shockwave will affect flying units. --------
    • Set SW_UnitStructure[SW_Max] = True
    • -------- Determines if the shockwave will affect structures. --------
    • Set SW_UnitGround[SW_Max] = True
    • -------- Determines if the shockwave will affect ground units. --------
    • Set SW_ContinousDamage[SW_Max] = True
    • -------- Determines if the damage is continuous, meaning that as long as an affected unit is in the area of the trigger, it will keep on taking damage. --------
    • Set SW_Damage[1] = 10.00
    • Set SW_Damage[2] = 20.00
    • Set SW_Damage[3] = 30.00
    • -------- Amount of damage dealt. --------
    • Set SW_DamageFinal[1] = 200.00
    • Set SW_DamageFinal[2] = 300.00
    • Set SW_DamageFinal[3] = 400.00
    • -------- Amount of damage dealt after reaching its max distance. --------
    • Set SW_AreaInitial[1] = 125.00
    • Set SW_AreaInitial[2] = 125.00
    • Set SW_AreaInitial[3] = 125.00
    • -------- Initial area of effect. --------
    • Set SW_AreaFinal[1] = 125.00
    • Set SW_AreaFinal[2] = 125.00
    • Set SW_AreaFinal[3] = 125.00
    • -------- Final area of the effect. --------
    • Set SW_Speed[1] = 1050.00
    • Set SW_Speed[2] = 1050.00
    • Set SW_Speed[3] = 1050.00
    • -------- Speed of the shockwave. --------
    • Set SW_Distance[1] = 400.00
    • Set SW_Distance[2] = 1000.00
    • Set SW_Distance[3] = 1800.00
    • -------- Max distance of the shockwave. --------
    • Trigger - Run Shockwave_Cast <gen> (ignoring conditions)

 

[_Guhun_]

You should allow the user to configure whether the shockwave will affect only enemy units or if it will affect enemy units and ground units. It could also be nice to allow the user to create shockwaves that heal, instead of only dealing damage (if they specify a negative damage value, turn it into healing). Also, the system is missing a core functionaly of the default shockwaves, which allow the user to specify the maximum damage dealt by the shockwave (the sum of the damage dealt to each target).

Instead only having the extra effect as a spell, you should allow a user to specify a trigger that will run when a unit is damaged. This will allow them to do a lot more (they could do it with events, but that would require a lot of extra object data).

You should provide a better explanation of what "ExtraEffectId" is, many people that use GUI may not have experience with Order Id's, only strings. Additionally, it would be a good bonus to link a list of order Ids. Here is a good one: Order Ids

If you provide a more detailed description, since GUI comments are pretty annoying to read, people should be more inclined to check out your submission. Adding "System" or "Engine" to your title should also give readers more information about what the submission actually is before even reading it.

Anyway, this is a pretty neat system with good functionality. The logic seems pretty concise and I did't notice any leaks. Rating as-is will be 3/5, but with updates (especially allowing a custom trigger) I would gladly raise the score.

 

[xyzier_24]

You should allow the user to configure whether the shockwave will affect only enemy units or if it will affect enemy units and ground units. It could also be nice to allow the user to create shockwaves that heal, instead of only dealing damage (if they specify a negative damage value, turn it into healing). Also, the system is missing a core functionality of the default shockwaves, which allow the user to specify the maximum damage dealt by the shockwave (the sum of the damage dealt to each target).

EDIT: Okay, I've added more option on selecting which units will get affected. I didn't add max. damage dealt because I don't feel like adding it, but it can still be made by using a custom trigger now.

Instead only having the extra effect as a spell, you should allow a user to specify a trigger that will run when a unit is damaged. This will allow them to do a lot more (they could do it with events, but that would require a lot of extra object data).

Use the extra effect, and create an trigger when the dummy casted the ability in the extra effect? But I think this is a bad idea. Okay let me see what I can do.
EDIT: Done.

 

[MyPad]

This is what I got from the Cast and Loop trigger...

Notes

• You may need to add some more documentation clarifying the purpose of the cast and loop triggers.
• The point variable SW_Point might fail on recursion (e.g., a spell-effect occuring on a spell-effect event), though this situation is extremely rare. (e.g. a dummy casting a shockwave spell on the start of shockwave, messy stuff.)

Status:

• Awaiting Update

 

[xyzier_24]

This is what I got from the Cast and Loop trigger...

Notes

• You may need to add some more documentation clarifying the purpose of the cast and loop triggers.
• To streamline variable declaration, you should outsource it to a function.
  
• The point variable SW_Point might fail on recursion (e.g., a spell-effect occuring on a spell-effect event), though this situation is extremely rare. (e.g. a dummy casting a shockwave spell on the start of shockwave, messy stuff.)

Seeing the examples derived from the main Cast trigger, I would prefer that you write a function that eases out on variable declaration.

The following part of a trigger..

• Set SW_Max = (SW_Max + 1)
• Set SW_Caster[SW_Max] = (Triggering unit)
• Set SW_Point[0] = (Position of (Triggering unit))
• Set SW_Point[1] = (Target point of ability being cast)
• Set SW_Lvl[SW_Max] = (Level of (Ability being cast) for (Triggering unit))
• Set SW_WaveEffect[SW_Max] = Abilities\Spells\Undead\CarrionSwarm\CarrionSwarmMissile.mdl
• Set SW_WaveEffectEnd[SW_Max] = <Empty String>
• Set SW_LoopingSfx[SW_Max] = False
• Set SW_ExtraEffectTargetCheck[SW_Max] = True
• Set SW_ExtraEffectTarget[SW_Max] = Carrion Swarm Heal <gen>
• Set SW_AffectAlly[SW_Max] = True
• Set SW_AffectEnemy[SW_Max] = True
• Set SW_AffectAir[SW_Max] = True
• Set SW_AffectGround[SW_Max] = True
• Set SW_AffectStructure[SW_Max] = False
• Set SW_OneInstance[SW_Max] = True
• Set SW_AttackType[SW_Max] = Spells
• Set SW_DamageType[SW_Max] = Magic
• Set SW_Attachment = origin
• Set SW_Damage[1] = 100.00
• Set SW_Damage[2] = 200.00
• Set SW_Damage[3] = 300.00
• Set SW_AreaInitial[1] = 100.00
• Set SW_AreaInitial[2] = 100.00
• Set SW_AreaInitial[3] = 100.00
• Set SW_AreaFinal[1] = 500.00
• Set SW_AreaFinal[2] = 500.00
• Set SW_AreaFinal[3] = 500.00
• Set SW_Speed[1] = 1100.00
• Set SW_Speed[2] = 1100.00
• Set SW_Speed[3] = 1100.00
• Set SW_Distance[1] = 800.00
• Set SW_Distance[2] = 800.00
• Set SW_Distance[3] = 800.00

Can be shortened to something like this...

• Custom Script: call SW_create()
• Set SW_WaveEffect[SW_Max] = Abilities\Spells\Undead\CarrionSwarm\CarrionSwarmMissile.mdl
• Set SW_WaveEffectEnd[SW_Max] = <Empty String>
• Set SW_LoopingSfx[SW_Max] = False
• Set SW_ExtraEffectTargetCheck[SW_Max] = True
• Set SW_ExtraEffectTarget[SW_Max] = Carrion Swarm Heal <gen>
• Custom Script: call SW_setBehavior(udg_SW_Max, true, true, true, true, false, true)
• Set SW_AttackType[SW_Max] = Spells
• Set SW_DamageType[SW_Max] = Magic
• Set SW_Attachment = origin
• Trigger - Run Shockwave Cast <gen> (ignoring conditions)

The functions can be stated like these (Suggest placing it on Map Header) (You can CnP)
Note: An additional variable SW_Point_Counter was added

// You automate the instance creation here
function SW_create takes nothing returns integer
    local integer this = udg_SW_Max + 1
    set udg_SW_Max = this + 1
    set udg_SW_Point_Counter = udg_S_Point_Counter + 2

    set udg_SW_Caster[this] = GetTriggerUnit()
    set udg_SW_Point[udg_SW_Point_Counter - 2] = GetUnitLoc(udg_SW_Caster[udg_SW_Max])
    set udg_SW_Point[udg_SW_Point_Counter - 1] = GetSpellTargetLoc()
    set udg_SW_Lvl[this] = GetUnitAbilityLevel(udg_SW_Caster[udg_SW_Max], GetSpellAbilityId())
    return this
endfunction

function SW_setBehavior takes integer this, boolean affectAllies, boolean affectEnemy, boolean affectAir, boolean affectGround, boolean affectStructure, boolean once returns nothing
    set udg_SW_AffectAlly[this] = affectAllies
    set udg_SW_AffectEnemy[this] = affectEnemy
    set udg_SW_AffectAir[this] = affectAir
    set udg_SW_AffectGround[this] = affectGround
    set udg_SW_AffectStructure[this] = affectStructure
    set udg_SW_OneInstance[this] = once
endfunction

Changing the Cast trigger slightly at the end...

• Comment: ---------- -------------------- Removes the
• Custom script: call RemoveLocation(udg_SW_Point[udg_SW_Point_Counter - 1])
• Custom script: call RemoveLocation(udg_SW_Point[udg_SW_Point_Counter - 2])
• Set SW_Point_Counter = (SW_Point_Counter - 2)

This can possibly simplify the examples you've already given from the map script towards something less taxing in the long run.
Other than that, I see no reason for this not to be approved.

Thank you for pointing this out. I did what you said, but it seems like it didn't work for me. I don't know where did I go wrong on doing it.

 

[MyPad]

Did you change the Cast trigger to the one typed above?

 

[xyzier_24]

Yes. I did exactly what you said. Kinda odd, because it seems so flawless. Maybe I did something wrong.

 

[MyPad]

I'd like to see it...

 

[xyzier_24]

This is the map where I tested it.

 

[xyzier_24]

You may need to add some more documentation clarifying the purpose of the cast and loop triggers.

Updated to clarify the purpose of those two triggers. Is it okay to make a decision whether to approve this now?

 

[Deathkok]

thanks for spells,.. good job.

 

[MyPad]

Updated to clarify the purpose of those two triggers. Is it okay to make a decision whether to approve this now?

As far as the trigger goes, this is already approval-worthy. The only issue right now is the dummy issuing a stop order every time it is moved (which I can then infer that SetUnitPosition is being used instead of SetUnitX and SetUnitY).

Approved