RehSinP's MUI Spellpack v2.4

[Moderator]

12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

You have if/then/elses with no condition.
The level of ability for unit conditions are redundant in Sparkfire skin and Passive heal. Remove them.
Picking units matching Unit is an ally of player not equal to true causes neutrals to be picked and damaged. Is that what you want?
Remember to flush child hashtables.
In FAPRD, don't do group is empty check every 0.03 seconds. Only when a unit is removed from the group.

 

[Magtheridon96]

Could you post the triggers?
No one cares if they're long, because posting them is part of the "Nerd Protocol"

 

[RehSinP]

Could you post the triggers?
No one cares if they're long, because posting them is part of the "Nerd Protocol"

Yessir I was working on that I didn't know how to at first XD

 

[Magtheridon96]

You should post each trigger in [trigger][/trigger] tags

A few tips:
- Always use Triggering Unit
- Don't repeat stuff like (Last Created Unit) and (TriggeringUnit), etc..
Instead, you should store them in variables and then use them (only if you're going to repeat (Triggering Unit), (Last Created Unit), etc..)

WC3 code is unbelievably slow.
According to my tests, it's over 1000 times slower than C++
C++ can do 330000000 iterations in a second (very simple ones) (On a good PC)
Jass/GUI can do between 80000 and 100000 iterations in a second (Unfortunately, it stops when you're doing too many...)

That's why efficiency is the most important thing and you need to focus on it when you're coding in WC3

(Sorry for the offtopic )

 

[RehSinP]

Haha I'm new to this. Trying to figure out all the stuff.. <-- fail :O

 

[Magtheridon96]

You should type [trigger] then paste the trigger code, then write [/trigger]
It's not that complicated

Refer to this link for more tags:
http://www.hiveworkshop.com/forums/misc.php?do=bbcode

 

[RehSinP]

Yeah I got it now hahaha XD also Maker found a leak in my sparkfire skin and I fixed it I think.

 

[Magtheridon96]

Ok something is wrong
Those triggers you posted don't show "Events" - "Conditions" - "Actions"
D:

Also, don't use (Integer A), instead, use Integer Variable (Less buggy and more efficient)

In your "Sparkfire" trigger, move the last line outside the if/then/else block.
That way, the location is always destroyed

 

[RehSinP]

>.<'.... Ok I'll fix that soon... And alright will do.

 

[maddeem]

I've spotted a few leaks, looks pretty good. I'll go over it more in a sec.
Nvm, looks good. You seem to be improvin alot reh. =p
I recognized one though. lol (Actually 2)

 

[RehSinP]

What is it mad?

 

[maddeem]

Offtopic

Nuke, n Forceful Arrow
=p

 

[RehSinP]

Had to add them from our map lol I made Nuke you made the arrow

 

[maddeem]

Not like I'm askin for credits or anything lol, I nevar do =p
Should really try to go back on topic or ppl r gunna get mad =s
I still have yet to test ur spells. But I will right now.

Found quite a fatal flaw. Perhaps you should create the hashtable that you're saving into O.O

 

[RehSinP]

I fixed the nuke and arrow

 

[maddeem]

Post teh fixes =p (Triggers)

 

[RehSinP]

They are fixed lol XD

 

[Magtheridon96]

Don't repeat (Triggering Unit) like that in your Nuke trigger (Use a variable)

Also, don't use (Integer A), use (Integer Variable)

 

[Ketsuno Anson]

Hide the triggers please,it's really long

 

[RehSinP]

I hid the triggers. I didn't know how to at first haha XD

 

[mckill2009]

Nuke spell review;

- Owner of (Triggering unit)) >>> Triggering Player
- (Key (Last created unit)) >>> store in an integer variable
- (Key (Picked unit)) >>> store in an integer variable
- you should add a condition if the caster still alive as well