Re'ammin's Child v1.0.1 Extended

[KitsuneTailsPrower]

Notes to moderators:
1. I can't link the original author for some reason.
2. I have no idea what language this is so I checked the 2 boxes that I thought it might be.

 

[Antares]

Notes to moderators:
1. I can't link the original author for some reason.

@Ralle

2. I have no idea what language this is so I checked the 2 boxes that I thought it might be.

This is Zinc. Basically vJASS with different syntax. Just put it as vJASS.

 

[Pyrogasm]

Pretty sure JC Helas is banned, that’s why you can’t link him.

 

[Ralle]

If you click Add anyway, it will work regardless of auto complete.

 

[Antares]

A dummy recycling system is certainly a welcome addition to the original spell. I'm not so sure about the filtering system, though. This just makes setting up the unit filter functions slightly easier at the cost of a greatly reduced performance and requiring the user to install another 700 line library. This is probably what one would describe as "dependency hell".

You're not using RegisterPlayerUnitEvent in your main script, but only in your Test map script. Please separate the required resources from the test map resources clearly.

/*- Determine the maximum height of each ball may post -*/

There is some weird grammar going on here. Consider rephrasing this one.

constant string CASTER_FX = "Abilities\\Spells\\Orc\\Purge\\PurgeBuffTarget.mdl"

The Purge buff effect does not work well with destroying it immediately and it won't play the sound or animation.

An option for a lightning impact effect would be nice. Kinda disappointing right now that there is no lightning sound because of that.

The spell you based this edit on is... ok. We've seen this type of spell a lot. Your additions do make it better, though, with a lot more config options to customize it.

 

[KitsuneTailsPrower]

A dummy recycling system is certainly a welcome addition to the original spell. I'm not so sure about the filtering system, though. This just makes setting up the unit filter functions slightly easier at the cost of a greatly reduced performance and requiring the user to install another 700 line library. This is probably what one would describe as "dependency hell".

You're not using RegisterPlayerUnitEvent in your main script, but only in your Test map script. Please separate the required resources from the test map resources clearly.

Noted.

/*- Determine the maximum height of each ball may post -*/

There is some weird grammar going on here. Consider rephrasing this one.

This is probably left over from the original spell's documentation. JC Heles is most likely not a native English speaker. Of course I don't think any less of him for it. I'll update it.

constant string CASTER_FX = "Abilities\\Spells\\Orc\\Purge\\PurgeBuffTarget.mdl"

The Purge buff effect does not work well with destroying it immediately and it won't play the sound or animation.

An option for a lightning impact effect would be nice. Kinda disappointing right now that there is no lightning sound because of that.

Noted.

The spell you based this edit on is... ok. We've seen this type of spell a lot. Your additions do make it better, though, with a lot more config options to customize it.

 

[KitsuneTailsPrower]

Updated based on feedback:
-Improved some comments
-Separated libraries into required and optional
-Removed caster_fx since the balls start so small that you can't see it anyway
-Added Lightning Strike FX

 

[Antares]

Issues were addressed.

Approved