1. Updated Resource Submission Rules: All model & skin resource submissions must now include an in-game screenshot. This is to help speed up the moderation process and to show how the model and/or texture looks like from the in-game camera.
    Dismiss Notice
  2. DID YOU KNOW - That you can unlock new rank icons by posting on the forums or winning contests? Click here to customize your rank or read our User Rank Policy to see a list of ranks that you can unlock. Have you won a contest and still haven't received your rank award? Then please contact the administration.
    Dismiss Notice
  3. Weave light to take you to your highest hopes - the 6th Special Effect Contest is here!
    Dismiss Notice
  4. Lead your forces to battle in the 15th Techtree Contest. The call is yours, commander!
    Dismiss Notice
  5. Check out the Staff job openings thread.
    Dismiss Notice
Dismiss Notice
60,000 passwords have been reset on July 8, 2019. If you cannot login, read this.

[vJASS] [PSA] MyBoard (bowser499) minor bug

Discussion in 'Triggers & Scripts' started by Cokemonkey11, Jun 19, 2019.

  1. Cokemonkey11

    Cokemonkey11

    Wurst Reviewer

    Joined:
    May 9, 2006
    Messages:
    3,266
    Resources:
    18
    Tools:
    1
    Maps:
    5
    Spells:
    3
    Tutorials:
    2
    JASS:
    7
    Resources:
    18
    Hey y'all,

    Just debugged a silly problem in my map, which I was ready to chalk up to 1.31.x problemos.

    Myboard (link: [PROTOTYPE] myBoard) has some code that looks like this:

    private constant integer MAX_ROW_COUNT = 100
    private constant integer MAX_COLUMN_COUNT = 30

    ...

    method setLocalValue takes player whichPlayer, integer col, integer row, string newValue returns nothing
    local integer arrIndex = MAX_COLUMN_COUNT*col + row

    if GetLocalPlayer() == whichPlayer then
    set .curValue[arrIndex] = newValue
    endif

    call MultiboardSetItemValue(.brdItem[arrIndex],.curValue[arrIndex])
    endmethod

    You can trivially see that if you set MAX_COLUMN_COUNT to 2, and MAX_ROW_COUNT to 3, then cells (2, 1) and (1, 2) resolve to the same element.

    Indeed, the provided default script with 100 and 30 is bugged.

    Solution: always use a max colcount that is at least 1 greater than your max rowcount.

    THBAPSA