Production Queue Overlay

[Wrda]

Unexpected behavior: making a building and then stop repairing it doesn't stop the progress bar of the frame (human race). Having multiple peasants focus on building the same structure isn't reflected on progress bar.

I think there should be a more clear distinction between what's belongs to the system and what is the example. Since the function InitProductionDataRepository is the example, it should be in a seperate script/trigger.
ProductionDataRepository, ProductionOverlayData and ProductionOverlayEvent's scripts have some variables which are acting as constant variables. I suggest to change them to the common practice (all capitalized and underscores).

StartUnitProductionAction, StartStructureProductionAction, StartUpgradeProductionAction, StartResearchProductionAction, StartReviveProductionAction, InitProductionOverlayEvent and InitProductionOverlayUi functions are missing nulling of some local variables, such as unit, player and trigger.
Personally, I would cache function calls that are called at least 3 times per the main function, even if it's not in a periodic loop.

A cool idea in its nature, could also be used for "build to fight" maps.
Since there's no game-breaking bugs, it's

Approved

 

[Daratrix]

Oh, the Human Repair/Powerbuild is indeed a massive oversight, I'll try to find a solution to that. I'll push an update to address the other comments in the coming days. Thank you for the thorough review!

 

[Bribe]

Oh, the Human Repair/Powerbuild is indeed a massive oversight, I'll try to find a solution to that. I'll push an update to address the other comments in the coming days. Thank you for the thorough review!

I think that was one of Nestharus's "unsolved mysteries" in his "resources that have yet to be coded" thread. Not much that can be done about that. Need API from Blizzard for true accuracy.

 

[alienii]

Tell me, which version of the map editor do you use? None of them opens. Please give a link.

 

[Daratrix]

Tell me, which version of the map editor do you use? None of them opens. Please give a link.

This system was created with the Reforged Editor (previous patch). However, it uses vJASS, so you will have to install JASSHelper (or use the TESH launcher, although is is a bit outdated)

 

[Pyrogasm]

JASSHelper is packaged with all World Editor installations post-reforged; it's not something you have to manually install. It does have to be manually enabled in many maps because it's off by default.

A map using vJASS does not prevent itself from being opened by an editor without vJASS support; it just can't be saved.

 

[Daratrix]

With the latest patch dramatically improving the observer/replay UI, I think this system becomes redundant. Is it possible to graveyard it @Wrda ?

 

[Wrda]

Well, there's always the option that it can be useful for an earlier patch, but that's up to you.
I don't really have a graveyard option, but rather a "restricted". It still doesn't really look appropriate for this case. Either way, I'll message the staff about your case, just so there aren't any doubts.

 

[Wrda]

Changed to Useful as this has become deprecated for the latest patch (1.35) by user request.