Problems enforcing desired condition

[DiggetyBo]

Hey everyone,

I'm still slaving away at Anachron's Inventory system, just trying to make it suitable for my map's play style. Right now I want to place a restriction on the type of items that the system handles. I want it to ignore power-up class items.

I'm positive this is the right area of code to restrict that, because I already set a unit classification condition where structures also don't use the system (I have a shop). So, altogether, no structures or power up item's will trigger any action, that is my aim.

While the structure condition was successful, the power up item class condition is not, Anachron's system keeps trying to run after I acquire a power up item.

Is there something wrong with my code?

This is in the trigger: CIEvents, if any of you happen to have this system

library CIEvents
endlibrary

module CIEvents
    public method pick takes CustomItem ci returns boolean
        if .checkPickup(ci) and IsUnitType(.carrier,UNIT_TYPE_STRUCTURE)== false and IsItemPowerup(ci.getHandle()) == false then
            call ci.pick(.carrier)
            call .addItem(ci)
            return true
        endif
        
        return false
    endmethod

if the code is ok, what else could be the problem?

I want to make an invulnerability effect where I create a power up item and instantly trigger the hero to consume it (invulnerability potion), resulting in temporary invulnerability. Of course if Anachron's system takes it into it's custom inventory, the trigger will not work (because his system destroys the real item, and creates a destructible in full screen inventory -- which is awesome, but why is it sooo hard to modify)

thanks for reading!

 

[Doomlord]

Powerup items are items that are used automatically on acquisition (runes, glyphs, etc), which is obviously not the case for potions and therefore the IsPowerUp func returns a false. You could attach a boolean to those items' id to 'mark' them and check it in the condition. That is how I would do it.

 

[DiggetyBo]

Cool, thanks for the tip, I'll let you know if I figure out how to limit by item id. +rep

EDIT: Umm.. I'm just not adept enough, setting conditions in Vjass is so strange to me, the closest I got was:

    public method pick takes CustomItem ci returns boolean
        if .checkPickup(ci) and IsUnitType(.carrier,UNIT_TYPE_STRUCTURE)== false and GetItemType(ci.getHandle()) == false then

It's not even complete, I don't know where to put the item's raw code "I00G" or make it a negative or not equal to function.

the TESH feature helped a little, but if someone can spell it out for me, I'd really appreciate it.

 

[DiggetyBo]

Bump it up!! All the way!

 

[deathismyfriend]

just put and GetItemTypeId( item) == 'I00G'
also make sure u use the asci key ' not the string key "

 

[DiggetyBo]

ok, but how to I make it a boolean though? Would it be like

GetItemTypeID(ci.getHandle()) == "I00G" == false

So I want the following functions to run only if the item isnt "I00G"

 

[deathismyfriend]

no just like this

GetItemTypeID(ci.getHandle()) == 'I00G'

if its equal it returns true. u dont need true or false in jass. also pay attention to the different keys. this ( ' ) is ascii value ( an integer). this ( " ) is a string key.
u can change this

and IsUnitType(.carrier,UNIT_TYPE_STRUCTURE)== false

to this and its more efficient this way.

and not IsUnitType(.carrier,UNIT_TYPE_STRUCTURE)

 

[DiggetyBo]

Oh ok, I'll try that out, thanks a bunch! +rep

 

[deathismyfriend]

np and when trying to check if the condition is true just do it like this

 if condition1 then

 

[DiggetyBo]

Sorry I should have included more script. When I try that way it gives me compile errors. Cannot convert integer to boolean and cannot compare variables of different primitives.

public method pick takes CustomItem ci returns boolean
        if .checkPickup(ci) and IsUnitType(.carrier,UNIT_TYPE_STRUCTURE)== false and not GetItemTypeId(ci.getHandle()) == 'I00G' then
            call ci.pick(.carrier)

I think I have to keep the boolean nature of the function. but how do I make it so that the item condition restricts correctly? All I want to do is make sure the function doesn't do anything if the item is 'I00G'

thanks again!

 

[msongyboi]

EDIT: sorry nm, late at night my mistake

I'm gonna dl the system and look at it rite nao

public method pick takes CustomItem ci returns boolean
    if .checkPickup(ci) then
        if GetItemTypeId(ci.getHandle()) == 'I00G' and IsUnitType(.carrier,UNIT_TYPE_STRUCTURE) == false then   
        else
            call ci.pick(.carrier)
            // Whatever else it, this method should do.
            return true
        endif
    endif

    return false    
endmethod

 

[DiggetyBo]

Ok, the whole structure boolean thing was my addon, its in the CI Events Trigger, towards the top of the trigger in its original state

 

[msongyboi]

Ok, the whole structure boolean thing was my addon, its in the CI Events Trigger, towards the top of the trigger in its original state

yeah I saw, all it does it check if the item is legit whether or not you already have it - it's a safety kind of thing

but that should do it, if the itemtype of the item handle is 'I00G' and .carrier is not a structure(I'm not sure if you need the second boolean or not) the it won't do anything and eventually return false. Else, it'll do whatever the method should originally be doing and return true.

 

[DiggetyBo]

cool, but I want it so that it proceeds only if its NOT 'I00G', how would that change things?

 

[msongyboi]

Well, it won't do anything - if the first condition is met. Unless you call more functions/natives outside the if statement. So it should work as you want it to.

Sorry I should have included more script. When I try that way it gives me compile errors. Cannot convert integer to boolean and cannot compare variables of different primitives.

Btw, if Condition1 is a boolean expression (function that returns true/false) this is probably because you did Condition1 instead of Condition1().

something like this will work

function Condition1 takes item i, unit u returns boolean
    return GetItemTypeId(i) == 'I00G' and IsUnitType(u, UNIT_TYPE_STRUCTURE) == false
endfunction

public method pick takes CustomItem ci returns boolean
    if .checkPickup(ci) then
        if Condition1(ci.getHandle(), .carrier) then   
        else
            call ci.pick(.carrier)
            // Whatever else it, this method should do.
            return true
        endif
    endif

    return false    
endmethod

 

[DiggetyBo]

Ok cool, now I understand. I'll try it out in a bit, thanks a lot. +rep

EDIT: got some errors I've never seen before... Error function inside struct? and Error struct declaration.

Here is what I tried:

module CIEvents
function Condition1 takes item i, unit u returns boolean
    return GetItemTypeId(i) == 'I00G' and IsUnitType(u, UNIT_TYPE_STRUCTURE) == false
endfunction    
    public method pick takes CustomItem ci returns boolean
        if .checkPickup(ci)
            call ci.pick(.carrier)
            call .addItem(ci)
            return true
        endif
        
        return false
    endmethod

I'm soooo cllose now, sooo close.

Any ideas?

 

[DiggetyBo]

I got an idea... BUMP!