pls help with this...

[talshiboli]

ok,so this has been driving me crazy..
I tried to create a trigger that takes control over all enemy units around my char
when it uses a certain skill (based off channel)
but it got tricky when I tried to exclude Heroes,Magic immune units,Summoned units,Mechanical units and strctures...
to me at least the trigger looks like it should work but nothing happens...
im not that great with triggers so im hoping you guys/gals could provide some insight

 

[talshiboli]

 

[Eleandor]

There is no "triggering player". Try "owner of triggering unit" instead.
Also note that you're leaking a lot of stuff.

 

[deathismyfriend]

first here is how to properly post triggers. http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/
plz dont double post instead hit the edit button on ur last post.

next just damage the unit in the then block. in the else block leave it empty. change triggering player to owner of triggering unit. also never use casting unit use triggering unit instead
u leak a location and anything u use twice or more store into a temp variable and use that. it increases speed and efficiency. take a look at my tutorial things a GUIer should know. it will help u a lot. and look at things that leak tutorial.

edit: eleandor beat me to it lol

edit 2: dont damage units sry i meant to say change ownership in this portion

 

[Spartipilo]

1- Use

• tags to paste triggers text.
• 2- Inside the "Then" actions, directly change the ownership of the Picked Unit.
• 3- No need for the ConfessedToBe Group so far.
• 4- "Else" actions can be empty. No need for anythignt there.
• 5- The last action can be removed too.
• 6- After "Set ConDorConfessor" add this custom script
• [trigger]
• t
• Custom script: set bj_wantDestroyGroup = true

@Eleandor: "Triggering Player" stands for "Owner of Triggering Unit" on any Unit Generic Event.

 

[deathismyfriend]

@Eleandor: "Triggering Player" stands for "Owner of Triggering Unit" on any Unit Generic Event.

this is true but with spells triggering player returns null.

 

[Spartipilo]

call TriggerRegisterAnyUnitEventBJ( gg_trg_Melee_Initialization, EVENT_PLAYER_UNIT_SPELL_EFFECT ) 
// turns into 
call TriggerRegisterPlayerUnitEvent(gg_trg_Melee_Initialization, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT , null)

No, player doesn't returns null spell triggering.

 

[deathismyfriend]

this is wrong.

• ((Matching unit) is A structure) Equal to False
• ((Matching unit) is A Hero) Equal to False
• ((Matching unit) is Mechanical) Equal to False
• ((Matching unit) is Magic Immune) Equal to False
• ((Matching unit) is Summoned) Equal to False

none of us said to switch that.
put picked unit back in there. i said anything u use twice or more store into a temp variable and use that.
remove the stuff in the then block and just change the owner of picked unit

@spartipilo
u are right i was thinking of something else. sry about tht

 

[talshiboli]

does it matter when I set the variable? if so where should I place it in this case?

 

[deathismyfriend]

post the triggers and ill show u the spot.

 

[talshiboli]

it works now but still

if you could show me the spot regardless thatd be great

• start
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Con Dar
  • Actions
    • Set ConDorConfessor = (Triggering unit)
    • Unit Group - Pick every unit in (Units within 400.00 of (Position of (Triggering unit)) matching ((Owner of (Matching unit)) Not equal to (Owner of (Triggering unit)))) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) is A structure) Equal to False
            • ((Picked unit) is A Hero) Equal to False
            • ((Picked unit) is Mechanical) Equal to False
            • ((Picked unit) is Magic Immune) Equal to False
            • ((Picked unit) is Summoned) Equal to False
          • Then - Actions
            • Unit - Change ownership of (Picked unit) to (Owner of (Triggering unit)) and Change color
          • Else - Actions

 

[deathismyfriend]

will update in 3 minutes

here u go. i cleaned the leaks and made it more efficient. Also u can check out my tutorial Things a GUIer Should Know it will help a lot with triggering.
capitals for the letters does matter. so u can just use it the exact way i do and u will be fine

• start
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Con Dar
  • Actions
    • Set tempUnit2 = (Triggering unit)
    • Set tempPlayer = (Owner of tempUnit2)
    • Set tempPoint = (Position of tempUnit2)
    • Set tempGroup = (Units within 400.00 of tempPoint matching ((Owner of (Matching unit)) Not equal to tempPlayer))
    • Unit Group - Pick every unit in tempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Set tempUnit = (Picked unit)
            • (tempUnit is A structure) Equal to False
            • (tempUnit is A Hero) Equal to False
            • (tempUnit is Mechanical) Equal to False
            • (tempUnit is Magic Immune) Equal to False
            • (tempUnit is Summoned) Equal to False
          • Then - Actions
            • Unit - Change ownership of tempUnit to tempPlayer and Change color
          • Else - Actions
    • Custom script: call RemoveLocation( udg_tempPoint)
    • Custom script: call DestroyGroup( udg_tempGroup)

 

[talshiboli]

thx a lot for the help

 

[deathismyfriend]

Np and gl

 

[DivineLight]

looks like we all recommended deathismyfriend's Tutorials