PlayMusic() causing lag

[Chaosy]

I recently made a minor system which is supposed to play 'battle music' when entering combat. However it lags once I enter combat.

• unit enters combat
  • Events
    • Game - CS_combat_event becomes Equal to 1.00
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (CS_entering_unit is in CS_group) Equal to False
      • Then - Actions
        • Custom script: if isNormalMusic(currentMusic) then
        • Custom script: set currentMusic = battleMusic[GetRandomInt(1, battleCount)]
        • Custom script: call PlayMusic(currentMusic)
        • Custom script: endif
      • Else - Actions

If I remove the PlayMusic(currentMusic) it doesn't lag. Or freeze rather. The game freeze for like one second.

 

[LordDz]

Sounds like a precaching error, play the music once for 0.01 seconds at the map init?

 

[Chaosy]

You mean I should play it at map init for testing or what? sorry for not getting it.

 

[LordDz]

You should play it once so that the game loads it up.
Like when playing special effects at loadup once, so that you don't get the freeze when they're played for the first time.

"To provide a smooth loading of assets for a typical game session, it is important that the engine does as much work as possible to load those assets before the session begins. By doing this, the player's experience is not disturbed by interruptions as the engine tries to load assets in the middle of a session, often causing "hitching", lag or delays in rendering. With precaching, the assets are already loaded and are immediately ready for use. To do this, entities must declare and precache the assets they intend to use before the session starts. There are multiple utility functions in place to achieve this. "
https://developer.valvesoftware.com/wiki/Precaching_Assets

 

[Chaosy]

I see.. I didn't know about a load time. So I can do the following? (at init)

call PlayMusic(someMusic)
call PlayMusic(someOtherMusic)
//and so on

 

[LordDz]

I guess.

 

[Chaosy]

Hm, doesn't seem to work..

                //inside the onInit method
	        call PlayMusic(battleMusic[1])
		call PlayMusic(battleMusic[2])
		call PlayMusic(battleMusic[3])
		//---------------------------------
		call PlayMusic(normalMusic[1])
		call PlayMusic(normalMusic[2])
		call PlayMusic(normalMusic[3])
		call PlayMusic(normalMusic[4])
		call PlayMusic(normalMusic[5])

still freezes. Should I provide the test map?

 

[LordDz]

Sure. I don't promise anything but I can take a look.

 

[Chaosy]

Right. Here it is:

 

[LordDz]

If you play them as a sound and not as music, it doesn't lag (I tested with the GUI version), so you would need to save the music into a sound variable that you can play and stop when playing your music.

It's not the Dmg detection, as I tested with replacing it with player chat commands.

I don't know why it works with sound and not with the music type.

 

[Ceday]

You must play your sound at 0.01 game time or 0.00 game time, not at map initialization.

Also using sound instead of music helps.

 

[Zwiebelchen]

Just stop the current music instantly (not after fadeout!) before playing the new music. This will get rid of the lag. This issue has nothing to do with preloading, it's just a bug.