[Solved] Player is enemy or vice versa (Wurst)

[inspicous]

Is the following check necessary so that the killer receives bounty if either they are enemies with killed or vice versa?

If I'm not mistaken, a player may be an enemy towards another without the reverse being true, and hence this check. Just wanted to confirm whether I'm doing a useless check or not, thanks.

function unit.checkBountyValidFor(player killer) returns bool
    let killed = this.getOwner()
    return (killed != killer) and
           (killed.isEnemyOf(killer) or killer.isEnemyOf(killed))

Usage example:

public function unit.bountyOnHeroFor (player killer)
    if this.checkBountyValidFor(killer)
       let lvl = GetHeroLevel(this) * 2 + 20
       killer.earnGoldFrom(this, GetRandomInt(0, 200) + lvl * lvl )

 

[Chaosy]

Correct. Player 1 can treat 2 as an enemy while 2 treats 1 as an ally

 

[inspicous]

Thanks. I have checked it works like that in Warcraft but was for some reason unsure does it carry over to jass and wurst. Thanks for confirming