Place Farm v0.1.1.3

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Place Farm v0.1.1.3 | Reviewed by Maker | 15th May 2013

NEEDS FIX

There are leaks and the system is too simple and not configurable Things that leak Spell Submission Rules

[tr]

 

[MajorKaza]

For attachements only

Sorry for gif auality but I have broken keyboard.

 

[Tank-Commander]

• Farm
  • Events
    • Unit - A unit Finishes construction
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Farm
  • Actions
    • Set TMP_Point = ((Position of (Triggering unit)) offset by (150.00, -150.00))
    • Environment - Change terrain type at TMP_Point to Village - Crops using variation -1 in an area of size 2 and shape Square
    • Unit - Create 1 Corn (Farm) for Neutral Extra at (TMP_Point offset by (50.00, 0.00)) facing Default building facing degrees
    • Unit - Create 1 Vilager (Male) for Neutral Passive at (TMP_Point offset by (-50.00, 0.00)) facing Default building facing degrees
    • Animation - Play (Last created unit)'s stand work animation
    • Set TMP_Point = ((Position of (Triggering unit)) offset by (-50.00, 50.00))
    • Environment - Change terrain type at TMP_Point to Village - Short Grass using variation -1 in an area of size 1 and shape Square

Think it's a bit too basic, not exactly a system, nor a spell, it's not configurable, it's not got any particular function, just a bit of aesthetics

also, you leak a location

 

[deathismyfriend]

he leaks a couple locations lol. once this spell is ran a second time or TMP_Point is used in another trigger it leaks. I believe this also leaks (TMP_Point offset by (50.00, 0.00)).
u create a new location when using that.

i agree w u tho tank-commander its too basic

 

[MajorKaza]

Yeah, it is basic as mentioned above. However, I couldn't find something similar, so I made my own. BTW I am useing TMP_* variables as 'set before use' objects.

I had more randomized version but I've lost it ;(

 

[Ralle]

They're right that there are leaks. I just detected four using my prototype leak finder:

Leaked location object allocated on line 107
Leaked location object allocated on line 838:blizzard.j
Leaked location object allocated on line 838:blizzard.j
Leaked location object allocated on line 112

The following lines leak:

set udg_TMP_Point = OffsetLocation(GetUnitLoc(GetTriggerUnit()), 150.00, -150.00)
call CreateNUnitsAtLoc( 1, 'e003', Player(bj_PLAYER_NEUTRAL_EXTRA), OffsetLocation(udg_TMP_Point, 50.00, 0), bj_UNIT_FACING )
call CreateNUnitsAtLoc( 1, 'n005', Player(PLAYER_NEUTRAL_PASSIVE), OffsetLocation(udg_TMP_Point, -50.00, 0), bj_UNIT_FACING )
set udg_TMP_Point = OffsetLocation(GetUnitLoc(GetTriggerUnit()), -50.00, 50.00)

The calls to OffsetLocation return a new Location object.

 

[deathismyfriend]

u probably didnt find it anywere because its just to simple to make.

@Ralle
thats a neat detection for leaks lol