Ping Minimap and Message problem

[Insk]

I have a problem with a trigger (or whatever you call them). Its supposed to create a unit at a random point in a region (this far it works as intended) and ping the mini map at the spawn location. Its also supposed to send a message to all players, but it does none of the later two. Here's the code

function Trig_greg_enter_Actions takes nothing returns nothing
    local integer number
    local real pingx
    local real pingy
    local location spawngreg = Location(GetRandomReal(-3008.00, -2240.00), GetRandomReal(-1632.00, 288.00))
    call CreateUnitAtLoc(Player(12), 'h004', spawngreg, GetRandomReal(0.00, 360.00))    
    loop
        call DisplayTimedTextFromPlayer(Player(number), 0, 0, 6.00, "Greg has spawned in the dining area")
        set number = number + 1
        exitwhen number == 12
    endloop
    set pingx = GetLocationX(spawngreg)
    set pingy = GetLocationY(spawngreg)
    call PingMinimapEx(pingx, pingy, 5.00, 255, 255, 255, true)
    set spawngreg = null    
endfunction

//===========================================================================
function InitTrig_greg_enter takes nothing returns nothing
    set gg_trg_greg_enter = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( gg_trg_greg_enter, 10.00 )
    call TriggerAddAction( gg_trg_greg_enter, function Trig_greg_enter_Actions )
endfunction

I guess its just some simple noob mistake, but I would be glad if someone could tell me what's wrong.

 

[Pharaoh_]

Why don't you use:

call DisplayTextToForce( bj_FORCE_ALL_PLAYERS, "Greg has spawned in the dining area" )

By the way, it should be

local integer number = 0

 

[Insk]

Thanks, it worked Though isn't it best to keep away from bjs? I'm not very good at Jass so I might be wrong...

 

[Pharaoh_]

Well, true, but that 'rule' is most likely applied to function names, e.g. AddSpecialEffectTarget() vs. AddSpecialEffectTargetUnitBJ().
Sometimes, bj_'s are preferred, for example bj_mapInitialPlayableArea is supposed to work faster than GetPlayableMapRect().

 

[Insk]

Aha, thanks once more