Pick every unit not working

[out-of-name]

Hello,

can you help me fixing my triggers?
What i want to do is, when hero learns a spell, it should damage a random enemy unit at the heroe very 2,5 seconds.

• Learn WizardsGift
  • Events
    • Unit - A unit Learns a skill
  • Conditions
    • (Learned Hero Skill) Equal to Wizards Gift /// Grandmage
  • Actions
    • Set VariableSet Grandmage = (Triggering unit)
    • Trigger - Add to Wizards Gift <gen> the event (Time - Every 2.50 seconds of game time)
    • Trigger - Turn off (This trigger)

seconds trigger:

• Wizards Gift
  • Events
  • Conditions
    • (Grandmage is alive) Equal to Wahr
  • Actions
    • Set VariableSet WizardsGiftLVL = (Level of Wizards Gift /// Grandmage for Grandmage)
    • Set VariableSet Grandmage = Grandmage2
    • Set VariableSet WizardsGiftGroup = (Units within 700.00 of (Position of Grandmage) matching (((Picked unit) belongs to an enemy of (Owner of Grandmage).) Equal to Wahr).)
    • Unit - Create 1 DAMAGEDUMMY for (Owner of Grandmage) at (Center of (Playable map area)) facing Default building facing degrees
    • Unit Group - Pick every unit in (Random 1 units from WizardsGiftGroup) and do (Actions)
      • Loop - Actions
        • Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Undead\DarkRitual\DarkRitualCaster.mdl
        • Unit - Cause (Last created unit) to damage (Picked unit), dealing (100.00 x (Real(WizardsGiftLVL))) damage of attack type Hero and damage type Normal
        • Unit - Cause Grandmage2 to damage (Picked unit), dealing ((Real((Intelligence of Grandmage (Include bonuses)))) x (0.10 x (Real(WizardsGiftLVL)))) damage of attack type Chaos and damage type Normal
    • Unit - Remove (Last created unit) from the game
    • Unit Group - Remove all units from WizardsGiftGroup.
    • Custom script: call DestroyGroup(udg_WizardsGiftGroup)
    • Set VariableSet Grandmage2 = No unit

The question why 2 different units damage the picked unit? Because one has a chance to trigger another spell when damage is taken by this unit.
And the spell must not be MUI since there can only be that one unit with that spell.

 

[Dr Super Good]

For the matching filter you need to use "matching unit" and not "picked unit". In such context "picked unit" is null which will likely cause the matching filters to all fail causing the resulting unit group to be empty.

Be aware that you are leaking locations, unit groups and even special effects.

 

[out-of-name]

Hey,

thank you for the answer. Can you explain me how do I cause leaking locations... and how can I avoid them?

Since corona I am ging to teach myself the wc3 Editor.

 

[Cheshire]

(Grandmage is alive) Equal to Wahr

what is wahr? that should be true there...

Hey,

thank you for the answer. Can you explain me how do I cause leaking locations... and how can I avoid them?

Since corona I am ging to teach myself the wc3 Editor.

In general leaking is when you create objects like points or unit groups, and then lose the way to access them (=handle). they add up and clogg up memory behind the scenes and can make your map lag and cause other problems.

Memory Leaks

C0Memory leaks For a quick lookup on most important actions, read Things That Leak. Introduction Object Leaks Reference Leaks Miscellaneous Conclusion C1Introduction If your computer's memory keeps occupied with stuff you already lost access to, it's called memory leak. It slows down the...

www.hiveworkshop.com

Things That Leak

For a structured tutorial on the matter, read this. Hello guys! Credit to: Wolverabid, PurplePoot, Silvenon, Paskovich I want to make a list of things that leak and ways to fix them. Dynamic Unit Groups This trigger will instantly destroy dynamically generated unit groups. Trigger...

www.hiveworkshop.com