[Solved] Pick all unit of type : how to work around it to avoid leaks ?

[Goblioc]

Hello,

I'm trying to reduce as much as i can the leaks on my map, but i can't find a way to NOT use "pick all units of type" in certain situations. And, as i saw, this action leaks whatever you do.
Is there a way to work around that ?
I don't do JASS, so if you do, explain to me like i'm five.
Maybe there is some shenanigans to achieve the same goal by a different way, but i don't know it.

thank you !

 

[Ziadoma]

Things That Leak

For a structured tutorial on the matter, read this. Hello guys! Credit to: Wolverabid, PurplePoot, Silvenon, Paskovich I want to make a list of things that leak and ways to fix them. Dynamic Unit Groups This trigger will instantly destroy dynamically generated unit groups. Trigger...

www.hiveworkshop.com

Check the first leak. The pick all units of type creates a unit group that leaks. You can destory it using a custom script before:

set bj_wantDestroyGroup = true

Or you can set it to a variable and then delete the unit group afterwards.

 

[Goblioc]

Things That Leak

For a structured tutorial on the matter, read this. Hello guys! Credit to: Wolverabid, PurplePoot, Silvenon, Paskovich I want to make a list of things that leak and ways to fix them. Dynamic Unit Groups This trigger will instantly destroy dynamically generated unit groups. Trigger...

www.hiveworkshop.com

Check the first leak. The pick all units of type creates a unit group that leaks. You can destory it using a custom script before:

set bj_wantDestroyGroup = true

Or you can set it to a variable and then delete the unit group afterwards.

I don't understand the "set bj_wantDestroyGroup = true" > what is his effect ?

Does it mean that i can do something like :
- Pick all units of type and add it to "UnitGrp"
- Take all units in "UnitGrp" and do actions
actions
- custom script: call DestroyGroup(udg_UnitGrp)

?

But as i use Pick every unit of type, i should leak anyways , right ?
Even in the post you sent there is a part : "Never use these functions"

 

[Ziadoma]

Does it mean that i can do something like :
- Pick all units of type and add it to "UnitGrp"
- Take all units in "UnitGrp" and do actions
actions
- custom script: call DestroyGroup(udg_UnitGrp)

?

But as i use Pick every unit of type, i should leak anyways , right ?
Even in the post you sent there is a part : "Never use these functions"

Not exactly. You want to set it to a variable when you call: All units of type.

 

[Goblioc]

Explain with more details please, i do not understand.

what "set bj_wantDestroyGroup = true" does ?

You want to set it to a variable when you call: All units of type.

I want to set what to a variable?
Let's say i have a UnitGroup variable called "UnitGroup"
What do i do then ?
Why can't i do :
- Pick all units of type and add it to "UnitGroup"
Then destroy the group ?

 

[Ziadoma]

Explain with more details please, i do not understand.

what "set bj_wantDestroyGroup = true" does ?


I want to set what to a variable?
Let's say i have a UnitGroup variable called "UnitGroup"
What do i do then ?
Why can't i do :
- Pick all units of type and add it to "UnitGroup"
Then destroy the group ?

Oh that is what you do.

 

[Goblioc]

Oh that is what you do.

And what is "set bj_wantDestroyGroup = true" ?

And why "Pick all units of type" is blacklisted ?
Is doing :
Set "UnitGroupVar" = units of type owned by Player 1
less leaks ?

 

[Ziadoma]

• 
  Set GroupVar = Pick every unit in (Playable Map Area)
• 
  Unit Group - Pick every unit in GroupVar and do (Unit - Hide (Picked unit))
• 
  Custom script: call DestroyGroup(udg_GroupVar)

 

[Goblioc]

Thanks a lot !

 

[Nichilus]

A small note from me on why the following always leaks and should not be used:

• Set VariableSet group = (Units of type Footman)

If you translate this GUI action into jass, you will see this:

set udg_group = GetUnitsOfTypeIdAll('hfoo')

If you look up GetUnitsOfTypeIdAll function for example here Doc - GetUnitsOfTypeIdAll, you will see the function's implementation and explanation why it leaks:

Leaks handle result: In Jass you must set local variables that hold agents (or any child type) to null at the end of functions to avoid reference counter leaks.
Leaks handle g: In Jass you must set local variables that hold agents (or any child type) to null at the end of functions to avoid reference counter leaks.

So if you need to pick all units of certain unit-type, you should use something like this instead:

• Set VariableSet group = (Units in (Playable map area) matching ((Unit-type of (Matching unit)) Equal to Footman))

 

[Pyrogasm]

And what is "set bj_wantDestroyGroup = true" ?

It's a bonus feature built into many of the blizzard group-related functions. Many of them check this boolean variable, and if it's true they will automatically destroy the group at the end of their execution. Effectively it allows you to tell the function to clean up after itself, but not all group functions check it and the first such function to encounter the variable will set it back to false and then destroy its group.

 

[Goblioc]

It's a bonus feature built into many of the blizzard group-related functions. Many of them check this boolean variable, and if it's true they will automatically destroy the group at the end of their execution. Effectively it allows you to tell the function to clean up after itself, but not all group functions check it and the first such function to encounter the variable will set it back to false and then destroy its group.

thanks for the explainations, but i think i don't understand it enough to use it properly without causing unwanted side effects. Let's stick with the "Set UnitGrpVar" then destroy it with custom scripts