[JASS] OrderId2String() returns null after loading a saved game

[PiesOfNorth]

This is an issue pertaining to my campaign/mod that uses a modified blizzard.j

What seems to be happening is that any functions that had a unit order event registered to them, be it a point order, unit order, or 'no target' order will not work, but only after loading a saved game. they will work just fine otherwise.

What's also interesting is this issue is not present in the current release of the zerg campaign, which has all its core functionality in gui triggers as opposed to this upcoming release which does everything in blizzard.j.

I've attached a a test map and a stripped-down version of the required War3Mod.mpq (no sounds/portraits so that the download is relatively small). Like the zerg campaign, it requires version 1.28 of war3.

The map is simple, it just has some units you can test the problem with. You can verify that functions which don't rely on checking the unit's orderstring work just fine after loading a saved-game. Specifically, you can morph larva. But you can not set the hatchery's rallies or open the drone build menus (which check the orderstring)

Update - Solved (kind of)

It seems I mis-diagnosed the issue.
What's actually happening is that OrderId2String() will return null after loading a saved-game, but String2OrderId() is always safe to use.

I don't know if this is a bug specific to 1.28 or not, but switching to checking orderIds rather than the result of OrderId2String() fixed the issue for me.

 

[Cokemonkey11]

Can you add a @Bug note to GitHub.com/lep/jassdoc ?

 

[Troll-Brain]

this is nothing new, the bug has never been fixed, i even made a function to "exploit" that bug : [Repo] JASS H4xx
2012, probably since the start of wc3 even.

 

[Cokemonkey11]

Same issue as UnitId2String by Cokemonkey11 · Pull Request #39 · lep/jassdoc

See https://www.hiveworkshop.com/threads/orderid2string-returns-null-after-loading-a-saved-game.336367/#post-3507470

github.com