Order Tracking Submission

[Rigborn]

Code

library OrderTrack initializer init


public function actions takes nothing returns nothing
   local integer i
   local string name
   local string order2str
   local string obj
   set i = GetIssuedOrderId()
   set name = GetUnitName(GetTriggerUnit())
   set order2str = OrderId2String(i)
   set obj = GetObjectName(i)
   call BJDebugMsg("Name:"+" "+name+"  "+"Order id:"+" "+I2S(i)+"  "+"Order2String:"+" "+order2str+"  "+"Object Name:"+" "+obj)
endfunction

public function init takes nothing returns nothing
   local trigger t
   set t = CreateTrigger()
   call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER)
   call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER)
   call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_UNIT_ORDER)
   call TriggerAddAction(t, function actions)
   set t = null
endfunction
endlibrary

 

[IcemanBo]

Yeh, works fine. : )

Would optically look a tiny bit better if only value is printed if it exists (object name / order2string), but for sure solved!

 

[Rigborn]

Yeh, works fine. : )

Would optically look a tiny bit better if only value is printed if it exists (object name / order2string), but for sure solved!

I was trying to find a solution as I am not so familiar string syntax. Turns out, uninitialized strings are not null or that's what I think so

 

[IcemanBo]

That's right. It's possible to get the object name, and then comparing the result. When there is a wrong/invalid object id, then the returning result would be always the same default string which can be checked.

 

[Rigborn]

Code

library OrderTrack initializer init


public function actions takes nothing returns nothing
    local integer i
    local string name
    local string order2str
    local string obj
    set i = GetIssuedOrderId()
    set name = GetUnitName(GetTriggerUnit())
    set order2str = OrderId2String(i)
    set obj = GetObjectName(i)
    if StringLength(obj) > 0 then
       call BJDebugMsg("Name:"+" "+name+"  "+"Order id:"+" "+I2S(i)+"  "+"Order2String:"+" "+order2str+"  "+"Object Name:"+" "+obj)       
   else
       call BJDebugMsg("Name:"+" "+name+"  "+"Order id:"+" "+I2S(i)+"  "+"Order2String:"+" "+order2str)
   endif
endfunction

public function init takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER)
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER)
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_UNIT_ORDER)
    call TriggerAddAction(t, function actions)
    set t = null
endfunction
endlibrary

Here is the final one as you suggested.

 

[IcemanBo]

Have you looked at the output? ;p The if statement with string condition does not look right to me.

 

[Rigborn]

Have you looked at the output? ;p The if statement with string condition does not look right to me.

Oh I forgot about the order2string thingie.

Code

library OrderTrack initializer init


public function actions takes nothing returns nothing
    local integer i
    local string name
    local string order2str
    local string obj
    set i = GetIssuedOrderId()
    set name = GetUnitName(GetTriggerUnit())
    set order2str = OrderId2String(i)
    set obj = GetObjectName(i)
   if StringLength(order2str) > 0 then
       if StringLength(obj) > 0 then
          call BJDebugMsg("Name:"+" "+name+"  "+"Order id:"+" "+I2S(i)+"  "+"Order2String:"+" "+order2str+"  "+"Object Name:"+" "+obj)
       elseif StringLength(obj) == 0 then
           call BJDebugMsg("Name:"+" "+name+"  "+"Order id:"+" "+I2S(i)+"  "+"Order2String:"+" "+order2str)
       endif
   endif
   if StringLength(order2str) == 0 then
       if StringLength(obj) > 0 then
           call BJDebugMsg("Name:"+" "+name+"  "+"Order id:"+" "+I2S(i)+"  "+"Object Name:"+" "+obj)
       elseif StringLength(obj) == 0 then
           call BJDebugMsg("Name:"+" "+name+"  "+"Order id:"+" "+I2S(i))
       endif
   endif
endfunction

public function init takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER)
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER)
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_UNIT_ORDER)
    call TriggerAddAction(t, function actions)
    set t = null
endfunction
endlibrary

 

[IcemanBo]

I meant that the ObjectName of an invalid object does not return null/empty but "Default string", so its length is > 0, that's why I asked if it was tested. ;p Anyways, it's fine

edit: nothing very serious, but I just remembered that with using

function OrderId2StringBJ takes integer orderId returns string

instead of pure

constant native OrderId2String takes integer orderId returns string

one could also catch train orders with it.

 

[Pyrogasm]

I was the one who told him to use > 0. I had no idea it actually returned "Default string" rather than "" for an unknown object.

 

[IcemanBo]

This is the interesting about this function. One might use it to find out if an orderId has an equivalent in the object editor, for example if order was done for training units etc, like I needed here, in private function TrainOrder takes nothing returns boolean.