[Solved] Not Skipping Problem

[Blazing_Legion]

Using the action Skip Remaining actions in my trigger i find that it carries on with the rest of the functions after i used this. And yes the condition is being met as the text is displayed. Can someone tell me what is wrong.

• Choose Hero
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Choose Hero
  • Actions
    • Set Temp_Player = (Triggering player)
    • Set Player_Number = (Player number of Temp_Player)
    • Set Chosen_Hero[Player_Number] = Hero[Hero_Pick_Number[Player_Number]]
    • Set Heroes = (Units in Healing Area <gen> matching (((Matching unit) is A Hero) Equal to True))
    • Set Single_Player = (All players matching (Temp_Player Equal to (Matching player)))
    • Unit Group - Pick every unit in Heroes and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Picked unit)) Equal to Chosen_Hero[Player_Number]
          • Then - Actions
            • Game - Display to Single_Player the text: This hero has alrea...
            • Custom script: call DestroyGroup(udg_Heroes)
            • Custom script: call DestroyForce(udg_Single_Player)
            • Skip remaining actions
          • Else - Actions
    • Countdown Timer - Start Confirm_Timer[Player_Number] as a One-shot timer that will expire in 5.00 seconds
    • Unit - Add Confirm to (Triggering unit)
    • Custom script: call DestroyGroup(udg_Heroes)
    • Custom script: call DestroyForce(udg_Single_Player)

 

[WaterKnight]

Group-loops are outsourced. The actions in them take place in another thread (each unit gets one).

 

[Starquizer]

Group-loops are outsourced. The actions in them take place in another thread (each unit gets one).

WHAT !!! WC3 creates a thread for every unit, I thought it is only one thread per every pick units in ....

so if I have 30 units in 3 groups that would create 30*3 thread, not 3 thread. Right ?

 

[WaterKnight]

Yes, but it's cheap enough that ForGroup (this method) was claimed to be faster than a FirstOfGroup-remove-loop:

loop
    set u = FirstOfGroup(g)

    exitwhen (u == null)

    call GroupRemoveUnit(g)

    //do Actions with u
endloop

which does not open a new thread. Might not be comparable to trigger threads and the like.

 

[Starquizer]

Yes, but it's cheap enough that ForGroup (this method) was claimed to be faster than a FirstOfGroup-remove-loop:

loop
    set u = FirstOfGroup(g)

    exitwhen (u == null)

    call GroupRemoveUnit(g)

    //do Actions with u
endloop

which does not open a new thread. Might not be comparable to trigger threads and the like.

Yes I know about FirstOfGroup but I never know that fact until you mentioned that, thanks. I assume that WC3 creates thread for every destructible, isn't it ?

 

[WaterKnight]

Counts for all "pick every object in objectgroup and do", yes.

 

[Blazing_Legion]

thanks for the loop thing using that i have solved the problem

 

[Orion Somtaw]

may have solved the problem but have you considered moving the remaining triggers that need to be skipped to an if then else multiple function trigger where else is your trigger and if conditions met you stop there? i did that with a spawn unit when attacked trigger to make sure 5 units didnt spawn cause it was attacked 4 additional times