[vJASS] Not running function to give spell

[khamarr3524]

I've tried many different spell ID's and none have worked so far and I'm curious as to what could be wrong with my scripting that would cause this to happen. Using Debug messages I was able to determine that the trigger is working as intended, but a block in the coding for the struct isn't working. I can't find it, anyone have any ideas?

vJass code

struct Jump extends array
    private static integer spell = 'Aroc'
    private static rect area = gg_rct_GiveSpell
    
    private static method GiveSpell takes nothing returns nothing
        local unit u = GetEnumUnit()
        local location loc = Location(GetRectCenterX(gg_rct_ResendSpell),GetRectCenterY(gg_rct_ResendSpell))
        call UnitAddAbility(u, spell)
        call SetUnitPositionLoc(u, loc)
        set loc = null
        set u = null
    endmethod
    
    private static method CheckUnit takes nothing returns nothing
        local group g = CreateGroup()
        call GroupEnumUnitsInRect(g, area, null)
        call ForGroup(g, function thistype.GiveSpell)
        call DestroyGroup(g)
        set g = null
    endmethod
    
    static method Main takes nothing returns nothing
        call .CheckUnit()
    endmethod
endstruct

Jass Trigger Creation

function CheckUnitCond takes unit u returns boolean
    local integer typeUnit = 'hfoo'
    local region r = CreateRegion()
    call RegionAddRect(r, gg_rct_GiveSpell)
    if GetUnitTypeId(u) == typeUnit and IsUnitInRegion(r, u) == true then
        return true
    else
        return false
    endif
endfunction

function DoSpellGive takes nothing returns nothing
local unit u = GetEnumUnit()
   if CheckUnitCond(u) == true then
        call Jump.Main()
    endif
    set u = null
endfunction

function GiveSpell takes nothing returns nothing
    local group g = CreateGroup()
    call GroupEnumUnitsInRect(g, gg_rct_GiveSpell, null)
    call ForGroup(g, function DoSpellGive)
    call DestroyGroup(g)
    set g = null
endfunction
function InitTrig_Run_Jump takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEvent(t, 1., true)
    call TriggerAddAction(t, function GiveSpell)
    set t = null
endfunction

 

[Arhowk]

Your signature is kinda my response to this

 

[khamarr3524]

Basically when a unit enters the region, if the unit is == footman it gives the unit the spell I specify, and move the unit to the region specified.

 

[Arhowk]

call TriggerRegisterTimerEvent(t, 1., true)

thus the trigger will ONLY run at 1 second game time and not when a unti enters region...

 

[khamarr3524]

That's not the issue. The jass line call TriggerRegisterTimerEvent(t, 1., true) takes three arguments. The first is trigger whichTrigger, real timeout, and boolean periodic. Therefore, my code line will apply the timer event to the local trigger t, which will time out every 1. seconds, and repeat true.

The BJ known as TriggerRegisterTimerEventPeriodic will call the following code.

function TriggerRegisterTimerEventPeriodic takes trigger trig, real timeout returns event
    return TriggerRegisterTimerEvent(trig, timeout, true)
endfunction

Which does exactly what I did, only I used the proper native with "true" to declare periodic, just like this function.

 

[Arhowk]

Wouldn't it be easier to register a unit enters region event?

 

[khamarr3524]

That's not really the concern at the moment. I'm sure when I get it to work I'll look for more optimum ways to operate the function. But unfortunately the problem lies in the struct. I don't know what it is though. I'll resume my debugging.

 

[khamarr3524]

The error is occurring from the Give Spell method. Everything works up until I call ForGroup(g, function GiveSpell). It seems to be skipping this function. Should I do a loop system for every unit in group. Or should this entire system be redone to something else?

 

[Arhowk]

Test something like this (Its from a tutorial about leak checking)

globals
    // values to carry to the DoThings function
    real AmountToHeal
endglobals
function DoThings takes nothing returns boolean
                                      /*nothing becomes boolean*/

    call SetWidgetLife(GetFilterUnit(), GetWidgetLife(GetFilterUnit()) + AmountToHeal
                     /*GetEnumUnit() becomes GetFilterUnit()*/
    
    return false
  /*return false appears here*/
endfunction

function Trig_Untitled_Trigger_001_Actions takes nothing returns nothing
    // Store values before the enum instead
    set AmountToHeal = 200.0
    // Note the next line.
    call GroupEnumUnitsInRect(GROUP, bj_mapInitialPlayableArea, Filter(function DoThings))
    // The end.
endfunction

 

[khamarr3524]

That not only doesn't address my problem, but is entirely irrelevant. Currently the problem stands at: The code call ForGroup(g, function GiveSpell) is not firing properly. I'll review some tutorials and some other scripts, but If anyone has some useful feedback as to why the ForGroup wouldn't work in this case please tell me.

 

[SirNikolas]

//! zinc
library Jump {
    constant integer SPELL_ID = 'Aroc';
    constant integer UNIT_ID = 'hfoo';
    //! textmacro Jump__Rect
        gg_rct_GiveSpell
    //! endtextmacro
    constant group G = CreateGroup();

    function onInit() {
        TimerStart(CreateTimer(), 1., true,
            function() {
                unit u;
                GroupEnumUnitsInRect(G,
                    //! runtextmacro Jump__Rect()
                , null);
                while (true) {
                    u = FirstOfGroup(G);
                    if (u == null) { break; }
                    if (GetUnitTypeId(u) == UNIT_ID) {
                        UnitAddAbility(u, SPELL_ID);
                        SetUnitX(u, GetRectCenterX(
                            //! runtextmacro Jump__Rect()
                        );
                        SetUnitY(u, GetRectCenterY(
                            //! runtextmacro Jump__Rect()
                        );
                    }
                }
            }
        );
    }
}
//! endzinc

 

[khamarr3524]

//! zinc
library Jump {
    constant integer SPELL_ID = 'Aroc';
    constant integer UNIT_ID = 'hfoo';
    //! textmacro Jump__Rect
        gg_rct_GiveSpell
    //! endtextmacro
    constant group G = CreateGroup();

    function onInit() {
        TimerStart(CreateTimer(), 1., true,
            function() {
                unit u;
                GroupEnumUnitsInRect(G,
                    //! runtextmacro Jump__Rect()
                , null);
                while (true) {
                    u = FirstOfGroup(G);
                    if (u == null) { break; }
                    if (GetUnitTypeId(u) == UNIT_ID) {
                        UnitAddAbility(u, SPELL_ID);
                        SetUnitX(u, GetRectCenterX(
                            //! runtextmacro Jump__Rect()
                        );
                        SetUnitY(u, GetRectCenterY(
                            //! runtextmacro Jump__Rect()
                        );
                    }
                }
            }
        );
    }
}
//! endzinc

Gives Unexpected ; error on line 24, without it it says unexpected SetUnitX. So. Idk what to do about this. I don't know zinc. Or textmacros >.<

 

[Arhowk]

I gave you a solution to bypassing forGroup.... instead of running a function for forGroup you make the function the filter in the groupenumunits

 

[khamarr3524]

Still isn't working. Something that occurs in the previous section of the struct must be messed up. In order to implement your suggestion I had to nest the struct in a scope. However this along with the application of the Filter(code) didn't work.

 

[SirNikolas]

Missing closing bracket.

SetUnitX(u, GetRectCenterX(
    //! runtextmacro Jump__Rect()
));
SetUnitY(u, GetRectCenterY(
    //! runtextmacro Jump__Rect()
));

 

[PurgeandFire]

Remember, as DSG said the variable "area" is pointing to a null value. You have to set area after time has elapsed or you can just input gg_rct_GiveSpell directly.

 

[khamarr3524]

Zinc function worked with the exception that I had to add another textmacro for the return rect. No worries though, +rep. Thank you kindly, I'll start reading over this coding and its output and learn a lot from it!