[JASS] No random item is created

[Barade]

Hi,
I have multiple custom spells which should spawn random items but no item is created:

call UnitAddItemByIdSwapped( ChooseRandomItemBJ(1), GetTriggerUnit() )

This is the code converted from a GUI trigger.
Why is not item created? There should be at least one random item type with level 1 right?
It does not work for other levels either.
I have disabled "Include into Random Choice" for some item types but not all and not too many.

 

[Elprede]

Which event are you using to trigger the item creation?

I just tested on a blank map. I was only getting tomes for level 1.

Are you aware that the ChooseRandomItem function uses the items' unclassified level? There is a note regarding that in the GUI.

 

[Barade]

Yes I am aware and for example tomes I have disabled the "Include into Random Choice" so maybe no item types are left to be included?
Should I use a different function? Which one uses the classified level which seems to be better?

edit:
Found it. I will try this one now:

ChooseRandomItemExBJ(1, ITEM_TYPE_ANY)

 

[Pyrogasm]

If you want control over randomized item drops, I suggest you learn how to use ItemPools. JASS-only but not hard to work with and very useful.

Itempools Guide

This is a tutorial I decided to make, because from what i've experienced, very few people actually know about the itempool natives, and even fewer knows how to use them. Itempools are an internal system, just like a normal units droptable, you know, the ones where you doubleclick a unit, and...

www.hiveworkshop.com

 

[Cokemonkey11]

It would be good to document any surprising behavior in jassdoc/item.j at master · lep/jassdoc

 

[Barade]

thx but creating a custom item pool means maintaining more code and not just the object data. I am happy with the native.

 

[Pyrogasm]

ItemPools can have weights, which is the reason you would use them. If all your items should be equally likely then yeah you don’t benefit a ton.