[Trigger] Need Help With Trampling Ability Please

[Gumberbunbder]

• Sons of Rohan
  • Events
    • Time - Every 0.15 seconds of game time
  • Conditions
  • Actions
    • Set RohanRiderGroup = (Units of type Knight of Gondor)
    • Unit Group - Pick every unit in RohanRiderGroup and do (Actions)
      • Loop - Actions
        • Set RohanRider = (Picked unit)
        • Set RohanTrampleUnitPoint = (Position of RohanRider)
        • Set TrampledUnitsGroup = (Units within 130.00 of RohanTrampleUnitPoint matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of (Picked unit))) Equal to True) and ((((Matching unit) is A Hero) Equal to False) and ((((Matching
        • Unit Group - Pick every unit in TrampledUnitsGroup and do (Actions)
          • Loop - Actions
            • Set RohanTrampleUnit = (Picked unit)
            • Set RohanTrampleUnitPointOffset = (RohanTrampleUnitPoint offset by 140.00 towards (Angle from RohanTrampleUnitPoint to (Position of RohanTrampleUnit)) degrees)
            • Unit - Move RohanTrampleUnit instantly to RohanTrampleUnitPointOffset, facing (Position of RohanRider)
    • Custom script: call DestroyGroup (udg_RohanRiderGroup)
    • Custom script: call DestroyGroup (udg_TrampledUnitsGroup)
    • Custom script: call RemoveLocation (udg_RohanTrampleUnitPoint)
    • Custom script: call RemoveLocation (udg_RohanTrampleUnitPointOffset)

I'm trying to make cavalry units push specific enemy units out of the way as they move. The issue I have is leakage. I'm not good with triggers and I want to know the best way to make a stable version of what I'm trying to do.

Also, is there a way to detect if a unit is moving or not moving? I would like to disable the trample effect when the cavalry units are not moving and enable it when they are. Thank you for your time

 

[Wietlol]

Isn't the "Pick units of type" leaking on its own?

But next to that, you should move the remove location and group inside the loops.

• Actions
  • Set RohanRiderGroup = (Units of type Knight of Gondor)
  • Unit Group - Pick every unit in RohanRiderGroup and do (Actions)
    • Loop - Actions
      • Set RohanRider = (Picked unit)
      • Set RohanTrampleUnitPoint = (Position of RohanRider)
      • Set TrampledUnitsGroup = (Units within 130.00 of RohanTrampleUnitPoint matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of (Picked unit))) Equal to True) and ((((Matching unit) is A Hero) Equal to False) and ((((Matching
      • Unit Group - Pick every unit in TrampledUnitsGroup and do (Actions)
        • Loop - Actions
          • Set RohanTrampleUnit = (Picked unit)
          • Set RohanTrampleUnitPointOffset = (RohanTrampleUnitPoint offset by 140.00 towards (Angle from RohanTrampleUnitPoint to (Position of RohanTrampleUnit)) degrees)
          • Unit - Move RohanTrampleUnit instantly to RohanTrampleUnitPointOffset, facing (Position of RohanRider)
          • Custom script: call DestroyGroup (udg_TrampledUnitsGroup)
          • Custom script: call RemoveLocation (udg_RohanTrampleUnitPointOffset)
      • Custom script: call DestroyGroup (udg_RohanRiderGroup)
      • Custom script: call RemoveLocation (udg_RohanTrampleUnitPoint)

That should improve your performance a lot.

 

[ZiBitheWand3r3r]

• Sons of Rohan
  • Events
    • Time - Every 0.15 seconds of game time
  • Conditions
  • Actions
    • Set RohanRiderGroup = (Units of type Knight of Gondor)
    • Unit Group - Pick every unit in RohanRiderGroup and do (Actions)
      • Loop - Actions
        • Set RohanRider = (Picked unit)
        • Set RohanTrampleUnitPoint = (Position of RohanRider)
        • Set TrampledUnitsGroup = (Units within 130.00 of RohanTrampleUnitPoint matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of (Picked unit))) Equal to True) and ((((Matching unit) is A Hero) Equal to False) and ((((Matching
        • Unit Group - Pick every unit in TrampledUnitsGroup and do (Actions)
          • Loop - Actions
            • Set RohanTrampleUnit = (Picked unit)
            • Set RohanTrampleUnitPointOffset = (RohanTrampleUnitPoint offset by 140.00 towards (Angle from RohanTrampleUnitPoint to (Position of RohanTrampleUnit)) degrees)
            • Unit - Move RohanTrampleUnit instantly to RohanTrampleUnitPointOffset, facing (Position of RohanRider)
            • Custom script: call RemoveLocation (udg_RohanTrampleUnitPointOffset)
        • Custom script: call RemoveLocation (udg_RohanTrampleUnitPoint)
        • Custom script: call DestroyGroup (udg_TrampledUnitsGroup)
    • Custom script: call DestroyGroup (udg_RohanRiderGroup)

I'm trying to make cavalry units push specific enemy units out of the way as they move. The issue I have is leakage. I'm not good with triggers and I want to know the best way to make a stable version of what I'm trying to do.

Also, is there a way to detect if a unit is moving or not moving? I would like to disable the trample effect when the cavalry units are not moving and enable it when they are. Thank you for your time

https://www.hiveworkshop.com/forums/spells-569/gui-unit-indexer-1-2-0-2-a-197329/

https://www.hiveworkshop.com/forums/spells-569/unit-moving-2-0-0-0-a-199189/

Isn't the "Pick units of type" leaking on its own?

like wietlol said, dont use this, use pick unit matching cond instead
zibi

 

[Gumberbunbder]

Isn't the "Pick units of type" leaking on its own? But next to that, you should move the remove location and group inside the loops.

Not sure why the remove location actions are inside the loops, they are outside of them on my map. When i pasted the trigger to the thread it must have changed the spacing a little or something. But thanks for helping, i dont really understand why there is a "pick units of type" option if it is inevitably going to leak, thats kinda dumb.

Should i use "pick unit in playable map area matching condition"? does the region thing cause any problem? and within that should the condition be unit of type or some other condition? i mean, is there a problem with the unit of type condition all together?

 

[Wietlol]

woops I see that the last 3 removes are one block too far to the right... I just copied his trigger and added 4 spaces on every thing but I think I miscalculated

 

[Gumberbunbder]

So, after i fix the "pick units of type", will it be mostly leakless?