[Help]Units can't move even with buttons!

[cboy123]

=Title=
Ok I made a transportation system here.

Trigger1

• Follow Charon
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set MP = (Position of Ferry_Charon)
    • Player Group - Pick every player in Ferry_Charon_Group and do (Actions)
      • Loop - Actions
        • Camera - Pan camera for (Picked player) to MP over 0.00 seconds
        • Selection - Select Ferry_Charon for (Picked player)
    • Custom script: call RemoveLocation (udg_MP)

Trigger2

• Move Charon to Limbo
  • Events
    • Unit - A unit enters Move Charon 1 <gen>
  • Conditions
    • (Entering unit) Equal to Ferry_Charon
  • Actions
    • Unit Group - Pick every unit in Ferry_Charon_Passengers and do (Actions)
      • Loop - Actions
        • Unit - Unhide (Picked unit)
        • Unit - Unpause (Picked unit)
        • Set MP = (Random point in Call for Charon 1 <gen>)
        • Unit - Move (Picked unit) instantly to MP
        • Custom script: call RemoveLocation (udg_MP)
        • Unit - Deny shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Selection - Select (Picked unit) for (Owner of (Picked unit))
    • Player Group - Remove all players from Ferry_Charon_Group
    • Unit Group - Remove all units from Ferry_Charon_Passengers
    • Game - Display to (All players) for 0.50 seconds the text: The Ferry Charon ha...
    • Wait 15.00 seconds
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in Call for Charon 1 <gen> matching ((((Matching unit) belongs to an ally of Player 9 (Gray)) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to Neutral Passive)))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to Ferry_Charon_Passengers
        • Unit - Hide (Picked unit)
        • Unit - Pause (Picked unit)
        • Unit - Grant shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Player Group - Add (Owner of (Picked unit)) to Ferry_Charon_Group
    • Set MP = (Center of Move Charon to Cave 2 <gen>)
    • Unit - Order Ferry_Charon to Move To MP
    • Custom script: call RemoveLocation (udg_MP)

Trigger3

• Move Charon to Inner Hell
  • Events
    • Unit - A unit enters Move Charon 2 <gen>
  • Conditions
    • (Entering unit) Equal to Ferry_Charon
  • Actions
    • Unit Group - Pick every unit in Ferry_Charon_Passengers and do (Actions)
      • Loop - Actions
        • Unit - Unhide (Picked unit)
        • Unit - Unpause (Picked unit)
        • Set MP = (Random point in Call for Charon 2 <gen>)
        • Unit - Move (Picked unit) instantly to MP
        • Custom script: call RemoveLocation (udg_MP)
        • Unit - Deny shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Selection - Select (Picked unit) for (Owner of (Picked unit))
    • Player Group - Remove all players from Ferry_Charon_Group
    • Unit Group - Remove all units from Ferry_Charon_Passengers
    • Game - Display to (All players) for 0.50 seconds the text: The Ferry Charon ha...
    • Wait 15.00 seconds
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in Call for Charon 2 <gen> matching ((((Matching unit) belongs to an ally of Player 9 (Gray)) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to Neutral Passive)))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to Ferry_Charon_Passengers
        • Unit - Hide (Picked unit)
        • Unit - Pause (Picked unit)
        • Unit - Grant shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Player Group - Add (Owner of (Picked unit)) to Ferry_Charon_Group
    • Set MP = (Center of Move Charon to Cave 1 <gen>)
    • Unit - Order Ferry_Charon to Move To MP
    • Custom script: call RemoveLocation (udg_MP)

When the Ship docks, I still can select my hero but even I command him to move to a point, he just ignore me and stay at his place. I even try attack ground to it but nothing works. Also I try to command him his (Instant) and (Point) Target Ability but still he just ignore my commands. Can you help me?

 

[defskull]

Can you post the map ?
I think you're not unpausing the unit, back ?
He's paused, is it ?
This line:

• Unit Group - Pick every unit in (Units in Call for Charon 1 <gen> matching ((((Matching unit) belongs to an ally of Player 9 (Gray)) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to Neutral Passive)))) and do (Actions)
  • Loop - Actions
  • Unit Group - Add (Picked unit) to Ferry_Charon_Passengers
  • Unit - Hide (Picked unit)
  • Unit - Pause (Picked unit)
  • Unit - Grant shared vision of Ferry_Charon to (Owner of (Picked unit))
  • Player Group - Add (Owner of (Picked unit)) to Ferry_Charon_Group

 

[cboy123]

Well that is the time where Charon would pick them up and go to the other side of the river. It is working but when I try it with my friend yesterday, I got stuck.

 

[InfinateAnswers]

Ill tell you whats wrong with it, and ill tell you how to fix it.

• Wait 15 seconds

Thats whats wrong with this trigger, if you step on that region twice within 15 seconds if freezes the trigger in an infinite loop never finishing only starting

Now to fix it you have to set up a counter, make a periodic event trigger and add a number to an integer, so for example

• Game - Display to (All Players) for .50 seconds seconds....
• Trigger - Turn on Timer <gen>

• Events
  • Time - Every 1 second
• Conditions
• Actions
  • Set Timer = Timer + 1
  • If (Conditions) are true, then do (Then) actions else do (Else) actions
    • If - Conditions
      • (Timer) equals 15
    • Then - Actions
      • Trigger - Turn off (This Trigger)
    • Else - Actions

 

[mckill2009]

This is really bad...>>> Time - Every 0.01 seconds of game time...Use 0.03 instead...

The point MP is REMOVED in every 0.01 so no wonder your hero cant move there...

the MP is a global variable so better to set a NEW location variable or better local variable to let your unit move...

 

[sentrywiz]

Like others said above:

You use waits. If your gonna use waits either:
-have the spell/ability be unique for one unit/hero/building whatever
-don't use it on more than one occasion, thus granting the triggers the time for it to successfully finish and not stuck itself in a loop

However, for your spell:
-you want it multi unit instancable (MUI) and use waits. Not gonna happen
-your picking everything 0.01 seconds of game time. Thats 100 times of a second. Nothing moves that fast :S

What you should fix (already mentioned above)
-use timer instead of a wait
-input every 0.5 - 1 second of game time, since you are moving something anyway


If you fixed your events because you read all this written, reward the users who posted above first with reps

 

[Bribe]

Moved to Triggers & Scripts.

 

[defskull]

What mckill said, was true
You removed the location by using the custom script
Your timing on removing the location is bad, therefore, the function returns null, NO point is available

 

[cboy123]

Like others said above:

You use waits. If your gonna use waits either:
-have the spell/ability be unique for one unit/hero/building whatever
-don't use it on more than one occasion, thus granting the triggers the time for it to successfully finish and not stuck itself in a loop

However, for your spell:
-you want it multi unit instancable (MUI) and use waits. Not gonna happen
-your picking everything 0.01 seconds of game time. Thats 100 times of a second. Nothing moves that fast :S

What you should fix (already mentioned above)
-use timer instead of a wait
-input every 0.5 - 1 second of game time, since you are moving something anyway


If you fixed your events because you read all this written, reward the users who posted above first with reps

Well, This is not a spell. This is a Transport System. I need only a solution that would fix my problem about stucking units even with their buttons are on.

 

[InfinateAnswers]

waits are bad, fix the waits, probably fix the system

 

[defskull]

Even if it's not a spell, it is a trigger, get it ?

 

[cboy123]

Ok I done everything you asked for.

Trigger1

• Follow Charon
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Set MP = (Position of Ferry_Charon)
    • Player Group - Pick every player in Ferry_Charon_Group and do (Actions)
      • Loop - Actions
        • Camera - Pan camera for (Picked player) to MP over 0.00 seconds
        • Selection - Select Ferry_Charon for (Picked player)
    • Custom script: call RemoveLocation (udg_MP)

Trigger2

• Move Charon to Limbo
  • Events
    • Unit - A unit enters Move Charon 1 <gen>
  • Conditions
    • (Entering unit) Equal to Ferry_Charon
  • Actions
    • Unit Group - Pick every unit in Ferry_Charon_Passengers and do (Actions)
      • Loop - Actions
        • Set MP = (Random point in Docks 1 <gen>)
        • Unit - Move (Picked unit) instantly to MP
        • Custom script: call RemoveLocation (udg_MP)
        • Unit - Unhide (Picked unit)
        • Unit - Unpause (Picked unit)
        • Set MP = (Random point in Call for Charon 1 <gen>)
        • Unit - Move (Picked unit) instantly to MP
        • Custom script: call RemoveLocation (udg_MP)
        • Unit - Deny shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Selection - Select (Picked unit) for (Owner of (Picked unit))
    • Player Group - Remove all players from Ferry_Charon_Group
    • Unit Group - Remove all units from Ferry_Charon_Passengers
    • Countdown Timer - Start Ferry_Charon_Timer[1] as a One-shot timer that will expire in 20.00 seconds

Trigger3

• Move Charon to Limbo Timer
  • Events
    • Time - Ferry_Charon_Timer[1] expires
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in Call for Charon 1 <gen> matching ((((Matching unit) belongs to an ally of Player 9 (Gray)) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to Neutral Passive)))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to Ferry_Charon_Passengers
        • Unit - Hide (Picked unit)
        • Unit - Pause (Picked unit)
        • Unit - Grant shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Player Group - Add (Owner of (Picked unit)) to Ferry_Charon_Group
    • Set MP = (Center of Move Charon to Cave 2 <gen>)
    • Unit - Order Ferry_Charon to Move To MP
    • Custom script: call RemoveLocation (udg_MP)

Trigger4

• Move Charon to Inner Hell
  • Events
    • Unit - A unit enters Move Charon 2 <gen>
  • Conditions
    • (Entering unit) Equal to Ferry_Charon
  • Actions
    • Unit Group - Pick every unit in Ferry_Charon_Passengers and do (Actions)
      • Loop - Actions
        • Set MP = (Random point in Docks 2 <gen>)
        • Unit - Move (Picked unit) instantly to MP
        • Custom script: call RemoveLocation (udg_MP)
        • Unit - Unhide (Picked unit)
        • Unit - Unpause (Picked unit)
        • Unit - Deny shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Selection - Select (Picked unit) for (Owner of (Picked unit))
    • Player Group - Remove all players from Ferry_Charon_Group
    • Unit Group - Remove all units from Ferry_Charon_Passengers
    • Countdown Timer - Start Ferry_Charon_Timer[2] as a One-shot timer that will expire in 20.00 seconds

Trigger5

• Move Charon to Inner Hell Timer
  • Events
    • Time - Ferry_Charon_Timer[2] expires
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in Call for Charon 2 <gen> matching ((((Matching unit) belongs to an ally of Player 9 (Gray)) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to Neutral Passive)))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to Ferry_Charon_Passengers
        • Unit - Hide (Picked unit)
        • Unit - Pause (Picked unit)
        • Unit - Grant shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Player Group - Add (Owner of (Picked unit)) to Ferry_Charon_Group
    • Set MP = (Center of Move Charon to Cave 1 <gen>)
    • Unit - Order Ferry_Charon to Move To MP
    • Custom script: call RemoveLocation (udg_MP)

But for now I cannot test it because I got no playmates for a while.

 

[mckill2009]

Still this doesnt work coz like what I've told you, the MP is a global variable and it gets removed everytime by ALL your triggers, specially Trigger1...

You should make variables like MP1, MP2, etc...

 

[InfinateAnswers]

Yeah dont remove MP untill it is completely used up for that loop

 

[cboy123]

Ok then here comes another triggers. Hope I get the shot this time.

Trigger1

• Follow Charon
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Set Ferry_Charon_MP = (Position of Ferry_Charon)
    • Player Group - Pick every player in Ferry_Charon_Group and do (Actions)
      • Loop - Actions
        • Camera - Pan camera for (Picked player) to MP over 0.00 seconds
        • Selection - Select Ferry_Charon for (Picked player)
    • Custom script: call RemoveLocation (udg_Ferry_Charon_MP)

Trigger2

• Move Charon to Limbo
  • Events
    • Unit - A unit enters Move Charon 1 <gen>
  • Conditions
    • (Entering unit) Equal to Ferry_Charon
  • Actions
    • Unit Group - Pick every unit in Ferry_Charon_Passengers and do (Actions)
      • Loop - Actions
        • Set Ferry_Charon_MP_Dock = (Random point in Docks 1 <gen>)
        • Unit - Move (Picked unit) instantly to Ferry_Charon_MP_Dock
        • Custom script: call RemoveLocation (udg_Ferry_Charon_MP_Dock)
        • Unit - Unhide (Picked unit)
        • Unit - Unpause (Picked unit)
        • Unit - Deny shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Selection - Select (Picked unit) for (Owner of (Picked unit))
    • Player Group - Remove all players from Ferry_Charon_Group
    • Unit Group - Remove all units from Ferry_Charon_Passengers
    • Countdown Timer - Start Ferry_Charon_Timer[1] as a One-shot timer that will expire in 20.00 seconds

Trigger3

• Move Charon to Limbo Timer
  • Events
    • Time - Ferry_Charon_Timer[1] expires
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in Call for Charon 1 <gen> matching ((((Matching unit) belongs to an ally of Player 9 (Gray)) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to Neutral Passive)))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to Ferry_Charon_Passengers
        • Unit - Hide (Picked unit)
        • Unit - Pause (Picked unit)
        • Unit - Grant shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Player Group - Add (Owner of (Picked unit)) to Ferry_Charon_Group
    • Set Ferry_Charon_MP_Dock = (Center of Move Charon to Cave 2 <gen>)
    • Unit - Order Ferry_Charon to Move To Ferry_Charon_MP_Dock
    • Custom script: call RemoveLocation (udg_Ferry_Charon_MP_Dock)

Trigger4

• Move Charon to Inner Hell
  • Events
    • Unit - A unit enters Move Charon 2 <gen>
  • Conditions
    • (Entering unit) Equal to Ferry_Charon
  • Actions
    • Unit Group - Pick every unit in Ferry_Charon_Passengers and do (Actions)
      • Loop - Actions
        • Set Ferry_Charon_MP_Dock = (Random point in Docks 2 <gen>)
        • Unit - Move (Picked unit) instantly to Ferry_Charon_MP_Dock
        • Custom script: call RemoveLocation (udg_Ferry_Charon_MP_Dock)
        • Unit - Unhide (Picked unit)
        • Unit - Unpause (Picked unit)
        • Unit - Deny shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Selection - Select (Picked unit) for (Owner of (Picked unit))
    • Player Group - Remove all players from Ferry_Charon_Group
    • Unit Group - Remove all units from Ferry_Charon_Passengers
    • Countdown Timer - Start Ferry_Charon_Timer[2] as a One-shot timer that will expire in 20.00 seconds

Trigger5

• Move Charon to Inner Hell Timer
  • Events
    • Time - Ferry_Charon_Timer[2] expires
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in Call for Charon 2 <gen> matching ((((Matching unit) belongs to an ally of Player 9 (Gray)) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to Neutral Passive)))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to Ferry_Charon_Passengers
        • Unit - Hide (Picked unit)
        • Unit - Pause (Picked unit)
        • Unit - Grant shared vision of Ferry_Charon to (Owner of (Picked unit))
        • Player Group - Add (Owner of (Picked unit)) to Ferry_Charon_Group
    • Set Ferry_Charon_MP_Dock = (Center of Move Charon to Cave 1 <gen>)
    • Unit - Order Ferry_Charon to Move To Ferry_Charon_MP_Dock
    • Custom script: call RemoveLocation (udg_Ferry_Charon_MP_Dock)

 

[mckill2009]

The 'call' in "Units in Call for Charon 1 <gen>" is it a Range?...

The Charon 1 & 2 <gen> is bad, store the unit into a variable...

The countdown timer needs to be stored into a variable coz it will leak...

 

[Garfield1337]

Still this doesnt work coz like what I've told you, the MP is a global variable and it gets removed everytime by ALL your triggers, specially Trigger1...

You should make variables like MP1, MP2, etc...

He doesn't need more useless variables. It's not going to change anything.

The countdown timer needs to be stored into a variable coz it will leak...

Global Countdown timers don't leak.

 

[mckill2009]

that's not his trigger before, his MP is used in ALL triggers and using 0.01...

 

[Garfield1337]

that's not his trigger before, his MP is used in ALL triggers and using 0.01...

Using the same point in all triggers won't cause problems.

 

[cboy123]

Using the same point in all triggers won't cause problems.

Yeah as long as it is Remove Instantly.